From b166469fddb1682393034df04be1498ce09b5734 Mon Sep 17 00:00:00 2001 From: Robert Phillips Date: Thu, 4 Apr 2019 12:43:45 -0400 Subject: [PATCH] Blacklist two more GMs for gltestthreading These two GMs started having 1-2 magnitude diffs after the following CL landed: https://skia-review.googlesource.com/c/skia/+/205584 (Stop using pendingIO in read/writeSurfacePixels) This is because in the non-threaded case, Ganesh now always flushes when the SWMash helper uploads a mask - changing how backing GrSurfaces are reused. Change-Id: I5061d0bc79ea958f6ff8984c392d0baeb3cc298c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/206069 Commit-Queue: Robert Phillips Reviewed-by: Eric Boren --- ...NUC5PPYH-GPU-IntelHD405-x86_64-Release-All-Vulkan.json | 8 ++++++++ ...UC7i5BNK-GPU-IntelIris640-x86_64-Debug-All-Vulkan.json | 8 ++++++++ infra/bots/recipes/test.py | 5 ++++- 3 files changed, 20 insertions(+), 1 deletion(-) diff --git a/infra/bots/recipes/test.expected/Test-Debian9-Clang-NUC5PPYH-GPU-IntelHD405-x86_64-Release-All-Vulkan.json b/infra/bots/recipes/test.expected/Test-Debian9-Clang-NUC5PPYH-GPU-IntelHD405-x86_64-Release-All-Vulkan.json index 017b20762a..94f589974b 100644 --- a/infra/bots/recipes/test.expected/Test-Debian9-Clang-NUC5PPYH-GPU-IntelHD405-x86_64-Release-All-Vulkan.json +++ b/infra/bots/recipes/test.expected/Test-Debian9-Clang-NUC5PPYH-GPU-IntelHD405-x86_64-Release-All-Vulkan.json @@ -318,6 +318,14 @@ "gm", "_", "orientation", + "gltestthreading", + "gm", + "_", + "stroketext", + "gltestthreading", + "gm", + "_", + "draw_image_set", "_", "svg", "_", diff --git a/infra/bots/recipes/test.expected/Test-Debian9-Clang-NUC7i5BNK-GPU-IntelIris640-x86_64-Debug-All-Vulkan.json b/infra/bots/recipes/test.expected/Test-Debian9-Clang-NUC7i5BNK-GPU-IntelIris640-x86_64-Debug-All-Vulkan.json index 911cbb08d9..3aeca5cd31 100644 --- a/infra/bots/recipes/test.expected/Test-Debian9-Clang-NUC7i5BNK-GPU-IntelIris640-x86_64-Debug-All-Vulkan.json +++ b/infra/bots/recipes/test.expected/Test-Debian9-Clang-NUC7i5BNK-GPU-IntelIris640-x86_64-Debug-All-Vulkan.json @@ -318,6 +318,14 @@ "gm", "_", "orientation", + "gltestthreading", + "gm", + "_", + "stroketext", + "gltestthreading", + "gm", + "_", + "draw_image_set", "_", "svg", "_", diff --git a/infra/bots/recipes/test.py b/infra/bots/recipes/test.py index beb452884a..31a2918250 100644 --- a/infra/bots/recipes/test.py +++ b/infra/bots/recipes/test.py @@ -184,8 +184,11 @@ def dm_flags(api, bot): blacklist('gltestthreading gm _ persp_shaders_bw') blacklist('gltestthreading gm _ dftext_blob_persp') blacklist('gltestthreading gm _ dftext') - # skbug.com/7523 - Flaky on various GPUs + # skbug.com/7523 - Flaky on various GPUs blacklist('gltestthreading gm _ orientation') + # These GMs only differ in the low bits + blacklist('gltestthreading gm _ stroketext') + blacklist('gltestthreading gm _ draw_image_set') # CommandBuffer bot *only* runs the command_buffer config. if 'CommandBuffer' in bot: