Replace unimpl comments with = delete.

A handful of `unimpl`ed copy constructors were actually supplied as
{} instead of being left unimplemented, but they were not actually used.

Change-Id: I9b88173aeb0cc87f793ee40dfba1b5e5a06d7497
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/308565
Commit-Queue: John Stiles <johnstiles@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
This commit is contained in:
John Stiles 2020-08-06 19:58:52 -04:00 committed by Skia Commit-Bot
parent b3231b1526
commit b35c3b8bcd
15 changed files with 27 additions and 27 deletions

View File

@ -37,8 +37,8 @@ public:
private:
explicit SkDeferredDisplayListPriv(SkDeferredDisplayList* ddl) : fDDL(ddl) {}
SkDeferredDisplayListPriv(const SkDeferredDisplayListPriv&); // unimpl
SkDeferredDisplayListPriv& operator=(const SkDeferredDisplayListPriv&); // unimpl
SkDeferredDisplayListPriv(const SkDeferredDisplayListPriv&) = delete;
SkDeferredDisplayListPriv& operator=(const SkDeferredDisplayListPriv&) = delete;
// No taking addresses of this type.
const SkDeferredDisplayListPriv* operator&() const;

View File

@ -33,8 +33,8 @@ public:
private:
explicit GrBaseContextPriv(GrContext_Base* context) : fContext(context) {}
GrBaseContextPriv(const GrBaseContextPriv&); // unimpl
GrBaseContextPriv& operator=(const GrBaseContextPriv&); // unimpl
GrBaseContextPriv(const GrBaseContextPriv&) = delete;
GrBaseContextPriv& operator=(const GrBaseContextPriv&) = delete;
// No taking addresses of this type.
const GrBaseContextPriv* operator&() const;

View File

@ -162,8 +162,8 @@ public:
private:
explicit GrContextPriv(GrContext* context) : fContext(context) {}
GrContextPriv(const GrContextPriv&); // unimpl
GrContextPriv& operator=(const GrContextPriv&); // unimpl
GrContextPriv(const GrContextPriv&) = delete;
GrContextPriv& operator=(const GrContextPriv&) = delete;
// No taking addresses of this type.
const GrContextPriv* operator&() const;

View File

@ -81,7 +81,7 @@ private:
CacheAccess(GrGpuResource* resource) : fResource(resource) {}
CacheAccess(const CacheAccess& that) : fResource(that.fResource) {}
CacheAccess& operator=(const CacheAccess&); // unimpl
CacheAccess& operator=(const CacheAccess&) = delete;
// No taking addresses of this type.
const CacheAccess* operator&() const = delete;

View File

@ -75,7 +75,7 @@ public:
protected:
ResourcePriv(GrGpuResource* resource) : fResource(resource) { }
ResourcePriv(const ResourcePriv& that) : fResource(that.fResource) {}
ResourcePriv& operator=(const CacheAccess&); // unimpl
ResourcePriv& operator=(const CacheAccess&) = delete;
// No taking addresses of this type.
const ResourcePriv* operator&() const;

View File

@ -39,8 +39,8 @@ public:
private:
explicit GrImageContextPriv(GrImageContext* context) : fContext(context) {}
GrImageContextPriv(const GrImageContextPriv&); // unimpl
GrImageContextPriv& operator=(const GrImageContextPriv&); // unimpl
GrImageContextPriv(const GrImageContextPriv&) = delete;
GrImageContextPriv& operator=(const GrImageContextPriv&) = delete;
// No taking addresses of this type.
const GrImageContextPriv* operator&() const;

View File

@ -115,8 +115,8 @@ public:
private:
explicit GrRecordingContextPriv(GrRecordingContext* context) : fContext(context) {}
GrRecordingContextPriv(const GrRecordingContextPriv&); // unimpl
GrRecordingContextPriv& operator=(const GrRecordingContextPriv&); // unimpl
GrRecordingContextPriv(const GrRecordingContextPriv&) = delete;
GrRecordingContextPriv& operator=(const GrRecordingContextPriv&) = delete;
// No taking addresses of this type.
const GrRecordingContextPriv* operator&() const;

View File

@ -116,8 +116,8 @@ public:
private:
explicit GrRenderTargetContextPriv(GrRenderTargetContext* renderTargetContext)
: fRenderTargetContext(renderTargetContext) {}
GrRenderTargetContextPriv(const GrRenderTargetContextPriv&) {} // unimpl
GrRenderTargetContextPriv& operator=(const GrRenderTargetContextPriv&); // unimpl
GrRenderTargetContextPriv(const GrRenderTargetContextPriv&) = delete;
GrRenderTargetContextPriv& operator=(const GrRenderTargetContextPriv&) = delete;
// No taking addresses of this type.
const GrRenderTargetContextPriv* operator&() const;

View File

@ -29,8 +29,8 @@ public:
private:
explicit GrRenderTargetProxyPriv(GrRenderTargetProxy* renderTargetProxy)
: fRenderTargetProxy(renderTargetProxy) {}
GrRenderTargetProxyPriv(const GrRenderTargetProxyPriv&) {} // unimpl
GrRenderTargetProxyPriv& operator=(const GrRenderTargetProxyPriv&); // unimpl
GrRenderTargetProxyPriv(const GrRenderTargetProxyPriv&) = delete;
GrRenderTargetProxyPriv& operator=(const GrRenderTargetProxyPriv&) = delete;
// No taking addresses of this type.
const GrRenderTargetProxyPriv* operator&() const;

View File

@ -373,7 +373,7 @@ class GrResourceCache::ResourceAccess {
private:
ResourceAccess(GrResourceCache* cache) : fCache(cache) { }
ResourceAccess(const ResourceAccess& that) : fCache(that.fCache) { }
ResourceAccess& operator=(const ResourceAccess&); // unimpl
ResourceAccess& operator=(const ResourceAccess&) = delete;
/**
* Insert a resource into the cache.

View File

@ -19,8 +19,8 @@ public:
private:
explicit GrResourceProviderPriv(GrResourceProvider* provider) : fResourceProvider(provider) {}
GrResourceProviderPriv(const GrResourceProviderPriv&); // unimpl
GrResourceProviderPriv& operator=(const GrResourceProviderPriv&); // unimpl
GrResourceProviderPriv(const GrResourceProviderPriv&) = delete;
GrResourceProviderPriv& operator=(const GrResourceProviderPriv&) = delete;
// No taking addresses of this type.
const GrResourceProviderPriv* operator&() const;

View File

@ -22,8 +22,8 @@ private:
: fSurfaceContext(surfaceContext) {
}
GrSurfaceContextPriv(const GrSurfaceContextPriv&) {} // unimpl
GrSurfaceContextPriv& operator=(const GrSurfaceContextPriv&); // unimpl
GrSurfaceContextPriv(const GrSurfaceContextPriv&) = delete;
GrSurfaceContextPriv& operator=(const GrSurfaceContextPriv&) = delete;
// No taking addresses of this type.
const GrSurfaceContextPriv* operator&() const;

View File

@ -42,8 +42,8 @@ public:
private:
explicit GrSurfaceProxyPriv(GrSurfaceProxy* proxy) : fProxy(proxy) {}
GrSurfaceProxyPriv(const GrSurfaceProxyPriv&) {} // unimpl
GrSurfaceProxyPriv& operator=(const GrSurfaceProxyPriv&); // unimpl
GrSurfaceProxyPriv(const GrSurfaceProxyPriv&) = delete;
GrSurfaceProxyPriv& operator=(const GrSurfaceProxyPriv&) = delete;
// No taking addresses of this type.
const GrSurfaceProxyPriv* operator&() const;

View File

@ -24,8 +24,8 @@ private:
}
explicit CacheAccess(GrTextureProxy* textureProxy) : fTextureProxy(textureProxy) {}
CacheAccess(const CacheAccess&) {} // unimpl
CacheAccess& operator=(const CacheAccess&); // unimpl
CacheAccess(const CacheAccess&) = delete;
CacheAccess& operator=(const CacheAccess&) = delete;
// No taking addresses of this type.
const CacheAccess* operator&() const;

View File

@ -30,8 +30,8 @@ public:
private:
explicit GrTextureProxyPriv(GrTextureProxy* textureProxy) : fTextureProxy(textureProxy) {}
GrTextureProxyPriv(const GrTextureProxyPriv&) {} // unimpl
GrTextureProxyPriv& operator=(const GrTextureProxyPriv&); // unimpl
GrTextureProxyPriv(const GrTextureProxyPriv&) = delete;
GrTextureProxyPriv& operator=(const GrTextureProxyPriv&) = delete;
// No taking addresses of this type.
const GrTextureProxyPriv* operator&() const;