AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Improve comments describing common sRGB curves

Browse Source 
BUG=skia:5897

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4037

Change-Id: Id1253cc9b960aad47bc0f9b7e40f10830d46d98d
Reviewed-on: https://skia-review.googlesource.com/4037
Reviewed-by: Heather Miller <hcm@google.com>
Commit-Queue: Matt Sarett <msarett@google.com>
This commit is contained in:
Matt Sarett 2016-10-27 12:44:18 -04:00 committed by Skia Commit-Bot
parent 23d73ea5b4
commit b3d1c2ea48
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/core/SkColorSpace_ICC.cpp
View File

@ -357,8 +357,8 @@ static SkGammas::Type parse_gamma(SkGammas::Data* outData, SkColorSpaceTransferF
}
if (26 == count) {
// The magic values were chosen because they match a very common LCMS sRGB
// gamma table.
// The magic values match a clever "minimum size" approach to representing sRGB.
// code.facebook.com/posts/411525055626587/under-the-hood-improving-facebook-photos
if (0 == read_big_endian_u16((const uint8_t*) &table[0]) &&
3062 == read_big_endian_u16((const uint8_t*) &table[6]) &&
12824 == read_big_endian_u16((const uint8_t*) &table[12]) &&
@ -371,7 +371,7 @@ static SkGammas::Type parse_gamma(SkGammas::Data* outData, SkColorSpaceTransferF
if (4096 == count) {
// The magic values were chosen because they match Nikon, Epson, and
// LCMS sRGB gamma tables (all of which use different rounding rules).
// lcms2 sRGB gamma tables (all of which use different rounding rules).
if (0 == read_big_endian_u16((const uint8_t*) &table[0]) &&
950 == read_big_endian_u16((const uint8_t*) &table[515]) &&
3342 == read_big_endian_u16((const uint8_t*) &table[1025]) &&