AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Extend __mulodi4() hack to 32-bit x86.

Browse Source 
This gets the Android-Clang-x86 perf bot from failing on __mulodi4() to failing on the next problem...

See https://luci-milo.appspot.com/swarming/task/3042e5f68636f810/steps/nanobench/0/stdout

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2190493002

Review-Url: https://codereview.chromium.org/2190493002
This commit is contained in:
mtklein 2016-07-27 05:35:28 -07:00 committed by Commit bot
parent 9f97882322
commit b464764dae
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gyp/dng_sdk.gyp
View File

@ -143,9 +143,9 @@
['skia_os != "linux"', {
'sources': ['<@(headers)'],
}],
['skia_arch_type == "arm" and skia_clang_build', {
['(skia_arch_type == "arm" or skia_arch_type == "x86") and skia_clang_build', {
# DNG SDK uses __builtin_smulll_overflow() to detect 64x64 bit multiply overflow.
# On ARMv7, Clang implements this with __mulodi4() in libclang_rt.
# On ARMv7 and 32-bit x86, Clang implements this with __mulodi4() in libclang_rt.
# I can't quite figure out how to link that here, so instead here's a shim for
# __builtin_smulll_overflow() that multiplies normally assuming no overflow.
# Tracked in b/29412086.