AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Update remaining Skia docs to point to new inclusive rotations

Browse Source 
Bug: skia:11034
Change-Id: I36a46116c89ff1b4f04ed1d563e49547d5cc4cb5
No-Try: true
Docs-Preview: https://skia.org/?cl=347859
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/347859
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
This commit is contained in:
Ravi Mistry 2020-12-28 10:49:31 -05:00 committed by Skia Commit-Bot
parent 4cb6beed9b
commit b5d30dc414
5 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
site/dev/chrome/blink.md
View File

@ -69,7 +69,7 @@ See https://chromium.googlesource.com/chromium/src/+log/master/DEPS and search f
Then the auto rebaseline bot will take care of the work of actually checking in the
new images. This is generally acceptable for up to 600 or so rebaselined images.
Above that you might still use [ NeedsRebaseline ], but it's best to coordinate with
the gardener/sheriff. This should go through the CQ cleanly.
the gardener. This should go through the CQ cleanly.
3. Be careful with tests that are already failing or flakey. These may or may not need
to be rebaselined and flakey tests should not be removed from TestExpectations
regardless. In such cases revert the TestExpectations changes before committing.

6
site/dev/chrome/index.md
View File

@ -14,9 +14,9 @@ For problems in Chromium related to Skia rolls:
account and click the STOP button to pause new rolls.
* Revert the offending DEPS roll.
* If an obvious owner cannot be found in the list of CLs, assign to the Skia
Sheriff, listed at the top of https://status.skia.org and as a reviewer
on the roll CL.
* If the Sheriff cannot be assigned, cc them and assign the issue to hcm@.
Gardener, listed in the gardeners widget on https://status.skia.org and as
a reviewer on the roll CL.
* If the Skia Gardener cannot be assigned, cc them and assign the issue to hcm@.
For more tips on bug triage and labeling, see the [Issue Tracker page](../../user/issue-tracker/).

2
site/dev/testing/skiagold.md
View File

@ -35,7 +35,7 @@ navigation on [gold.skia.org](https://gold.skia.org/).
View access is public, triage access is granted to
Skia contributors. You must be logged in to triage.
Problem #1: As sheriff, I need to triage and “assign” many incoming new images.
Problem #1: As Skia Gardener, I need to triage and “assign” many incoming new images.
-------------------------------------------------------------------------------
Solution today:

8
site/dev/testing/swarmingbots.md
View File

@ -24,7 +24,7 @@ Skia's Swarming bots are hosted in three places:
Connecting to Swarming Bots
---------------------------
If you need to make changes on a bot/device, please check with the Trooper or another Infra team member. Most
If you need to make changes on a bot/device, please check with the Infra Gardener or another Infra team member. Most
bots/devices can be flashed/imaged back to a clean state, but others can not.
- Machine name like “skia-e-gce-NNN”, “skia-ct-gce-NNN”, “skia-i-gce-NNN”, “ct-gce-NNN”, “ct-xxx-builder-NNN” -> GCE
@ -57,10 +57,10 @@ run tryjobs (after adding debugging output to the relevant code). In some cases
[create or modify tryjobs](automated_testing#adding-new-jobs).
For Googlers: If you need more control (e.g. to run GDB) and need to run directly on a swarming bot then you can use [leasing.skia.org](https://leasing.skia.org).<br/>
If that does not work then the [current trooper][current trooper] can help you bring the device back to your desk and connect
If that does not work then the [current infra gardener][current infra gardener] can help you bring the device back to your desk and connect
it to GoogleGuest Wifi or the [Google Test Network](http://go/gtn-criteria).
If you need to make changes on a bot/device, please check with the Trooper or another Infra team member. Most
If you need to make changes on a bot/device, please check with the Infra Gardener or another Infra team member. Most
bots/devices can be flashed/imaged back to a clean state, but others can not.
If a permanent change needs to be made on the machine (such as an OS or driver update), please [file
@ -69,7 +69,7 @@ a bug][infra bug] and assign to jcgregorio for reassignment.
For your convenience, the machine skolo-builder is available for checking out and compiling code within the Skolo. See
more info in the [Skolo maintenance doc][remote access] remote access section.
[current trooper]: http://tree-status.skia.org/trooper
[current infra gardener]: https://rotations.corp.google.com/rotation/4617277386260480
[remote access]:
https://docs.google.com/document/d/1zTR1YtrIFBo-fRWgbUgvJNVJ-s_4_sNjTrHIoX2vulo/edit#heading=h.v77cmwbwc5la
[infra bug]: https://bugs.chromium.org/p/skia/issues/entry?template=Infrastructure+Bug

6
site/user/issue-tracker.md
View File

@ -20,9 +20,9 @@ Skia bugs found in Chrome may be filed in the [Chromium Tracker](https://bugs.ch
### Triage for Chromium developers
* To have an issue triaged by the Skia team, add `Component:Internals>Skia`.
* For problems related to Skia rolls where an obvious owner cannot be found in
the list of CLs, assign to the Skia Sheriff, listed at the top of
[status.skia.org](https://status.skia.org) and as a reviewer on the roll CL.
* If the Sheriff cannot be assigned, cc them and assign the issue to hcm@.
the list of CLs, assign to the Skia Gardener, listed in the gardeners widget
on [status.skia.org](https://status.skia.org) and as a reviewer on the roll CL.
* If the Gardener cannot be assigned, cc them and assign the issue to hcm@.
* For GPU specific issues, add label `Hotlist-Ganesh`.
* For image encoding or decoding issues, add
`Component:Internals>Images>Codecs`.