AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Don't pretend we can draw MaskFilters, it produces artifacts that make the text unreadable when using CSS shadows.

Browse Source 
Review URL: https://codereview.chromium.org/12989032

git-svn-id: http://skia.googlecode.com/svn/trunk@8351 2bbb7eff-a529-9590-31e7-b0007b416f81
This commit is contained in:
edisonn@google.com 2013-03-24 18:05:10 +00:00
parent 7e32851d54
commit b62f93fdbc
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/pdf/SkPDFDevice.cpp
View File

@ -946,6 +946,12 @@ void SkPDFDevice::drawSprite(const SkDraw& d, const SkBitmap& bitmap,
void SkPDFDevice::drawText(const SkDraw& d, const void* text, size_t len, void SkPDFDevice::drawText(const SkDraw& d, const void* text, size_t len,
SkScalar x, SkScalar y, const SkPaint& paint) { SkScalar x, SkScalar y, const SkPaint& paint) {
NOT_IMPLEMENTED(paint.getMaskFilter() != NULL, false);
if (paint.getMaskFilter() != NULL) {
// Don't pretend we support drawing MaskFilters, it makes for artifacts
// making text unreadable (e.g. same text twice when using CSS shadows).
return;
}
SkPaint textPaint = calculate_text_paint(paint); SkPaint textPaint = calculate_text_paint(paint);
ScopedContentEntry content(this, d, textPaint, true); ScopedContentEntry content(this, d, textPaint, true);
if (!content.entry()) { if (!content.entry()) {
@ -985,6 +991,12 @@ void SkPDFDevice::drawText(const SkDraw& d, const void* text, size_t len,
void SkPDFDevice::drawPosText(const SkDraw& d, const void* text, size_t len, void SkPDFDevice::drawPosText(const SkDraw& d, const void* text, size_t len,
const SkScalar pos[], SkScalar constY, const SkScalar pos[], SkScalar constY,
int scalarsPerPos, const SkPaint& paint) { int scalarsPerPos, const SkPaint& paint) {
NOT_IMPLEMENTED(paint.getMaskFilter() != NULL, false);
if (paint.getMaskFilter() != NULL) {
// Don't pretend we support drawing MaskFilters, it makes for artifacts
// making text unreadable (e.g. same text twice when using CSS shadows).
return;
}
SkASSERT(1 == scalarsPerPos || 2 == scalarsPerPos); SkASSERT(1 == scalarsPerPos || 2 == scalarsPerPos);
SkPaint textPaint = calculate_text_paint(paint); SkPaint textPaint = calculate_text_paint(paint);
ScopedContentEntry content(this, d, textPaint, true); ScopedContentEntry content(this, d, textPaint, true);