AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Add noinline for GCC 4.6, which seems to vectorize after inlining.

Browse Source 
GCC 4.7 and 4.8 don't need this, but we're not building with them so it doesn't hurt.

BUG=skia:
R=mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/343423003
This commit is contained in:
mtklein 2014-06-25 12:40:51 -07:00 committed by Commit bot
parent 7c4c63a62e
commit b726df472b
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/core/SkConvolver.cpp
View File

@ -159,9 +159,9 @@ template<bool hasAlpha>
}
// There's a bug somewhere here with GCC autovectorization (-ftree-vectorize) on 32 bit builds.
// Dropping to -O2 disables -ftree-vectorize. http://skbug.com/2575
// Dropping to -O2 disables -ftree-vectorize. GCC 4.6 needs noinline. http://skbug.com/2575
#if defined(__i386) && SK_HAS_ATTRIBUTE(optimize) && defined(SK_RELEASE)
#define SK_MAYBE_DISABLE_VECTORIZATION __attribute__((optimize("O2")))
#define SK_MAYBE_DISABLE_VECTORIZATION __attribute__((optimize("O2"), noinline))
#else
#define SK_MAYBE_DISABLE_VECTORIZATION
#endif