AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Stop running image tests on msaa.

Browse Source 
Blacklist all image tests on msaa. We do not run them anyway (since
they will not do anything interestingly different from drawing to the
raster backend) - we early exit from Src::draw(), but we still need to
create a render target that matches the size of the image (when not
blacklisted).

Remove the more specific blacklist of a particular image, which is
covered by this one.

BUG=skia:4045

Review URL: https://codereview.chromium.org/1234313006
This commit is contained in:
scroggo 2015-07-16 12:36:10 -07:00 committed by Commit bot
parent d2ce18520e
commit c1121efbc6
2 changed files with 45 additions and 41 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

80
tools/dm_flags.json
View File

@ -20,11 +20,11 @@
"gm",
"image",
"--blacklist",
"gpu",
"_",
"_",
"PANO_20121023_214540.jpg",
"msaa",
"image",
"_",
"_",
"gpu",
"_",
"_",
"PANO_20121023_214540.jpg",
@ -178,11 +178,11 @@
"--threads",
"0",
"--blacklist",
"gpu",
"_",
"_",
"PANO_20121023_214540.jpg",
"msaa",
"image",
"_",
"_",
"gpu",
"_",
"_",
"PANO_20121023_214540.jpg",
@ -309,11 +309,11 @@
"--threads",
"0",
"--blacklist",
"gpu",
"_",
"_",
"PANO_20121023_214540.jpg",
"msaa",
"image",
"_",
"_",
"gpu",
"_",
"_",
"PANO_20121023_214540.jpg",
@ -437,11 +437,11 @@
"tests",
"gm",
"--blacklist",
"gpu",
"_",
"_",
"PANO_20121023_214540.jpg",
"msaa",
"image",
"_",
"_",
"gpu",
"_",
"_",
"PANO_20121023_214540.jpg",
@ -567,11 +567,11 @@
"tests",
"gm",
"--blacklist",
"gpu",
"_",
"_",
"PANO_20121023_214540.jpg",
"msaa",
"image",
"_",
"_",
"gpu",
"_",
"_",
"PANO_20121023_214540.jpg",
@ -693,11 +693,11 @@
"gm",
"image",
"--blacklist",
"gpu",
"_",
"_",
"PANO_20121023_214540.jpg",
"msaa",
"image",
"_",
"_",
"gpu",
"_",
"_",
"PANO_20121023_214540.jpg",
@ -833,11 +833,11 @@
"gm",
"image",
"--blacklist",
"gpu",
"_",
"_",
"PANO_20121023_214540.jpg",
"msaa",
"image",
"_",
"_",
"gpu",
"_",
"_",
"PANO_20121023_214540.jpg",
@ -971,11 +971,11 @@
"gm",
"image",
"--blacklist",
"gpu",
"_",
"_",
"PANO_20121023_214540.jpg",
"msaa",
"image",
"_",
"_",
"gpu",
"_",
"_",
"PANO_20121023_214540.jpg",
@ -1132,11 +1132,11 @@
"tests",
"gm",
"--blacklist",
"gpu",
"_",
"_",
"PANO_20121023_214540.jpg",
"msaa",
"image",
"_",
"_",
"gpu",
"_",
"_",
"PANO_20121023_214540.jpg",
@ -1293,11 +1293,11 @@
"tests",
"gm",
"--blacklist",
"gpu",
"_",
"_",
"PANO_20121023_214540.jpg",
"msaa",
"image",
"_",
"_",
"gpu",
"_",
"_",
"PANO_20121023_214540.jpg",

6
tools/dm_flags.py
View File

@ -80,9 +80,13 @@ def get_args(bot):
args.extend(('--threads', '0'))
blacklist = []
# We do not draw image sources on msaa anyway, so avoid the creation of
# large canvases. skbug.com/4045
blacklist.extend('msaa image _ _'.split(' '))
# This image is too large to be a texture for many GPUs.
blacklist.extend('gpu _ _ PANO_20121023_214540.jpg'.split(' '))
blacklist.extend('msaa _ _ PANO_20121023_214540.jpg'.split(' '))
# Several of the newest version bmps fail on SkImageDecoder
blacklist.extend('_ image decode pal8os2v2.bmp'.split(' '))