all colorfilters but RT converted to skvm

Change-Id: I51a0b5cb9c14f44f3af9cd8748f4e1c866f3441c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/280096
Auto-Submit: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
This commit is contained in:
Mike Reed 2020-03-27 17:08:41 -04:00 committed by Skia Commit-Bot
parent ffa16148f6
commit c6b17ef292
3 changed files with 7 additions and 6 deletions

View File

@ -137,7 +137,7 @@ private:
virtual bool onAppendStages(const SkStageRec& rec, bool shaderIsOpaque) const = 0;
virtual skvm::Color onProgram(skvm::Builder*, skvm::Color,
SkColorSpace* dstCS, skvm::Uniforms*, SkArenaAlloc*) const;
SkColorSpace* dstCS, skvm::Uniforms*, SkArenaAlloc*) const = 0;
typedef SkFlattenable INHERITED;
};

View File

@ -54,11 +54,6 @@ skvm::Color SkColorFilter::program(skvm::Builder* p, skvm::Color c,
}
return c;
}
return {};
}
skvm::Color SkColorFilter::onProgram(skvm::Builder*, skvm::Color,
SkColorSpace*, skvm::Uniforms*, SkArenaAlloc*) const {
//SkDebugf("cannot onProgram %s\n", this->getTypeName());
return {};
}

View File

@ -12,6 +12,7 @@
#include "include/private/SkMutex.h"
#include "src/core/SkRasterPipeline.h"
#include "src/core/SkReadBuffer.h"
#include "src/core/SkVM.h"
#include "src/core/SkWriteBuffer.h"
#include "src/sksl/SkSLByteCode.h"
#include "src/sksl/SkSLCompiler.h"
@ -413,6 +414,11 @@ public:
return true;
}
skvm::Color onProgram(skvm::Builder*, skvm::Color, SkColorSpace* dstCS, skvm::Uniforms*,
SkArenaAlloc*) const override {
return {}; // <-- this signals failure -- TODO
}
void flatten(SkWriteBuffer& buffer) const override {
buffer.writeString(fEffect->source().c_str());
if (fInputs) {