AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Cache runtime color filter flags

Browse Source 
This slows down filter creation (300 ns -> 6000 ns),
... but speeds up the matrix_filterColor4f benchmark:

  before: 22000 ns
  after : 10000 ns

Bug: skia:11730
Change-Id: I5831688cbe0b6fbd8521fa5adab02ef0750b6190
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/383704
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Mike Reed <reed@google.com>
This commit is contained in:
Brian Osman 2021-03-11 11:08:23 -05:00 committed by Skia Commit-Bot
parent 48b255838c
commit c737a83709
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/core/SkRuntimeEffect.cpp
View File

@ -428,7 +428,8 @@ public:
size_t childCount)
: fEffect(std::move(effect))
, fUniforms(std::move(uniforms))
, fChildren(children, children + childCount) {}
, fChildren(children, children + childCount)
, fFlags(this->computeFlags()) {}
#if SK_SUPPORT_GPU
GrFPResult asFragmentProcessor(std::unique_ptr<GrFragmentProcessor> inputFP,
@ -499,7 +500,9 @@ public:
/*device=*/zeroCoord, /*local=*/zeroCoord, sampleChild);
}
uint32_t onGetFlags() const override {
uint32_t onGetFlags() const override { return fFlags; }
uint32_t computeFlags() const {
skvm::Builder p;
SkColorSpace* dstCS = sk_srgb_singleton(); // This _shouldn't_ matter for alpha.
skvm::Uniforms uniforms{p.uniform(), 0};
@ -533,6 +536,7 @@ private:
sk_sp<SkRuntimeEffect> fEffect;
sk_sp<SkData> fUniforms;
std::vector<sk_sp<SkColorFilter>> fChildren;
const uint32_t fFlags;
};
sk_sp<SkFlattenable> SkRuntimeColorFilter::CreateProc(SkReadBuffer& buffer) {