Make the c and ac scripts work with sh and without bin in PATH

Make the bin/c and bin/ac scripts work with sh. The scripts are run with
/bin/sh shebang, which fails atleast on ubuntu 12.04 /bin/sh. The sh in
Ubuntu 12.04 is dash.

The fixes are according to the suggestions in http://mywiki.wooledge.org/Bashism

Also run "compare" script with explicit ./bin/ path to support people
who do not have skia/bin in PATH.

Review URL: https://codereview.chromium.org/1139033005
This commit is contained in:
kkinnunen 2015-05-15 05:35:50 -07:00 committed by Commit bot
parent 27e517ae53
commit c77f6af7c3
2 changed files with 4 additions and 4 deletions

4
bin/ac
View File

@ -6,7 +6,7 @@ BRANCH=$(git branch | grep \* | cut -d" " -f 2)
CLEAN=${CLEAN-clean}
SAMPLES=100
if [ $BRANCH == $CLEAN ]; then
if [ "$BRANCH" = "$CLEAN" ]; then
echo "Comparing $BRANCH to itself."
exit 1
fi
@ -23,4 +23,4 @@ git checkout $BRANCH
platform_tools/android/bin/android_ninja -t Release nanobench
platform_tools/android/bin/android_run_skia -t Release nanobench $@ --skps /data/local/tmp/skps -i /data/local/tmp/resources --samples $SAMPLES -v > $BRANCH.log
compare $CLEAN.log $BRANCH.log
./bin/compare $CLEAN.log $BRANCH.log

4
bin/c
View File

@ -6,7 +6,7 @@ BRANCH=$(git branch | grep \* | cut -d" " -f 2)
CLEAN=${CLEAN-clean}
SAMPLES=100
if [ $BRANCH == $CLEAN ]; then
if [ "$BRANCH" = "$CLEAN" ]; then
echo "Comparing $BRANCH to itself."
exit 1
fi
@ -23,4 +23,4 @@ git checkout $BRANCH
ninja -C out/Release nanobench
out/Release/nanobench $@ --samples $SAMPLES -v 2> $BRANCH.log
compare $CLEAN.log $BRANCH.log
./bin/compare $CLEAN.log $BRANCH.log