AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Update documentation to specify the new Gerrit style CQ keywords

Browse Source 
BUG=skia:6667

NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=17762
Change-Id: I440b5565589102ae6026b5da4716fd43d4a48d6a
Reviewed-on: https://skia-review.googlesource.com/17762
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
This commit is contained in:
Ravi Mistry 2017-05-23 14:35:35 -04:00 committed by Skia Commit-Bot
parent 8a030557bd
commit c823fb598b
2 changed files with 12 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
site/dev/contrib/cqkeywords.md
View File

@ -14,10 +14,10 @@ To do a dry run through the CQ please use Gerrit's [CQ Dry Run](https://groups.g
The CQ will run through its list of verifiers (reviewer check, trybots, tree check,
presubmit check), and will close the issue instead of committing it.
NO_DEPENDENCY_CHECKS
No-Dependency-Checks
--------------------
NO_DEPENDENCY_CHECKS=true
No-Dependency-Checks: true
The CQ rejects patchsets with open dependencies. An open dependency exists when a CL
depends on another CL that is not yet closed. You can skip this check with this keyword.
@ -38,40 +38,31 @@ Here are some real world examples:
CQ_INCLUDE_TRYBOTS=skia.primary:Test-Win-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE
TBR
---
If you are a Skia committer and cannot wait for a review,
then you can include the TBR keyword in your CL's description.
Example:
TBR=rmistry@google.com
NOTREECHECKS
------------
No-Tree-Checks
--------------
If you want to skip the tree status checks, to make the CQ commit a CL even if the tree is closed,
you can add the following line to the CL description:
NOTREECHECKS=true
No-Tree-Checks: true
This is discouraged, since the tree is closed for a reason. However, in rare cases this is acceptable,
primarily to fix build breakages (i.e., your CL will help in reopening the tree).
NOPRESUBMIT
-----------
No-Presubmit
------------
If you want to skip the presubmit checks, add the following line to the CL description:
NOPRESUBMIT=true
No-Presubmit: true
NOTRY
-----
No-Try
------
If you cannot wait for the try job results, you can add the following line to the CL description:
NOTRY=true
No-Try: true
The CQ will then not run any try jobs for your change and will commit the CL as soon as the tree is open, assuming the presubmit check passes.

2
site/dev/sheriffing/index.md
View File

@ -114,7 +114,7 @@ Look at all existing [BreakingTheBuildbots bugs](https://bug.skia.org/?q=label:B
### How to submit when the tree is closed
* Submit manually using the "git cl land" with the --bypass-hooks flag.
* Add "NOTREECHECKS=true" to your CL description and use the CQ as usual.
* Add "No-Tree-Checks: true" to your CL description and use the CQ as usual.
<a name="tree_closers"></a>