AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix Typescript type hints for CanvasKit debug traces.

Browse Source 
The tests for these methods are only handled in Javascript, so the type
mismatches weren't detected until I tried using the calls in Typescript
later.

Change-Id: Ifb233f871be1146d3f059b166b7de40bb401d4c9
Bug: skia:12818
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/495417
Commit-Queue: John Stiles <johnstiles@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
This commit is contained in:
John Stiles 2022-01-14 11:41:13 -05:00 committed by SkCQ
parent 6658fd1584
commit cabc3f5209
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
modules/canvaskit/npm_build/types/index.d.ts vendored
View File

@ -3337,7 +3337,7 @@ export interface DebugTrace extends EmbindObject<DebugTrace> {
}
export interface TracedShader {
shader: RuntimeEffect;
shader: Shader;
debugTrace: DebugTrace;
}
@ -3356,7 +3356,7 @@ export interface RuntimeEffectFactory {
* @param traceCoordX - the X coordinate of the device-space pixel to trace
* @param traceCoordY - the Y coordinate of the device-space pixel to trace
*/
MakeTraced(shader: RuntimeEffect, traceCoordX: number, traceCoordY: number): TracedShader;
MakeTraced(shader: Shader, traceCoordX: number, traceCoordY: number): TracedShader;
}
/**