diff --git a/gm/rebaseline_server/static/loader.js b/gm/rebaseline_server/static/loader.js index efdab3b460..80f84c6a3a 100644 --- a/gm/rebaseline_server/static/loader.js +++ b/gm/rebaseline_server/static/loader.js @@ -45,13 +45,7 @@ Loader.controller( $scope.categories = data.categories; $scope.testData = data.testData; $scope.sortColumn = 'test'; - $scope.showTodos = false; - - $scope.dispositions = [ - 'Unfiled', 'Hidden', 'Pending Approval' - ]; - $scope.defaultDisposition = $scope.dispositions[0]; - $scope.viewingDisposition = $scope.defaultDisposition; + $scope.showTodos = true; for (var i = 0; i < $scope.testData.length; i++) { $scope.testData[i].index = i; @@ -119,10 +113,6 @@ Loader.controller( $scope.areUpdatesPending = true; } - $scope.setViewingDisposition = function(disposition) { - $scope.viewingDisposition = disposition; - } - $scope.localTimeString = function(secondsPastEpoch) { var d = new Date(secondsPastEpoch * 1000); return d.toString(); diff --git a/gm/rebaseline_server/static/view.css b/gm/rebaseline_server/static/view.css deleted file mode 100644 index c422bd003f..0000000000 --- a/gm/rebaseline_server/static/view.css +++ /dev/null @@ -1,6 +0,0 @@ -.disposition-tab-true { - background-color: #ccccff; -} -.disposition-tab-false { - background-color: #8888ff; -} diff --git a/gm/rebaseline_server/static/view.html b/gm/rebaseline_server/static/view.html index c8095a4d9f..9f0158d579 100644 --- a/gm/rebaseline_server/static/view.html +++ b/gm/rebaseline_server/static/view.html @@ -6,7 +6,6 @@ - @@ -14,75 +13,16 @@ {{loadingMessage}} -
- +
WARNING! These results are editable and exported, so any user who can connect to this server over the network can modify them.
- -
-

- TODO(epoger): - - show -

    -
  • - Implement editing of results (we have added the --editable - flag to the server, but it's not fully implemented yet). -
    - Currently selected items are: {{selectedItems}} -
    -
  • - If server was run with --reload flag, automatically check for - new results and tell the user when new results are available - (the user can reload the page if he wants to see them). -
  • - Add ability to filter builder and test names - (using a free-form text field, with partial string match) -
  • - Add more columns, such as pixel diffs, notes/bugs, - ignoreFailure boolean -
  • - Improve the column sorting, as per - - http://jsfiddle.net/vojtajina/js64b/14/ - -
  • - Right now, if you change which column is used to - sort the data, the column widths may fluctuate based on the - longest string currently visible within the top {{displayLimit}} - results. Can we fix the column widths to be wide enough to hold - any result, even the currently hidden results? -
    • -
-
-
Results current as of {{localTimeString(header.timeUpdated)}}
- -
-
-
-  {{disposition}}  -
-
-   -
-
-
- -
- -
- +
Filters @@ -140,19 +80,49 @@
+

+ TODO(epoger): + + show +

    +
  • + Implement editing of results (we have added the --editable + flag to the server, but it's not fully implemented yet). +
    + Currently selected items are: {{selectedItems}} +
    +
  • + If server was run with --reload flag, automatically check for + new results and tell the user when new results are available + (the user can reload the page if he wants to see them). +
  • + Add ability to filter builder and test names + (using a free-form text field, with partial string match) +
  • + Add more columns, such as pixel diffs, notes/bugs, + ignoreFailure boolean +
  • + Improve the column sorting, as per + + http://jsfiddle.net/vojtajina/js64b/14/ + +
  • + Right now, if you change which column is used to + sort the data, the column widths may fluctuate based on the + longest string currently visible within the top {{displayLimit}} + results. Can we fix the column widths to be wide enough to hold + any result, even the currently hidden results? +
    • +

- Found {{filteredTestData.length}} matches; - - displaying the first {{limitedTestData.length}} - - - displaying them all - -
- + Found {{filteredTestData.length}} matches, and displaying the first + {{displayLimit}}:
+ (click on the column header radio buttons to re-sort by that column)
-
@@ -206,8 +176,7 @@ ng-click="toggleItemSelected(result.index)">
-

-
+