From cf44feb0e192f255d598fa9a3f81b70968c98305 Mon Sep 17 00:00:00 2001
From: mtklein <mtklein@chromium.org>
Date: Mon, 2 Jun 2014 18:22:12 -0700
Subject: [PATCH] Clean up another silly race in benches when run concurrently.

BUG=skia:
R=mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/309193003
---
 bench/MatrixBench.cpp | 38 ++++++++++++++++----------------------
 1 file changed, 16 insertions(+), 22 deletions(-)

diff --git a/bench/MatrixBench.cpp b/bench/MatrixBench.cpp
index 7258ff579d..fa19fc8157 100644
--- a/bench/MatrixBench.cpp
+++ b/bench/MatrixBench.cpp
@@ -41,17 +41,6 @@ private:
     typedef SkBenchmark INHERITED;
 };
 
-// we want to stop the compiler from eliminating code that it thinks is a no-op
-// so we have a non-static global we increment, hoping that will convince the
-// compiler to execute everything
-int gMatrixBench_NonStaticGlobal;
-
-#define always_do(pred)                     \
-    do {                                    \
-        if (pred) {                         \
-            ++gMatrixBench_NonStaticGlobal; \
-        }                                   \
-    } while (0)
 
 class EqualsMatrixBench : public MatrixBench {
 public:
@@ -63,9 +52,12 @@ protected:
         m0.reset();
         m1.reset();
         m2.reset();
-        always_do(m0 == m1);
-        always_do(m1 == m2);
-        always_do(m2 == m0);
+
+        // xor into a volatile prevents these comparisons from being optimized away.
+        volatile bool junk = false;
+        junk ^= (m0 == m1);
+        junk ^= (m1 == m2);
+        junk ^= (m2 == m0);
     }
 private:
     typedef MatrixBench INHERITED;
@@ -243,21 +235,23 @@ protected:
         fMatrix.setAll(fArray[0], fArray[1], fArray[2],
                        fArray[3], fArray[4], fArray[5],
                        fArray[6], fArray[7], fArray[8]);
-        always_do(fMatrix.getType());
+        // xoring into a volatile prevents the compiler from optimizing these away
+        volatile int junk = 0;
+        junk ^= (fMatrix.getType());
         fMatrix.dirtyMatrixTypeCache();
-        always_do(fMatrix.getType());
+        junk ^= (fMatrix.getType());
         fMatrix.dirtyMatrixTypeCache();
-        always_do(fMatrix.getType());
+        junk ^= (fMatrix.getType());
         fMatrix.dirtyMatrixTypeCache();
-        always_do(fMatrix.getType());
+        junk ^= (fMatrix.getType());
         fMatrix.dirtyMatrixTypeCache();
-        always_do(fMatrix.getType());
+        junk ^= (fMatrix.getType());
         fMatrix.dirtyMatrixTypeCache();
-        always_do(fMatrix.getType());
+        junk ^= (fMatrix.getType());
         fMatrix.dirtyMatrixTypeCache();
-        always_do(fMatrix.getType());
+        junk ^= (fMatrix.getType());
         fMatrix.dirtyMatrixTypeCache();
-        always_do(fMatrix.getType());
+        junk ^= (fMatrix.getType());
     }
 private:
     SkMatrix fMatrix;