AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

SkRecord: clean up comments and 4 bytes per SkRecord.

Browse Source 
Just happened to notice these while skimming through.  The comments are a
little out of date; now that we have visit/mutate, we do need O(1) random
access.

The constructor arguments are flexibility we're not using.

BUG=skia:
R=fmalita@google.com

Author: mtklein@skia.org

Review URL: https://codereview.chromium.org/569373002
This commit is contained in:
mtklein 2014-09-15 14:26:57 -07:00 committed by Commit bot
parent f0ddf33f19
commit db26a1267d
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/core/SkRecord.h
View File

@ -26,9 +26,12 @@
// get this wrong.
class SkRecord : SkNoncopyable {
enum {
kChunkBytes = 4096,
kFirstReserveCount = 64 / sizeof(void*),
};
public:
SkRecord(size_t chunkBytes = 4096, unsigned firstReserveCount = 64 / sizeof(void*))
: fAlloc(chunkBytes), fCount(0), fReserved(0), kFirstReserveCount(firstReserveCount) {}
SkRecord() : fAlloc(kChunkBytes), fCount(0), fReserved(0) {}
~SkRecord() {
Destroyer destroyer;
@ -74,7 +77,7 @@ public:
template <typename T>
T* append() {
if (fCount == fReserved) {
fReserved = SkTMax(kFirstReserveCount, fReserved*2);
fReserved = SkTMax<unsigned>(kFirstReserveCount, fReserved*2);
fRecords.realloc(fReserved);
fTypes.realloc(fReserved);
}
@ -221,7 +224,7 @@ private:
// chunks, returning a stable handle to that data for later retrieval.
//
// fRecords and fTypes need to be data structures that can append fixed length data, and need to
// support efficient forward iteration. (They don't need to be contiguous or indexable.)
// support efficient random access and forward iteration. (They don't need to be contiguous.)
SkChunkAlloc fAlloc;
SkAutoTMalloc<Record> fRecords;
@ -229,7 +232,6 @@ private:
// fCount and fReserved measure both fRecords and fTypes, which always grow in lock step.
unsigned fCount;
unsigned fReserved;
const unsigned kFirstReserveCount;
};
#endif//SkRecord_DEFINED