From db9f66472e6e6a916bfc07052029a93c9332b5e5 Mon Sep 17 00:00:00 2001 From: bsalomon Date: Fri, 2 Oct 2015 08:34:28 -0700 Subject: [PATCH] Add work around for devices/API filters that claim GL_KHR_debug support but don't provide functions Review URL: https://codereview.chromium.org/1383763004 --- src/gpu/gl/GrGLAssembleInterface.cpp | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/gpu/gl/GrGLAssembleInterface.cpp b/src/gpu/gl/GrGLAssembleInterface.cpp index d7a0af8024..82c4457c92 100644 --- a/src/gpu/gl/GrGLAssembleInterface.cpp +++ b/src/gpu/gl/GrGLAssembleInterface.cpp @@ -755,6 +755,14 @@ const GrGLInterface* GrGLAssembleGLESInterface(void* ctx, GrGLGetProc get) { GET_PROC_SUFFIX(PushDebugGroup, KHR); GET_PROC_SUFFIX(PopDebugGroup, KHR); GET_PROC_SUFFIX(ObjectLabel, KHR); + // In general we have a policy against removing extension strings when the driver does + // not provide function pointers for an advertised extension. However, because there is a + // known device that advertises GL_KHR_debug but fails to provide the functions and this is + // a debugging- only extension we've made an exception. This also can happen when using + // APITRACE. + if (!interface->fFunctions.fDebugMessageControl) { + extensions.remove("GL_KHR_debug"); + } } interface->fStandard = kGLES_GrGLStandard;