AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Revert of DM: disable ignored and very niche configs on bots. (patchset #1 id:1 of https://codereview.chromium.org/1745073002/ )

Browse Source 
Reason for revert:
remote-8888 just caught a bug.  I am disproved.

Original issue's description:
> DM: disable ignored and very niche configs on bots.
>
> These are all probably just wasting time:
>   - upright-matrix-{8888,gpu} and remote[_cache] are ignored in Gold
>   - sp and 2ndpic test very niche areas of SkPicture
>     that are not under active change
>   - twice-8888 was never useful... the twice- via was meant for local
>     testing of GPU batching / caching.  Drawing into 8888 was moot.
>
> These configs are all useful to keep around for local testing, but probably are
> not worth the extra runtime or especially burden to have to think about them.
>
> If we should happen to stumble into bugs these configs would have caught,
> let's add them back with a note about those bugs to justify their need to run.
> I'm not convinced any exist today.
>
> This cuts ~30s off the CQ.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1745073002
>
> Committed: https://skia.googlesource.com/skia/+/7b6d3a30cf18377935c800603fc00fe0966d15de

TBR=halcanary@google.com,mtklein@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1749583003
This commit is contained in:
mtklein 2016-02-29 09:51:09 -08:00 committed by Commit bot
parent 85c6f9849e
commit dd54e5d557
2 changed files with 873 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

870
tools/dm_flags.json
View File

File diff suppressed because it is too large Load Diff

17
tools/dm_flags.py
View File

@ -31,6 +31,15 @@ def get_args(bot):
configs = ['565', '8888', 'gpu']
if 'Android' not in bot:
configs.extend(('upright-matrix-8888', 'upright-matrix-gpu'))
args.extend('--matrix 0 1 1 0'.split(' '))
if '-GCE-' in bot:
configs.append('sp-8888')
configs.extend(['twice-8888', '2ndpic-8888'])
configs.extend(['remote-8888', 'remote_cache-8888'])
if '-TSAN' not in bot:
if ('TegraK1' in bot or
'GTX550Ti' in bot or
@ -132,12 +141,18 @@ def get_args(bot):
'drawfilter',
'path_stroke_with_zero_length',
'textblobgeometrychange']:
blacklist.extend(['pic-8888', 'gm', '_', test])
blacklist.extend([ 'sp-8888', 'gm', '_', test])
blacklist.extend([ 'pic-8888', 'gm', '_', test])
blacklist.extend(['2ndpic-8888', 'gm', '_', test])
for test in ['patch_primitive']:
blacklist.extend(['sp-8888', 'gm', '_', test])
# skia:4703
for test in ['image-cacherator-from-picture',
'image-cacherator-from-raster',
'image-cacherator-from-ctable']:
blacklist.extend([ 'sp-8888', 'gm', '_', test])
blacklist.extend([ 'pic-8888', 'gm', '_', test])
blacklist.extend([ '2ndpic-8888', 'gm', '_', test])
blacklist.extend(['serialize-8888', 'gm', '_', test])
# Extensions for RAW images