AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

re-disable save/restore peephole optimization

Browse Source 
BUG=skia:5548, 629408
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2163283002

Review-Url: https://codereview.chromium.org/2163283002
This commit is contained in:
reed 2016-07-20 11:24:51 -07:00 committed by Commit bot
parent c526da94e4
commit de996a0df7
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/core/SkRecordOpts.cpp
View File

@ -276,7 +276,10 @@ void SkRecordOptimize(SkRecord* record) {
// out junk for other optimization passes. Right now, nothing needs it,
// and the bounding box hierarchy will do the work of skipping no-op
// Save-NoDraw-Restore sequences better than we can here.
SkRecordNoopSaveRestores(record);
// As there is a known problem with this peephole and drawAnnotation, disable this.
// If we want to enable this we must first fix this bug:
// https://bugs.chromium.org/p/skia/issues/detail?id=5548
// SkRecordNoopSaveRestores(record);
SkRecordNoopSaveLayerDrawRestores(record);
SkRecordMergeSvgOpacityAndFilterLayers(record);

4
tests/PictureTest.cpp
View File

@ -1246,6 +1246,8 @@ DEF_TEST(PictureGpuAnalyzer, r) {
///////////////////////////////////////////////////////////////////////////////////////////////////
// Disable until we properly fix https://bugs.chromium.org/p/skia/issues/detail?id=5548
#if 0
static void empty_ops(SkCanvas* canvas) {
}
static void clip_ops(SkCanvas* canvas) {
@ -1303,3 +1305,5 @@ DEF_TEST(Picture_RecordEmpty, r) {
}
}
}
#endif