AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

run Test-iOS-... bots with --threads 0.

Browse Source 
Yet another attempt to get the iOS bots stable.

As GPU testers, the iOS bots are already mostly single threaded,
but farm a good chunk of work like image encoding out to threads.

This will take them all the way to really single threaded.

BUG=skia:6748

Change-Id: I222e3ca402eee9d191c8a413b29a65d19c13e88a
Reviewed-on: https://skia-review.googlesource.com/20687
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
This commit is contained in:
Mike Klein 2017-06-23 13:30:17 -04:00 committed by Skia Commit-Bot
parent bc4c26b7a2
commit df669811b1
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
infra/bots/recipes/test.expected/Test-iOS-Clang-iPadMini4-GPU-GX6450-arm-Release.json
View File

@ -725,6 +725,8 @@
"dm", "dm",
"--nocpu", "--nocpu",
"--randomProcessorTest", "--randomProcessorTest",
"--threads",
"0",
"--config", "--config",
"8888", "8888",
"srgb", "srgb",

8
infra/bots/recipes/test.py
View File

@ -34,11 +34,15 @@ def dm_flags(bot):
# 32-bit desktop bots tend to run out of memory, because they have relatively # 32-bit desktop bots tend to run out of memory, because they have relatively
# far more cores than RAM (e.g. 32 cores, 3G RAM). Hold them back a bit. # far more cores than RAM (e.g. 32 cores, 3G RAM). Hold them back a bit.
if '-x86-' in bot and not 'NexusPlayer' in bot: if '-x86-' in bot and not 'NexusPlayer' in bot:
args.extend('--threads 4'.split(' ')) args.extend(['--threads', '4'])
# Avoid issues with dynamically exceeding resource cache limits. # Avoid issues with dynamically exceeding resource cache limits.
if 'Test' in bot and 'DISCARDABLE' in bot: if 'Test' in bot and 'DISCARDABLE' in bot:
args.extend('--threads 0'.split(' ')) args.extend(['--threads', '0'])
# See if staying on the main thread helps skia:6748.
if 'Test-iOS' in bot:
args.extend(['--threads', '0'])
# These are the canonical configs that we would ideally run on all bots. We # These are the canonical configs that we would ideally run on all bots. We
# may opt out or substitute some below for specific bots # may opt out or substitute some below for specific bots