AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

add suggested override

Browse Source 
Using Chromium's clang with skia_use_metal=true produces

    ../src/gpu/mtl/GrMtlCommandBuffer.h:25:5: warning: '~GrMtlCommandBuffer' overrides a destructor but is not marked 'override' [-Wsuggest-destructor-override]
        ~GrMtlCommandBuffer();

Change-Id: I177a6645a37cf9853b9284798eb48997428e1854
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/313808
Commit-Queue: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
This commit is contained in:
Mike Klein 2020-08-28 09:29:27 -05:00 committed by Skia Commit-Bot
parent 8a43e20660
commit e7f7158900
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/gpu/mtl/GrMtlCommandBuffer.h
View File

@ -22,7 +22,7 @@ class GrMtlOpsRenderPass;
class GrMtlCommandBuffer : public SkRefCnt { class GrMtlCommandBuffer : public SkRefCnt {
public: public:
static sk_sp<GrMtlCommandBuffer> Make(id<MTLCommandQueue> queue); static sk_sp<GrMtlCommandBuffer> Make(id<MTLCommandQueue> queue);
~GrMtlCommandBuffer(); ~GrMtlCommandBuffer() override;
bool commit(bool waitUntilCompleted); bool commit(bool waitUntilCompleted);
bool hasWork() { return fHasWork; } bool hasWork() { return fHasWork; }