AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix use-after-move in GrPixmapBase

Browse Source 
Fix a use-after-move issue in GrPixmapBase, as found by clang-tidy:

  gpu/GrPixmap.h:65:
  'info' used after it was moved
  gpu/GrPixmap.h:64:
  move occurred here

Bug: chromium:1122844
Change-Id: I7403805e3e63592119b66c1e5840bc48d5e33832
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/484176
Auto-Submit: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
This commit is contained in:
Maksim Ivanov 2021-12-14 02:17:39 +01:00 committed by SkCQ
parent d26057a2c0
commit ecbad28361
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/gpu/GrPixmap.h
View File

@ -62,7 +62,7 @@ protected:
GrPixmapBase(GrImageInfo info, T* addr, size_t rowBytes)
: fAddr(addr), fRowBytes(rowBytes), fInfo(std::move(info)) {
if (fRowBytes < info.minRowBytes() || !addr) {
if (fRowBytes < fInfo.minRowBytes() || !addr) {
*this = {};
}
}