AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[includes] Add pragma for SkTypes.h

Browse Source 
IWYU doesn't always understand that we want defines to come from
certain files, so we add a pragma to force it.

This also adds an extra entry to known_good_builds so I don't miss
this type of thing again when building locally.

Change-Id: I2321ea95edfc6a4506d51a011983965eb9bdf1c0
Bug: skia:13052
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/528164
Reviewed-by: John Stiles <johnstiles@google.com>
Owners-Override: Kevin Lubick <kjlubick@google.com>
This commit is contained in:
Kevin Lubick 2022-04-07 09:03:48 -04:00
parent 56b10759be
commit f0fdce0b42
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
bazel/Makefile
View File

@ -33,6 +33,7 @@ known_good_builds:
bazelisk build //src/svg/... --config=clang --features skia_enforce_iwyu bazelisk build //src/svg/... --config=clang --features skia_enforce_iwyu
bazelisk build //tools/debugger --config=clang --gpu_backend=gl_backend \ bazelisk build //tools/debugger --config=clang --gpu_backend=gl_backend \
--features skia_enforce_iwyu --features skia_enforce_iwyu
bazelisk build //:skia_core --config=clang --features skia_enforce_iwyu
rbe_known_good_builds: rbe_known_good_builds:
bazelisk build //experimental/bazel_test/... --config=linux-rbe bazelisk build //experimental/bazel_test/... --config=linux-rbe
@ -53,4 +54,5 @@ rbe_known_good_builds:
--gpu_backend=gl_backend --include_decoder=jpeg_decode_codec --gpu_backend=gl_backend --include_decoder=jpeg_decode_codec
bazelisk build //src/svg/... --config=linux-rbe --features skia_enforce_iwyu bazelisk build //src/svg/... --config=linux-rbe --features skia_enforce_iwyu
bazelisk build //tools/debugger --config=linux-rbe --gpu_backend=gl_backend \ bazelisk build //tools/debugger --config=linux-rbe --gpu_backend=gl_backend \
--features skia_enforce_iwyu --features skia_enforce_iwyu
bazelisk build //:skia_core --config=linux-rbe --features skia_enforce_iwyu

2
include/core/SkCustomMesh.h
View File

@ -8,7 +8,7 @@
#ifndef SkCustomMesh_DEFINED #ifndef SkCustomMesh_DEFINED
#define SkCustomMesh_DEFINED #define SkCustomMesh_DEFINED
#include "include/core/SkTypes.h" #include "include/core/SkTypes.h" // IWYU pragma: keep
#ifdef SK_ENABLE_SKSL #ifdef SK_ENABLE_SKSL
#include "include/core/SkAlphaType.h" #include "include/core/SkAlphaType.h"