AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

limit the rects width/height as well as its coords, when avoiding too-large

Browse Source 
rects for blur special-case.
Review URL: https://codereview.appspot.com/6850084

git-svn-id: http://skia.googlecode.com/svn/trunk@6523 2bbb7eff-a529-9590-31e7-b0007b416f81
This commit is contained in:
reed@google.com 2012-11-21 14:14:10 +00:00
parent bfe90370ea
commit f276fa74f5
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/effects/SkBlurMaskFilter.cpp
View File

@ -145,8 +145,9 @@ static bool drawRectsIntoMask(const SkRect rects[], int count, SkMask* mask) {
return true; return true;
} }
static bool rect_coordinates_exceed(const SkRect& r, SkScalar v) { static bool rect_exceeds(const SkRect& r, SkScalar v) {
return r.fLeft < -v || r.fTop < -v || r.fRight > v || r.fBottom > v; return r.fLeft < -v || r.fTop < -v || r.fRight > v || r.fBottom > v ||
r.width() > v || r.height() > v;
} }
SkMaskFilter::FilterReturn SkMaskFilter::FilterReturn
@ -160,7 +161,7 @@ SkBlurMaskFilterImpl::filterRectsToNine(const SkRect rects[], int count,
// TODO: take clipBounds into account to limit our coordinates up front // TODO: take clipBounds into account to limit our coordinates up front
// for now, just skip too-large src rects (to take the old code path). // for now, just skip too-large src rects (to take the old code path).
if (rect_coordinates_exceed(rects[0], SkIntToScalar(32767))) { if (rect_exceeds(rects[0], SkIntToScalar(32767))) {
return kUnimplemented_FilterReturn; return kUnimplemented_FilterReturn;
} }