AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove unneeded pipeline barrier in vulkan

Browse Source 
We don't need to syncronize the mapped memory writes to the buffer since
all CPU writes are already syncronized when we submit a command buffer. And we are using coherent memory for buffers so we don't need to call vkFlushMappedMemory

BUG=skia:

Review-Url: https://codereview.chromium.org/2289973002
This commit is contained in:
egdaniel 2016-08-29 13:42:55 -07:00 committed by Commit bot
parent 1703bd18ac
commit f5f97dd7ab
1 changed files with 0 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/gpu/vk/GrVkGpu.cpp
View File

@ -1153,27 +1153,6 @@ GrBackendObject GrVkGpu::createTestingOnlyBackendTexture(void* srcData, int w, i
1, &barrier));
initialLayout = VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL;
// Make sure buffer has finished the unmap
VkBufferMemoryBarrier bufBarrier;
memset(&barrier, 0, sizeof(VkImageMemoryBarrier));
bufBarrier.sType = VK_STRUCTURE_TYPE_BUFFER_MEMORY_BARRIER;
bufBarrier.pNext = nullptr;
bufBarrier.srcAccessMask = VK_ACCESS_HOST_WRITE_BIT;
bufBarrier.dstAccessMask = VK_ACCESS_TRANSFER_READ_BIT;
bufBarrier.srcQueueFamilyIndex = VK_QUEUE_FAMILY_IGNORED;
bufBarrier.dstQueueFamilyIndex = VK_QUEUE_FAMILY_IGNORED;
bufBarrier.buffer = buffer;
bufBarrier.offset = 0;
bufBarrier.size = bufInfo.size;
VK_CALL(CmdPipelineBarrier(cmdBuffer,
VK_PIPELINE_STAGE_TOP_OF_PIPE_BIT,
VK_PIPELINE_STAGE_TRANSFER_BIT,
0,
0, nullptr,
1, &bufBarrier,
0, nullptr));
// Submit copy command
VkBufferImageCopy region;
memset(&region, 0, sizeof(VkBufferImageCopy));