AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Add documentation for 'Suggested Reviewers' button.

Browse Source 
The button is now live, you can see it on this change as well.
Screencast of the button: https://screencast.googleplex.com/cast/NTQ5MzIzMDkxOTQ4MzM5MnwwZjM2YzQ2Yi1lNw

Change-Id: I7763bae8455453b5abd55d4c3a76db758c255a72
No-Try: true
Docs-Preview: https://skia.org/?cl=312840
Bugs: skia:10659
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/312840
Reviewed-by: Heather Miller <hcm@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
This commit is contained in:
Ravi Mistry 2020-08-24 11:49:57 -04:00 committed by Skia Commit-Bot
parent 6541013b53
commit f759eade0d
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

BIN
site/dev/contrib/SuggestedReviewers.png Normal file
View File

Binary file not shown.
Side by Side

After

Width:  |  Height:  |  Size: 129 KiB

8
site/dev/contrib/submit.md
View File

@ -74,8 +74,12 @@ on GitHub, might lead to issues with `git cl` usage.
### Find a reviewer
Ideally, the reviewer is someone who is familiar with the area of code you are
touching. If you have doubts, look at the git blame for the file to see who else
has been editing it.
touching. Look at the git blame for the file to see who else has been editing
it. If unsuccessful, another option is to click on the 'Suggested Reviewers' button
to add one of the listed Skia contacts. They should be able to add appropriate
reviewers for your change. The button is located here:
<img src="/dev/contrib/SuggestedReviewers.png" style="display: inline-block; max-width: 75%" />
### Uploading changes for review