AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix is_clang python3 encoding errors

Browse Source 
python 2.7 subprocess.check_output:

  "Run command with arguments and return its output as a byte string."

python 3 ubprocess.check_output:

  "By default, this function will return the data as encoded bytes."

Using a 'b' prefix seems to cover both cases.

Change-Id: Ie2d90bc93d0e98a723a262fae63fe538137812c5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/299382
Commit-Queue: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
This commit is contained in:
Florin Malita 2020-06-26 13:57:23 -04:00 committed by Skia Commit-Bot
parent fb355546c0
commit fa78f3b1cb
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gn/is_clang.py
View File

@ -11,8 +11,8 @@ import subprocess
import sys
cc,cxx = sys.argv[1:3]
if ('clang' in subprocess.check_output('%s --version' % cc, shell=True) and
'clang' in subprocess.check_output('%s --version' % cxx, shell=True)):
if (b'clang' in subprocess.check_output('%s --version' % cc, shell=True) and
b'clang' in subprocess.check_output('%s --version' % cxx, shell=True)):
print('true')
else:
print('false')