AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Revert of Try ARMv7 and NEON for Daisy. (patchset #1 id:1 of https://codereview.chromium.org/1054233002/)

Browse Source 
Reason for revert:
whatever compiler we're using can't handle array subscripts for neon vectors

Original issue's description:
> Try ARMv7 and NEON for Daisy.
>
> I think Daisy's color order problems are in non-NEON ARM assembly.
> NEON might actually be fine.
>
> BUG=skia:1843
>
> Committed: https://skia.googlesource.com/skia/+/a121c0ee6b911dd7004c6054a8692d37084b6b3d

TBR=mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:1843

Review URL: https://codereview.chromium.org/1058173002
This commit is contained in:
mtklein 2015-04-02 15:41:25 -07:00 committed by Commit bot
parent a121c0ee6b
commit fb806dd27d
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
platform_tools/chromeos/bin/chromeos_setup.sh
View File

@ -34,7 +34,8 @@ setup_device() {
GENERIC_BOARD_TYPE="amd64-generic"
;;
daisy)
DEFINES="${DEFINES} skia_arch_type=arm arm_version=7 arm_neon=1"
# TODO(mtklein): make this arm_version=7 arm_neon=1
DEFINES="${DEFINES} skia_arch_type=arm"
# TODO(borenet): We have to define skia_warnings_as_errors=0 for the arm
# build, which throws lots of "mangling of va_list has changed" warnings.
DEFINES="${DEFINES} skia_warnings_as_errors=0"