Revert of stop using brackets within skimage output filenames (https://codereview.chromium.org/303263012/)
Reason for revert: Broke http://108.170.220.120:10117/builders/Test-ChromeOS-Link-HD4000-x86_64-Release/builds/2806/steps/UploadSKImageResults/logs/stdio : [13:38:43.401942] /bin/sh: 1: Syntax error: "(" unexpected [13:38:43.902632] Command /home/chrome-bot/buildbot/skiabot-shuttle-ubuntu12-003/buildbot/third_party/chromium_buildbot/scripts/slave/../../third_party/gsutil/gsutil cp -a private /home/chrome-bot/buildbot/skiabot-shuttle-ubuntu12-003/buildbot/third_party/chromium_buildbot/slave/Test-ChromeOS-Link-HD4000-x86_64-Release/build/skia/out/Release/skimage_out/images/bitmap-64bitMD5/webp-test-webp-(123,263,587,394)/16263897892077508819.png gs://chromium-skia-gm/skimage/output/images/bitmap-64bitMD5/webp-test-webp-(123,263,587,394)/16263897892077508819.png failed with retcode 2, try 1. Original issue's description: > stop using brackets within skimage output filenames > > BUG=skia:2634 > > Committed: https://skia.googlesource.com/skia/+/f07892413cd2359549dc187f1d10bc48d7d263ba R=scroggo@google.com TBR=scroggo@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2634 Author: epoger@google.com Review URL: https://codereview.chromium.org/314443002
This commit is contained in:
parent
832cb66749
commit
fc435a020a
@ -595,7 +595,7 @@ static void decodeFileAndWrite(const char srcPath[], const SkString* writePath)
|
||||
SkBitmap bitmapFromDecodeSubset;
|
||||
// FIXME: Come up with a more representative set of rectangles.
|
||||
SkIRect rect = generate_random_rect(&rand, width, height);
|
||||
SkString subsetDim = SkStringPrintf("(%d,%d,%d,%d)", rect.fLeft, rect.fTop,
|
||||
SkString subsetDim = SkStringPrintf("[%d,%d,%d,%d]", rect.fLeft, rect.fTop,
|
||||
rect.fRight, rect.fBottom);
|
||||
if (codec->decodeSubset(&bitmapFromDecodeSubset, rect, gPrefConfig)) {
|
||||
SkString subsetName = SkStringPrintf("%s-%s", filename, subsetDim.c_str());
|
||||
|
Loading…
Reference in New Issue
Block a user