AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[SVGDom] Disable verbose parsing messages be default

Browse Source 
Guard with SK_VERBOSE_SVG_PARSING

R=robertphillips@google.com,rmistry@google.com,stephana@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2235963003

Review-Url: https://codereview.chromium.org/2235963003
This commit is contained in:
fmalita 2016-08-10 16:25:32 -07:00 committed by Commit bot
parent 27cdd94790
commit fea704e115
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
experimental/svg/model/SkSVGDOM.cpp
View File

@ -192,14 +192,18 @@ void set_string_attribute(const sk_sp<SkSVGNode>& node, const char* name, const
SkTo<int>(SK_ARRAY_COUNT(gAttributeParseInfo)), SkTo<int>(SK_ARRAY_COUNT(gAttributeParseInfo)),
name, sizeof(gAttributeParseInfo[0])); name, sizeof(gAttributeParseInfo[0]));
if (attrIndex < 0) { if (attrIndex < 0) {
#if defined(SK_VERBOSE_SVG_PARSING)
SkDebugf("unhandled attribute: %s\n", name); SkDebugf("unhandled attribute: %s\n", name);
#endif
return; return;
} }
SkASSERT(SkTo<size_t>(attrIndex) < SK_ARRAY_COUNT(gAttributeParseInfo)); SkASSERT(SkTo<size_t>(attrIndex) < SK_ARRAY_COUNT(gAttributeParseInfo));
const auto& attrInfo = gAttributeParseInfo[attrIndex].fValue; const auto& attrInfo = gAttributeParseInfo[attrIndex].fValue;
if (!attrInfo.fSetter(node, attrInfo.fAttr, value)) { if (!attrInfo.fSetter(node, attrInfo.fAttr, value)) {
#if defined(SK_VERBOSE_SVG_PARSING)
SkDebugf("could not parse attribute: '%s=\"%s\"'\n", name, value); SkDebugf("could not parse attribute: '%s=\"%s\"'\n", name, value);
#endif
} }
} }
@ -229,7 +233,9 @@ sk_sp<SkSVGNode> construct_svg_node(const SkDOM& dom, const ConstructionContext&
SkTo<int>(SK_ARRAY_COUNT(gTagFactories)), SkTo<int>(SK_ARRAY_COUNT(gTagFactories)),
elem, sizeof(gTagFactories[0])); elem, sizeof(gTagFactories[0]));
if (tagIndex < 0) { if (tagIndex < 0) {
#if defined(SK_VERBOSE_SVG_PARSING)
SkDebugf("unhandled element: <%s>\n", elem); SkDebugf("unhandled element: <%s>\n", elem);
#endif
return nullptr; return nullptr;
} }