Commit Graph

56324 Commits

Author SHA1 Message Date
skia-autoroll
9097b8b566 Roll Chromium from 699b730a7601 to 0169808c5c70 (468 revisions)
699b730a76..0169808c5c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-skia-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia/skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
Tbr: ethannicholas@google.com
Change-Id: I3327e08cb4b412f6f893d529aa55f5472d0ada79
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/430298
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-07-20 07:35:09 +00:00
skia-autoroll
3f6e8d8864 Roll SwiftShader from ba18c78e4696 to 7a7993b54e62 (17 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/ba18c78e4696..7a7993b54e62

2021-07-20 capn@google.com Remove -Xclang -fuse-init-array from the Android build flags
2021-07-19 capn@google.com Move remaining Subzero x86 traits to their corresponding class
2021-07-19 capn@google.com Move Subzero Inst traits to the Inst header/source
2021-07-19 capn@google.com Move Subzero Assembler traits to the Assembler header/source
2021-07-19 capn@google.com Refactor AsmAddress creation
2021-07-19 capn@google.com Make AsmAddress producing methods static
2021-07-19 capn@google.com Increase Subzero x86-64 stack alignment to 16
2021-07-19 capn@google.com Fix RequiredStackAlignment initialization
2021-07-19 capn@google.com Rename Subzero Address to AsmAddress
2021-07-19 capn@google.com Rename Subzero traits Operand to AsmOperand
2021-07-19 capn@google.com Specialize Subzero X86 backends for 32- or 64-bit
2021-07-19 capn@google.com Don't templatize based on X86 traits
2021-07-19 capn@google.com Deduplicate X86 condition codes
2021-07-19 capn@google.com De-templatize the IceAssemblerX86Base class
2021-07-19 capn@google.com Duplicate X86 headers into X8632 and X8664 ones
2021-07-19 capn@google.com Define specialized PoolTypeConverter constants in the header
2021-07-19 adrian.ratiu@collabora.corp-partner.google.com Backport LLVM fix for mallinfo deprecation

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-skia-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Test-Debian10-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
Bug: None
Tbr: ethannicholas@google.com
Change-Id: I49dbf192438f3ed7d47645f9654dadb65d429d27
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/430297
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-07-20 06:41:13 +00:00
skia-autoroll
deb297a99d Roll ANGLE from 4d9e1f230fa7 to 6a86d2079fd3 (18 revisions)
4d9e1f230f..6a86d2079f

2021-07-20 jgilbert@mozilla.com Add a feature flag allowES3OnFL10_0 to allow ES3 on d3d10.0.
2021-07-20 jgilbert@mozilla.com Add missing header to build config.
2021-07-19 jmadill@chromium.org Trace Tests: Autodetect Goma.
2021-07-19 kbr@chromium.org Fix multiple end2end crashes in direct-to-MSL compiler.
2021-07-19 jmadill@chromium.org GN: Update dcheck/assert conditions.
2021-07-19 jmadill@chromium.org Implement EGL_KHR_mutable_render_buffer in the front-end.
2021-07-19 syoussefi@chromium.org Revert "Ignore VUID-VkSpecializationMapEntry-constantID-00776"
2021-07-19 Richard Coles android: Explicitly specify exported activities.
2021-07-19 m.maiya@samsung.com Bug fix in ValidateCopyImageSubDataBase
2021-07-19 m.maiya@samsung.com Vulkan: Add support for YUV internal format extension
2021-07-19 jmadill@chromium.org Capture/Replay tests: Fix missing usage of ApplicationDir.
2021-07-19 jgilbert@mozilla.com Build fixes needed by Firefox circa 2021-feb.
2021-07-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from 6b9a0f391fa4 to 571256871c2e (17 revisions)
2021-07-19 jmadill@chromium.org Vulkan: Remove loader logging message in RendererVk.
2021-07-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from ba18c78e4696 to c6747d98397d (1 revision)
2021-07-19 yang.gu@intel.com Extend Intel graphics driver version to 2 fields
2021-07-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from ac347590d69b to f8ef6fcfb849 (67 revisions)
2021-07-19 cnorthrop@google.com Skip GLSLTest_ES31.BoolInInterfaceBlocks/ES3_1_OpenGL AMD Linux

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Tbr: ethannicholas@google.com
Test: Test: Texture2DTestES3.TexStorage2D*Yuv*Vulkan*
Test: Test: dEQP-GLES31.functional.debug.
Change-Id: I9837f813daaa741912adbc8244f53a2516d3e32c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/430296
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-07-20 06:19:59 +00:00
recipe-roller
2373b9ed96 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (depot_tools, recipe_engine) into this repository.

depot_tools:
5b118d1441
  5b118d1 (bryner@google.com)
      cpython3 3.8.10.chromium.20 to depot_tools stable.

recipe_engine:
5530960b32~..fcea2752f66155b22774bbf1a0261bfa507fd1c8
  5530960 (iannucci@chromium.org)
      Clean up OWNERS files
  0d98efc (yiwzhang@google.com)
      fix the script that updates 3p lib
  d284048 (yiwzhang@google.com)
      py3: decode bytes to utf-8 string before writing to log stream
  01cb0aa (yiwzhang@google.com)
      py3: make a few recipe modules work in python3
  fcea275 (yiwzhang@google.com)
      test: separate luciexe test from run test

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I07e7199192cb5f714ef4b9090b38ce2b1ccf3cf4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/430221
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-20 04:14:39 +00:00
Chris Dalton
38a6e5aa1a Reland "Enable vertex ID support on Metal"
This reverts commit 7069804621.

Bug: skia:12010
Change-Id: Ifbb17904e0157020481b3f98aaefb98df5150afb
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429298
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2021-07-20 03:30:59 +00:00
John Stiles
a6648599b5 Take the dest color as an input to SkBlenderBase::asFragmentProcessor.
Previously, the dest color was implicitly the surface that we were
drawing onto. When setting the blender on an SkPaint, this is still the
case. For other uses, e.g. a SkBlendImageFilter, the caller may want to
supply an arbitrary input FP.

Bug: skia:12085, skia:12205
Change-Id: I254be006a0f374711fa64f49e0ba339578d8d83a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/430059
Commit-Queue: John Stiles <johnstiles@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2021-07-20 03:08:29 +00:00
skia-autoroll
168daa5fad Roll SK Tool from 47f5c4e7bd7d to 82a43529dda7
https://skia.googlesource.com/buildbot.git/+log/47f5c4e7bd7d..82a43529dda7

2021-07-19 kjlubick@google.com [goldctl] Update to use v2 SQL endpoint
2021-07-19 rmistry@google.com [skcq] Do not notify when votes are removed. A comment is added later anyway

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/sk-tool-skia
Please CC lovisolo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: lovisolo@google.com
Change-Id: I3a2088a021c6434ad135ff5764371bc34f1cd16b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/430160
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-07-20 02:29:00 +00:00
recipe-roller
3ba7b28341 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (depot_tools, recipe_engine) into this repository.

depot_tools:
eaa87fa1f1
  eaa87fa (yyanagisawa@chromium.org)
      Roll out new goma client binary VERSION=227

recipe_engine:
b4e57a6c1a
  b4e57a6 (gbeaty@chromium.org)
      Reduce the severity of logs for recipe_modules non-issues.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I2fba0125f65bd3e6b855c51fd911c547e449453f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429957
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-20 00:41:23 +00:00
Brian Osman
f57f12d53a Fix symbol escaping in bloaty_treemap
All JS strings are now single-quoted, so double-quotes don't need
escaping. There are some symbols (in fullsymbols mode) that contain
single quotes, though - so escape those instead.

Change-Id: Ibdcca5634413c6a5e292f81503fbbf89f3d52b0d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/430040
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2021-07-20 00:16:10 +00:00
Mike Reed
ee8b8e1984 Supporess skp test for now
Not a critical test, but its data file is out of date.

Change-Id: I41a1a94b2235e5b853e1516af7129f1cc0c0c785
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/430217
Reviewed-by: Mike Reed <reed@google.com>
2021-07-20 00:12:58 +00:00
Mike Reed
08d206be46 Print out picture version even if its unsupported
Change-Id: I1dd61924f7b72cdae1cc0cf530e39b052ae19add
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/430216
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2021-07-20 00:11:39 +00:00
Chris Dalton
8aec124cf0 Make BoundingBoxShader inherit from GrGeometryProcessor directly
This is not a tessellation shader, and only inherited from
GrPathTessellationShader because it was used by the tessellation path
renderer. Remove its dependence on GrPathTessellationShader.

Bug: skia:10419
Change-Id: Ia97ef68488fae1c90674c5a006a62a3157bb707f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/430019
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2021-07-19 23:23:12 +00:00
Brian Osman
946a4cb8ac First pass at a no-SkSL CPU build
This just disables everything that depends on SkSL today:

- Color filters:
  - HighContrast
  - Lerp
  - Luma
  - Overdraw
- Skottie effects:
  - BlackAndWhite
  - BrightnessContrast
  - DisplacementMap
  - FractalNoise
  - Sphere
  - Threshold
  - GradientColorFilter (indirectly, this uses ColorFilters::Lerp)

Cq-Include-Trybots: luci.skia.skia.primary:Canary-Android,Canary-Chromium,Canary-Flutter,Canary-G3
Bug: skia:12197
Change-Id: I26269bd4423897142b8f2fdcc4ab1b274e767cba
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427376
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
2021-07-19 21:19:51 +00:00
Chris Dalton
59a00f062a Turn off caps.multisampleDisableSupport()
Disabling multisample while rendering to an MSAA target is a dwindling
feature that comes with a heavy performance cost on some devices, and
many devices don't support it at all. This CL just flips a bit so we
never disable multisample. After a few days or weeks of soak time, we
will come back and yank out all the code that supports disabling
multisample.

Bug: skia:12196
Change-Id: Iae54d25d0e28e24eda6295d7155e5c9fbb398081
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429299
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2021-07-19 20:51:59 +00:00
Chris Dalton
09bc8af282 Delete GrPathTessellationShader::MakeSimpleTriangleShader
We should have always used the default GP here. It makes for better
reuse, and shader that draws raw triangles isn't a "tessellation"
shader anyway.

Bug: skia:10419
Change-Id: Ia2ef2a83f5ed8917005e12b9f9a52c1d9f877575
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429956
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2021-07-19 20:10:59 +00:00
Brian Osman
4c6fe58ea5 Remove unused RP stage pointer
Change-Id: I73922717d4ebd8c759f7fe5c7c8e8da4567a0aa9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/430039
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Reed <reed@google.com>
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: Mike Reed <reed@google.com>
2021-07-19 19:48:01 +00:00
Mike Reed
4043111918 Purge 2020 picture versions
Pull a thread, and end up removing logs of old fontmgr code.

Change-Id: I73cebf9c011a99e9d12fd728e8677fcb0700407f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429338
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2021-07-19 19:35:49 +00:00
Ethan Nicholas
da7297820f Added multi-var variants for the DSL Declare function
Change-Id: I84fe0319a15065f5de85cd4bed20d648b88c2b56
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429897
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: John Stiles <johnstiles@google.com>
2021-07-19 19:20:16 +00:00
Ethan Nicholas
ed6e54f1b4 Improved DSL Array error checking
Change-Id: I4b1235f7363309bd2aa3e2f1b3e00c94b43976bb
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/430058
Reviewed-by: John Stiles <johnstiles@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2021-07-19 19:19:59 +00:00
Eric Boren
92c7cecad2 [infra] Roll back infra dep
https://skia-review.googlesource.com/c/skia/+/416576 updated this, which
updated Python to 3.9, which fails on the CommandBuffer tasks.

Change-Id: I916738237dfee08a584c09af08e9bf735ac255cb
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/430038
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2021-07-19 18:45:49 +00:00
Ethan Nicholas
2ab47c97e2 Added DSL LogicalXor function
Because C++ does not have the '^^' operator, we had previously just
skipped support for this GLSL operator. This implements it as a
function.

Change-Id: I310658d900de4609572aed4750d6fb27f88d0722
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/430036
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: John Stiles <johnstiles@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2021-07-19 18:25:30 +00:00
Chris Dalton
fe49b2c6f4 Run dmsaa on ANGLE es2 bots
Bug: chromium:1220246
Change-Id: I0e9db2e403455ccc5d75acc714aa8201db285afc
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429678
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2021-07-19 16:05:39 +00:00
Chris Dalton
50516f3db8 Add a robust "isinf" workaround for tessellation
When isinf is not supported, we simply add another instanced attrib that
tells the shader exactly what type of curve it's dealing with.

Bug: chromium:1220246
Change-Id: I3496de674ce8c7df205e3c40559ae89dc29488e1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429676
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2021-07-19 16:03:39 +00:00
Eric Boren
8f553a769b [infra] Fix RecreateSKPs after assets update
Change-Id: I13ae7034cda4291743f433406ee2e8267dd48d3e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/416576
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2021-07-19 14:13:09 +00:00
Brian Osman
3c1c4c0d25 Standardize strings and other cleanup in bloaty_treemap.py
Follow-up from reviews.skia.org/428959

Change-Id: I3a9baaf1744dcfcea372c5a0c73af31912888c0c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429818
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2021-07-19 14:01:30 +00:00
Mike Reed
95cc53bafd Hide filterquality enum entirely
Introduce private SkLegacyFQ to allow us to continue deserializing
old content with filter-qualities, but still remove the public enum.

Need to finish removing references in clients.

Change-Id: Iacfb602ec497260e53defc4b95e297ed1ef4e69c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429476
Auto-Submit: Mike Reed <reed@google.com>
Commit-Queue: Florin Malita <fmalita@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
2021-07-19 12:34:50 +00:00
recipe-roller
230a2514d6 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
0202156442
  0202156 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 56d8faf61a03 to 175b811c1eeb

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id3c9af7172825acd539e5bcda57ce7478a0b4932
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429736
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-19 05:52:29 +00:00
skia-autoroll
1748bddbc0 Roll Chromium from a9426b211cb3 to 699b730a7601 (553 revisions)
a9426b211c..699b730a76

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-skia-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia/skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
Tbr: ethannicholas@google.com
Change-Id: Ic431824bf1041d04596346345c5f1690252cc2f1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429717
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-07-19 05:18:38 +00:00
skia-autoroll
52d6bd4974 Roll ANGLE from 397fc145b8b3 to 4d9e1f230fa7 (17 revisions)
397fc145b8..4d9e1f230f

2021-07-19 cnorthrop@google.com More skips for GLSLTest_ES31.TypesUsedInDifferentBlockStorages
2021-07-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from ec932ff42c9b to ac347590d69b (492 revisions)
2021-07-17 timvp@google.com Call getNearestSamples() in Framebuffer::setAttachment()
2021-07-16 cnorthrop@google.com Skip GLSLTest_ES31.TypesUsedInDifferentBlockStorages AMD Linux
2021-07-16 ianelliott@google.com Two fixes to DevSetup.md
2021-07-16 geofflang@chromium.org Remove the explicit context extension.
2021-07-16 syoussefi@chromium.org Vulkan: SPIR-V Gen: Support bool in interface blocks
2021-07-16 jmadill@chromium.org Vulkan: Prefer the local vulkan loader over the system one.
2021-07-16 jmadill@chromium.org Capture/Replay tests: Enable dcheck_always_on.
2021-07-16 lunpujun@google.com Avoid recreating activity when rotating the display.
2021-07-16 jmadill@chromium.org Capture/Replay: Don't try to serialize compressed textures.
2021-07-16 jmadill@chromium.org Capture/Replay Tests: Swap before TearDown.
2021-07-16 gert.wollny@collabora.com Capture/Replay: Capture WaitSemaphore and SignalSemaphore
2021-07-16 gert.wollny@collabora.com Capture/Replay: redesign capturing of arrays passed by pointer
2021-07-16 gert.wollny@collabora.com tests: GL_NUM_BINARY_FORMATS is a ES 3.0 property
2021-07-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 8cd71c4b8d72 to ec932ff42c9b (494 revisions)
2021-07-16 gert.wollny@collabora.com Capture/Replay: Capture FenceNV parameters

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Tbr: ethannicholas@google.com
Test: Test: MultisampledRenderToTextureTest.FramebufferCompletenessSmallSampleCount
Change-Id: I9807c9bf425e212cb18520cf45ce965025435d0b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429716
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-07-19 05:09:59 +00:00
Mike Reed
1f261da41e Stop using filterquality
Change-Id: I0fd8ace529cde3b36df72dd4d80bba18c1388b20
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429497
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2021-07-18 15:48:36 +00:00
Mike Reed
f02aa80ba9 Remove dead code (and dead subclass)
note: our min picture-version dates from 2020
Change-Id: I5b9d2e8a13afd16fe5b3ae88f9747f0da4382d29
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/428196
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2021-07-18 12:18:16 +00:00
skia-autoroll
8837c919fb Roll SK Tool from 48c8dccc29e0 to fba7eb859cc7
https://skia.googlesource.com/buildbot.git/+log/48c8dccc29e0..fba7eb859cc7

2021-07-18 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update CIPD Packages

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/sk-tool-skia
Please CC rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: rmistry@google.com
Change-Id: Icfdc1b1ffdaec4b0162ebd2f3e53921f67f2a2eb
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429516
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-07-18 06:47:55 +00:00
Herb Derby
3d49efa8e1 draw vertices: rename textures -> texCoords
Bug=skia:11822

Change-Id: I97c74658eb46704ba6d3b1ea2aa53f76eb869241
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429416
Reviewed-by: Herb Derby <herb@google.com>
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2021-07-17 21:03:33 +00:00
Mike Reed
01e6273c46 rm flutter support for filterquality
Change-Id: Ibcae9d2378d136ce15e3284f679e71b42f1ba32d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429337
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2021-07-17 14:39:38 +00:00
Mike Reed
11a20bbbf4 rm getblendmode flag for flutter
Change-Id: Id578c5dbf7f0f4274d43b3ae8a7cfb50d3563cc3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429376
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2021-07-17 13:53:45 +00:00
Chris Dalton
7c79a871c0 Run dmsaa on ANGLE es3 bots
Bug: skia:11396
Change-Id: I4d8253e61e6458b21b4e851e0b77d220394ea65d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429040
Reviewed-by: John Stiles <johnstiles@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2021-07-17 04:18:32 +00:00
Mike Reed
c82ab0839f Stop using filterquality
Change-Id: I67d1a464618f1a54f4e3bd4e1409b1d91a90e66a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429336
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2021-07-17 03:11:32 +00:00
Mike Reed
2bdf6ed96f Stop using SkFilterQuality
Change-Id: Ief80d125eacb5922b95ab16ebc8d6b483469ada7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429097
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2021-07-17 01:55:42 +00:00
skia-autoroll
fb0440e5bc Roll SK Tool from 3bbeaa205257 to d2ac68f66d91
https://skia.googlesource.com/buildbot.git/+log/3bbeaa205257..d2ac68f66d91

2021-07-16 rmistry@google.com Add SkCQ for buildbot repo

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/sk-tool-skia
Please CC rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: rmistry@google.com
Change-Id: I1966a278963600ac7216c7e9a1598eb00798e300
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429143
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-07-17 00:19:22 +00:00
recipe-roller
fe5d07a8e4 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (depot_tools, recipe_engine) into this repository.

depot_tools:
92c396e45d
  92c396e (bryner@google.com)
      cpython3 3.8.10.chromium.20 to depot_tools bleeding edge.

recipe_engine:
3a8a334ce1
  3a8a334 (yiwzhang@google.com)
      engine: upgrade third-party library

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib006689370e25ea2ccb273762520456f95ed710b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429041
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-16 23:09:32 +00:00
Chris Dalton
528673a7ae Work around a Mac compiler bug with "!isinf()"
Bug: skia:12219
Change-Id: I877cece94305bcec0c36d94643f4ad17a811ae7a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429296
Reviewed-by: John Stiles <johnstiles@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2021-07-16 22:46:02 +00:00
John Stiles
9671d0aa31 Add checkbox to Viewer to force-enable Runtime Blends.
In a perfect world, this should always render the same, just perhaps a
bit more slowly.

Change-Id: I750ad43142d4d192be4db7396989d978025179a8
Bug: skia:12080
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429101
Commit-Queue: John Stiles <johnstiles@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2021-07-16 21:11:28 +00:00
recipe-roller
8c3adb8b1a Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (depot_tools) into this repository.

depot_tools:
a3d1aaf112
  a3d1aaf (sokcevic@google.com)
      Revert "[depot_tools] Add --fork-point when computing merge-base"

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia6095dc83dee3c1dbbde615cc1e6cf50e25b9152
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429039
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-16 19:44:02 +00:00
Chris Dalton
3b7ec0fa0f Remove unused variables
These presented as warnings while compiling on Applie silicone.

Change-Id: Icfcd2b0ad163a8bb429d81354b628ca00b0c1a8d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429137
Auto-Submit: Chris Dalton <csmartdalton@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Herb Derby <herb@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2021-07-16 19:40:02 +00:00
John Stiles
67b1b2a105 Fix fuzzer-discovered undefined behavior with NaN.
The fuzzer passed in a point with a Y coordinate of NaN; this eventually
caused an integer overflow while attempting to calculate
`SK_MaxS32FitsInFloat << 2`. We now detect the NaN and return false.

Change-Id: I79e51190006bce5e2c42935e1075261a3e16aa6d
Bug: oss-fuzz:36198
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429099
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
2021-07-16 19:38:42 +00:00
Jim Van Verth
3339e570a1 Metal: use ResourceProvider for MSAA creation.
Also fixes GPU sizes to use new attachment scheme.

Bug: skia:12186
Change-Id: I4259cd26ac6b41eeda3a6d8bb42e1f283ae9e4d3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429197
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2021-07-16 17:41:45 +00:00
recipe-roller
226a7cd7c1 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (depot_tools) into this repository.

depot_tools:
f6f3c7a46e
  f6f3c7a (johannkoenig@google.com)
      [docs] update links to developer guide

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I59d206123921e70a3612b6e596eadc25733b8d7a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429038
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-16 17:24:33 +00:00
Jim Van Verth
94fda947eb Reland "Fix directional shadows."
This is a reland of 6789b82401

Original change's description:
> Fix directional shadows.
>
> The xy offset calculation for drawShadow was not quite correct. Rather
> than normalizing the light vector and using the xy values of that as the
> base offset value, we should scale the light vector by 1/z.
>
> See https://github.com/flutter/engine/pull/27124#issuecomment-880182653
> for more detail.
>
> Bug: skia:10781
> Change-Id: Ib69a313cb96a532f8d89644e3d69f666a184e897
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/428880
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Commit-Queue: Jim Van Verth <jvanverth@google.com>

Bug: skia:10781
Change-Id: Ib58d374aa03d0144512e5ded6ccd572c74783607
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/428978
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2021-07-16 16:49:52 +00:00
Ben Wagner
126002c27d Update minimum Linux versions
With M93 Chromium is dropping support for older Linux distributions.
The new minimum requirements are Ubuntu 18.04+, Debian 10+,
openSUSE 15.2+, or Fedora Linux 32+. Update Skia's minimum requirements
to match.

Change-Id: I280a0790d4ee4d803bc15e2e29828be692ea934e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/428983
Commit-Queue: Ben Wagner <bungeman@google.com>
Commit-Queue: Heather Miller <hcm@google.com>
Reviewed-by: Heather Miller <hcm@google.com>
2021-07-16 16:20:26 +00:00
Jorge Betancourt
5514beaf3b [androidkit] bind SkImageFilters to java shared library
SkImageFilter::image
SkImageFilter::blend
SkImageFilter::dropShadow
Change-Id: Ie8cce8a06a2f50b2b3c905097740cc10b91a6c86
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/428577
Commit-Queue: Jorge Betancourt <jmbetancourt@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
2021-07-16 16:18:55 +00:00