Commit Graph

7072 Commits

Author SHA1 Message Date
scroggo@google.com
7d519305bb Make gm use SkFlags.
Make flag parser its own project. It is still in the tools folder,
but can now be used by other projects.

Some changes to behavior in order to work with SkFlags:
enable-missing-warning and disable-missing-warning have become
enableMissingWarning and noenableMissingWarning.

exclude-config is now excludeConfig

--config now can only be listed once, but all configs listed
after it will be included (same with excludeConfig and match).

In addition, writeJsonSummary has been changed to
writeJsonSummaryPath for consistency with other path flags.

Provide an option to SkFlags to provide a short name, and use
it for the flags which have short names.

--tileGridReplayScales now takes space separated arguments,
like other inputs.

BUG=https://code.google.com/p/skia/issues/detail?id=1094

Review URL: https://codereview.chromium.org/12632015

git-svn-id: http://skia.googlecode.com/svn/trunk@8235 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-19 17:28:10 +00:00
edisonn@google.com
66bedbb02d resubmit https://code.google.com/p/skia/source/detail?r=7883 (in the meantime we added capability to collect minidump and callstack if buildbot fails with heap coruption in windows. a few minor conflicts have been resolved)
Review URL: https://codereview.chromium.org/12840004

git-svn-id: http://skia.googlecode.com/svn/trunk@8233 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-19 17:19:05 +00:00
bsalomon@google.com
f315451f78 Revert changes to GM MSAA configs, hopefully fixes linux bot gm failures.
git-svn-id: http://skia.googlecode.com/svn/trunk@8232 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-19 16:43:40 +00:00
reed@google.com
0da48618a7 remove SkFontHost::CreateScalerContext
Review URL: https://codereview.chromium.org/12593013

git-svn-id: http://skia.googlecode.com/svn/trunk@8228 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-19 16:06:52 +00:00
bsalomon@google.com
a83d3d8865 fix angle gmmain build
git-svn-id: http://skia.googlecode.com/svn/trunk@8226 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-19 15:19:41 +00:00
sugoi@google.com
4ecd42e4bf Fix for displacement mapping
Fixed the skia displacement map effect to match the WebKit displacement map fix.
Review URL: https://codereview.chromium.org/12787007

git-svn-id: http://skia.googlecode.com/svn/trunk@8225 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-19 15:07:30 +00:00
reed@google.com
56a2e0de63 fix double->float warnings
git-svn-id: http://skia.googlecode.com/svn/trunk@8224 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-19 14:50:41 +00:00
reed@google.com
90808e87c2 Add SkTypeface* parameter to SkScalerContext (and its callers)
Use SkTypeface to create scalercontext instead of SkFontHost
Review URL: https://codereview.chromium.org/12706010

git-svn-id: http://skia.googlecode.com/svn/trunk@8223 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-19 14:44:54 +00:00
bsalomon@google.com
14687813ea Fix build break in gmmain.cpp
git-svn-id: http://skia.googlecode.com/svn/trunk@8222 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-19 14:35:41 +00:00
bsalomon@google.com
40deeadf6f Add config msaa4 to gm (not run by default) and make MSAA configs not run unless
sample count is <= the max.
Review URL: https://codereview.chromium.org/12554012

git-svn-id: http://skia.googlecode.com/svn/trunk@8221 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-19 14:28:36 +00:00
robertphillips@google.com
6a2ea6909b More performance rebaselines
git-svn-id: http://skia.googlecode.com/svn/trunk@8220 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-19 14:20:22 +00:00
commit-bot@chromium.org
e4657ed7e1 Add a macro for querying the byte order of SkPMColor.
R=reed@google.com

Author: bsalomon@google.com

Reviewed By: reed@google.com,epoger@google.com

Review URL: https://chromiumcodereview.appspot.com/12771010

git-svn-id: http://skia.googlecode.com/svn/trunk@8219 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-19 14:16:31 +00:00
robertphillips@google.com
14c3fc60b2 Adding rects-specific GM
https://codereview.chromium.org/12934003/



git-svn-id: http://skia.googlecode.com/svn/trunk@8218 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-19 14:11:15 +00:00
bsalomon@google.com
8a70eef71c Add MSAA configs to bench.
Review URL: https://codereview.chromium.org/12607013

git-svn-id: http://skia.googlecode.com/svn/trunk@8217 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-19 13:58:55 +00:00
reed@google.com
8c3f84d13f use SkStream::NewFromFile()
git-svn-id: http://skia.googlecode.com/svn/trunk@8216 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-19 13:34:55 +00:00
robertphillips@google.com
f735cb3ea3 Remove SkMMapStream.h from core.gypi
git-svn-id: http://skia.googlecode.com/svn/trunk@8214 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-19 12:29:06 +00:00
skia.committer@gmail.com
8eaddb0089 Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@8211 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-19 07:15:10 +00:00
mike@reedtribe.org
f381162e56 use SkStream::NewFromFile()
git-svn-id: http://skia.googlecode.com/svn/trunk@8210 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-19 02:18:33 +00:00
mike@reedtribe.org
54d5f83c33 update coding style
git-svn-id: http://skia.googlecode.com/svn/trunk@8209 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-19 02:12:50 +00:00
scroggo@google.com
bb281f7f96 Improvements/additions to SkImageCache/SkLazyPixelRef.
SkPurgeableImageCache:
New image cache that uses virtual memory to store the pixels. Combines
features of SkAshmemImageCache (which has been removed) with SkPurgeableMemoryBlock, which has android and Mac versions.

SkImageCache:
Modified the API. pinCache now returns a status out parameter which
states whether the pinned memory retained the old data. This allows
allocAndPinCache to only be used for allocations.
Add a new debug only interface to purge unpinned data.
Updates to documentation, clarifying behavior.
Changed CachedStatus to MemoryStatus

SkLruImageCache:
Implement the new function purgeAllUnpinnedCaches and change implementation
of pinCache for the new behavior.

SkLazyPixelRef:
Rewrite onLockPixels to account for the new behavior of pinCache.

BitmapFactoryTest:
Test the new SkPurgeableImageCache.
Write tests which directly test the SkImageCaches.
Create a larger bitmap, since some of the SkImageCaches are designed
to handle large bitmaps.

bench_ and render_pictures:
Consolidate lazy_decode_bitmap into one function.
Allow using a flag to specify using the purgeable image cache.
Clean up some #includes.

Review URL: https://codereview.chromium.org/12433020

git-svn-id: http://skia.googlecode.com/svn/trunk@8207 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-18 21:37:39 +00:00
reed@google.com
e1575aa216 reland 8200 w/ fix for android (use fullpath instead of path)
Review URL: https://codereview.chromium.org/12921003

git-svn-id: http://skia.googlecode.com/svn/trunk@8206 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-18 21:08:46 +00:00
reed@google.com
070235e746 revert 8204 -- what is happening???
git-svn-id: http://skia.googlecode.com/svn/trunk@8205 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-18 20:53:49 +00:00
reed@google.com
4f7e846cd8 reland 8200 w/ fix for android (need fullpath instead of path)
git-svn-id: http://skia.googlecode.com/svn/trunk@8204 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-18 20:49:28 +00:00
scroggo@google.com
a6c76db94c Do not use SkTDS32Array when building for 64 bit.
This class is used for pointers, which won't work on 64 bit.
Fixes SampleApp on Mac debug 64 bit.

BUG=https://code.google.com/p/skia/issues/detail?id=1169

Review URL: https://codereview.chromium.org/12919014

git-svn-id: http://skia.googlecode.com/svn/trunk@8203 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-18 19:55:57 +00:00
reed@google.com
1311f7e7f4 revert 8200 to figure out android break
git-svn-id: http://skia.googlecode.com/svn/trunk@8201 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-18 19:32:58 +00:00
reed@google.com
d5ea2aeb60 move SK_MMAP_SUPPORT into SkPreConfig, so we can know about its availability
throughout the code.

Add SkData::NewFromMMap() help factory.

Refactor (now gone) SkMMapStream into SkStream::NewFromFile() factory
Review URL: https://codereview.chromium.org/12919013

git-svn-id: http://skia.googlecode.com/svn/trunk@8200 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-18 19:08:46 +00:00
borenet@google.com
a74302d628 Use "svn cat" in tools/submit_try
(SkipBuildbotRuns)
Review URL: https://codereview.chromium.org/12726006

git-svn-id: http://skia.googlecode.com/svn/trunk@8197 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-18 18:18:26 +00:00
robertphillips@google.com
25ba67109b More Mac 10.8 performance rebaselines
git-svn-id: http://skia.googlecode.com/svn/trunk@8195 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-18 17:57:18 +00:00
robertphillips@google.com
0bd80fa01b Added toString to SkMaskFilter-derived classes
https://codereview.appspot.com/7889043/



git-svn-id: http://skia.googlecode.com/svn/trunk@8194 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-18 17:53:38 +00:00
rmistry@google.com
cd9caa8017 Whitespace change to trigger rebuilds
git-svn-id: http://skia.googlecode.com/svn/trunk@8191 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-18 15:40:44 +00:00
robertphillips@google.com
79dca3e597 Another Mac 10.8 performance rebaseline
git-svn-id: http://skia.googlecode.com/svn/trunk@8190 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-18 14:37:16 +00:00
robertphillips@google.com
795181ded3 Perfrormance rebaseline for Mac 10.8
git-svn-id: http://skia.googlecode.com/svn/trunk@8188 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-18 12:12:37 +00:00
skia.committer@gmail.com
c76bb238de Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@8186 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-18 07:01:03 +00:00
robertphillips@google.com
fbf66e88be Yet another performance trigger rebaseline
git-svn-id: http://skia.googlecode.com/svn/trunk@8185 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-17 22:34:56 +00:00
robertphillips@google.com
48d94b8050 More performance trigger rebaselines
git-svn-id: http://skia.googlecode.com/svn/trunk@8184 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-17 20:58:08 +00:00
robertphillips@google.com
ba66694744 Rebaseline some more performance triggers (Mac 10.8 & Ubuntu)
git-svn-id: http://skia.googlecode.com/svn/trunk@8183 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-17 18:50:05 +00:00
robertphillips@google.com
9105ad0f85 Add translate & scale optimizations
https://codereview.appspot.com/7571045/



git-svn-id: http://skia.googlecode.com/svn/trunk@8182 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-17 18:46:16 +00:00
robertphillips@google.com
91217d0b0c Making SkDrawCommand more robust
https://codereview.appspot.com/7486052/



git-svn-id: http://skia.googlecode.com/svn/trunk@8181 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-17 18:33:46 +00:00
robertphillips@google.com
d4be5dd36c Rebaselining Nexus7 performance triggers after r8171
git-svn-id: http://skia.googlecode.com/svn/trunk@8180 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-17 16:51:44 +00:00
robertphillips@google.com
8abc037da0 Rebaseline Ubuntu, Windows and Mac 10.8 performance triggers after r8171
git-svn-id: http://skia.googlecode.com/svn/trunk@8179 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-17 16:32:12 +00:00
robertphillips@google.com
09f6c5c310 Fix android build
https://codereview.chromium.org/12896002/



git-svn-id: http://skia.googlecode.com/svn/trunk@8178 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-17 15:40:59 +00:00
skia.committer@gmail.com
ac2c82c852 Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@8177 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-16 07:01:18 +00:00
scroggo@google.com
d9ef3a21d4 Create a platform-dependent object for accessing purgeable memory.
Siphoned off from https://codereview.chromium.org/12433020/

Create a Skia class which can provide purgeable memory in a platform-
dependent way. Include an implementation for Ashmem and Mac/iOS.

Review URL: https://codereview.chromium.org/12645006

git-svn-id: http://skia.googlecode.com/svn/trunk@8176 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-15 18:08:09 +00:00
robertphillips@google.com
35e1563380 Patch to fix NULL ptr dereference in 8171 on Linux
TBR=junov@google.com



git-svn-id: http://skia.googlecode.com/svn/trunk@8175 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-15 16:49:34 +00:00
bsalomon@google.com
604a56ad42 Run non-rendering benches in their own config.
Currently benches that set fIsRendering = false are run as part of the first config run. This is problematic for several reasons.

1) Which config they are run as depends on the --config options passed to bench. If I run bench --config GPU --config 8888 then they will be run in the GPU config and not the 8888 config.

2) Their presence makes bench take longer to run when testing rendering changes or comparing one rendering config to another (e.g. GPU v 8888). This is especially true on Android.

3) When comparing runs of a single config across multiple bench runs (typically  with code changes) it isn't obvious from the output which benchs to ignore because they say are listed under as being part of the config.

This CL adds NONRENDERING as a config (open to name suggestions). Non-rendering tests are run in and only in the NONRENDERING config.

Will this screw up our bench bots/scripts/graphs? If so I think we should change them since running non-rendering tests separately makes a lot more sense than the current madness.
Review URL: https://codereview.chromium.org/12475012

git-svn-id: http://skia.googlecode.com/svn/trunk@8174 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-15 15:42:15 +00:00
scroggo@google.com
5159153840 In gm, install drawFilter for pipe and tiledPipe.
Fixes bugs in drawing un-antialiased text in gm.

Review URL: https://codereview.chromium.org/12812016

git-svn-id: http://skia.googlecode.com/svn/trunk@8173 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-15 15:29:02 +00:00
commit-bot@chromium.org
4b32bd53c6 Fixing SkPicture command pattern optimizations to make them work correctly with bounding box hierarchies
BUG=https://code.google.com/p/chromium/issues/detail?id=180645
TEST=render_pictures -r <skp_dir> --validate --bbh <grid|rtree> --mode tile 256 256

Author: junov@chromium.org

Reviewed By: robertphillips@google.com

Review URL: https://chromiumcodereview.appspot.com/12817011

git-svn-id: http://skia.googlecode.com/svn/trunk@8171 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-15 15:06:03 +00:00
rmistry@google.com
8b5144f366 SKP files have been reverted to old version. Whitespace change to trigger rebuilds.
git-svn-id: http://skia.googlecode.com/svn/trunk@8170 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-15 13:37:39 +00:00
robertphillips@google.com
23f785d530 Update performance triggers for new skps (also remove all _multi_* triggers)
git-svn-id: http://skia.googlecode.com/svn/trunk@8169 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-15 12:43:53 +00:00
skia.committer@gmail.com
c49cabfe5c Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@8168 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-15 07:05:19 +00:00