Commit Graph

11 Commits

Author SHA1 Message Date
Bryce Thomas
1303a1a15c Fix CanvasKit generated documentation to work with emscripten 1.39.16.
In https://skia-review.googlesource.com/c/skia/+/291182 emscripten was updated
to 1.39.16.  This introduced a breaking API change to the CanvasKit
initialization callback, which becomes simply `then()` as opposed to
`ready().then()`.  In the course of this change, I missed a few `ready()` calls,
which has broken the examples in public-facing documentation.
E.g. https://skia.org/user/modules/canvaskit.  This CL fixes that.

Bug: NONE
Change-Id: I857b4653747cffc3870bf92d479dc88c3fd7d64a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/292097
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-05-27 12:23:32 +00:00
Kevin Lubick
8abc842945 [pathkit] fix perf
Docs-Preview: https://skia.org/?cl=195360
Bug: skia:
Change-Id: I4109810832b69a71960f6e619e32288ae8fa5023
Reviewed-on: https://skia-review.googlesource.com/c/195360
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2019-02-26 13:17:22 +00:00
Kevin Lubick
a6e3f6288c [canvaskit] use the live CDN version for the docs
Also update pathkit's page to use most recent version.

No-Try: true
Docs-Preview: https://skia.org/?cl=178920
Bug: skia:8584
Change-Id: I53b58b12c937b78ffd0a527b8ca5080bd2e3f156
Reviewed-on: https://skia-review.googlesource.com/c/178920
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-12-18 13:39:52 +00:00
Heather Miller
63fd39701a progress on canvaskit page
No-Try: true
Docs-Preview: https://skia.org/?cl=155920
Bug: skia:
Change-Id: I9badf67a68c234520796ee0da4940ffb32a56f9d
Reviewed-on: https://skia-review.googlesource.com/155920
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-09-20 20:36:52 +00:00
Mike Reed
7728e91188 change language for pathkit
No-Try: true
Docs-Preview: https://skia.org/?cl=153900
Bug: skia:
Change-Id: Ie5771211d6a706976c1ab7082e68677bdceef42d
Reviewed-on: https://skia-review.googlesource.com/153900
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-09-12 13:40:34 +00:00
Kevin Lubick
774be5aa96 [PathKit] Add cubicYFromX
Docs-Preview: https://skia.org/?cl=152385
Bug: skia:8216
Change-Id: I0020e8d2d4e6e7c7de5c71ddf923a618659cde2c
Reviewed-on: https://skia-review.googlesource.com/152385
Reviewed-by: Mike Reed <reed@google.com>
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
2018-09-07 18:01:40 +00:00
Kevin Lubick
f05ebf074a [PathKit] Fix document.write warning in docs.
Switch back to using unpkg.com since it's actually a CDN
not a GCS bucket just pretending (lower latency, better
compression, etc).

Also loads consistently since https://skia-review.googlesource.com/c/buildbot/+/152020
landed.

No-Try: true
Docs-Preview: https://skia.org/?cl=151826
Bug: skia:
Change-Id: I9a2a8d71ebc87e44a85bf7ec40d04a0279a97ff1
Reviewed-on: https://skia-review.googlesource.com/151826
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Commit-Queue: Joe Gregorio <jcgregorio@google.com>
Auto-Submit: Kevin Lubick <kjlubick@google.com>
2018-09-06 12:00:07 +00:00
Kevin Lubick
be5091c1fb [PathKit] Remove experimental- from package names
On the demo page, we use the skia-cdn bucket to hopefully
have better performance than unpkg.

Additionally, on the demo page, we default to using the
WASM version if supported by the browser.

Docs-Preview: https://skia.org/?cl=150904
Bug: skia:8216
Change-Id: I901016e95b8d66803053680691aac4d314821d18
Reviewed-on: https://skia-review.googlesource.com/150904
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
2018-08-31 15:11:04 +00:00
Kevin Lubick
c7d057103e [PathKit] Move from experimental to modules
Add in Code of Conduct and Contributing.md as well.

Docs-Preview: https://skia.org/?cl=150901
Bug: skia:8216
Change-Id: Ia881124f653617ad0b7b91f40ba21de2c13220a6
Reviewed-on: https://skia-review.googlesource.com/150901
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
2018-08-31 14:18:16 +00:00
Kevin Lubick
d993648fa4 [PathKit] Write more complete docs and clean up API to be consistent
Breaking Changes (should be minor, as it's mostly just things
for testing):
 - PathKit.ApplyPathOp should have returned a new SkPath, but didn't.
It now does and is named "MakeFromOp", which makes the convention of
"Have 'make' in name, needs delete" more consistent.
 - PathKit.FromCmds(arr) now only needs to take the JS Array and
will handle the TypedArrays under the hood. If clients want to deal
with TypedArrays themselves, they can use _FromCmds(ptr, len) directly.
 - PathKit.MakeLTRBRect is now just PathKit.LTRBRect. The thing
returned is a normal JS Object and doesn't need delete().

As per custom with v0 apps, we are updating the minor version
to v0.3.0 to account for breaking changes.


Docs-Preview: https://skia.org/?cl=147960
Bug: skia:8216
Change-Id: Ia3626e69f3e97698fc62a6aee876af005e29ffca
Reviewed-on: https://skia-review.googlesource.com/147960
Reviewed-by: Mike Reed <reed@google.com>
Reviewed-by: Heather Miller <hcm@google.com>
2018-08-24 16:30:00 +00:00
Kevin Lubick
5bce14d015 [PathKit] Add docs page
No-Try: true
Docs-Preview: https://skia.org/?cl=147620
Bug: skia:8216
Change-Id: Iec5d1be49504b579bdc0893658941d3d722f676c
Reviewed-on: https://skia-review.googlesource.com/147620
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-08-17 12:27:41 +00:00