Commit Graph

21 Commits

Author SHA1 Message Date
commit-bot@chromium.org
55f6b24eb8 Add unreviewed skimage expectations for Test-Win8-ShuttleA-GTX660-x86-Release-NVPR
NOTRY=True
BUG=
R=scroggo@google.com

Author: borenet@google.com

Review URL: https://codereview.chromium.org/110663006

git-svn-id: http://skia.googlecode.com/svn/trunk@12715 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 17:35:13 +00:00
scroggo@google.com
c285864fb7 Add new baselines for Win8 decoding tests.
Taken from server, and unreviewed.

Review URL: https://codereview.chromium.org/114813005

git-svn-id: http://skia.googlecode.com/svn/trunk@12700 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-16 23:09:20 +00:00
scroggo@google.com
5187c4313c More work to integrate skimage with rebaseline tools.
tools/skimage_main.cpp:
Add the ability to write the results to checksum based filenames,
much like GM uses. This will allow using the skpdiff server to
rebaseline images.
Write the keys in the JSON file as <original image>_<pref config>.png,
so it matches gm_json.IMAGE_FILENAME_PATTERN. Also replace '_' with
'-' in the original file name, to avoid confusing the pattern matcher.
The '_' to '-' replacement also happens on the output filename.
Read the keys in a similar manner.
In make_outname, no longer remove a suffix. This fixes a bug where
subset decoding writes multiple subsets to the same file.

tools/rebaseline.py:
Since the filenames written to json files now match
gm_json.IMAGE_FILENAME_PATTERN, enable the option to match based
on configs/tests when rebaselining skimage.

test json files:
Update to match the new format of output.

gm/gm_expectations:
Add a constructor that takes a BitmapAndDigest as input.

tools/tests/skimage_self_test.py:
Test that reading the expectations file just created by skimage with
the same file actually compares to the original file (rather than just
succeeding because expectations were missing).

Change the expectations files to match the new format.

Will require a buildbot change to use the new flag: https://codereview.chromium.org/27389002/

BUG=1466
R=epoger@google.com

Review URL: https://codereview.chromium.org/26297004

git-svn-id: http://skia.googlecode.com/svn/trunk@11902 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-22 00:42:46 +00:00
scroggo@google.com
b4227d20b9 Remove the old skimage expectations.
As of https://code.google.com/p/skia/source/detail?r=11712 ,
the bots are now reading the expectations from a new place,
so these are no longer needed.

Unreviewed.

BUG=skia:1466

Review URL: https://codereview.chromium.org/26909004

git-svn-id: http://skia.googlecode.com/svn/trunk@11727 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-11 15:12:46 +00:00
scroggo@google.com
429c962179 Format-only changes to skimage expectations files.
When running rebaseline.py, the format of the file changes from
what is currently checked in, but the actual data remains the
same. Update the format so future changes will be easier to see
visually (not mixed in with format changes).

Unreviewed.

Review URL: https://codereview.chromium.org/26888010

git-svn-id: http://skia.googlecode.com/svn/trunk@11726 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-11 14:51:31 +00:00
scroggo@google.com
19d15cebd0 New expectations files for skimage.
Copies them from expectations/skimage/buildername.json to
expectations/skimage/buildername/expected-results.json.

Required for https://codereview.chromium.org/26734006/ and
ultimately BUG=skia:1466

A follow up change will delete the old expectations files once
https://codereview.chromium.org/26734006/ has landed.

(SkipBuildbotRuns) - Since the new expectations files aren't even
read yet (they won't be until https://codereview.chromium.org/26734006/
is checked in), this need not be tested by the buildbots (yet).

Unreviewed.

BUG=skia:1466

Review URL: https://codereview.chromium.org/26865002

git-svn-id: http://skia.googlecode.com/svn/trunk@11698 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-10 16:04:16 +00:00
scroggo@google.com
680963ec83 Ignore failure for images known to not work.
BUG=skia:1282

Review URL: https://codereview.chromium.org/26315002

git-svn-id: http://skia.googlecode.com/svn/trunk@11638 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-07 18:29:38 +00:00
scroggo@google.com
e7f6f43260 Fix unparsable expectations files.
Should fix build.

Unreviewed.

git-svn-id: http://skia.googlecode.com/svn/trunk@11631 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-07 16:43:16 +00:00
scroggo@google.com
4d844d7e77 Check in some expectations for Xoom skimage.
Since they have not been able to run at all, they have not created
any expectations, so these are copied from

Test-Android-Nexus10-MaliT604-Arm7-Debug.json
and
Test-Android-Nexus10-MaliT604-Arm7-Release.json

Add "reviewed-by-human": false to track that they were copied from
another device's expectations.

git-svn-id: http://skia.googlecode.com/svn/trunk@11073 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-04 13:30:38 +00:00
scroggo@google.com
b3e6fe8559 Add expectations for GalaxyNexus release.
git-svn-id: http://skia.googlecode.com/svn/trunk@11072 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-04 13:10:52 +00:00
scroggo@google.com
3e8466a152 Reland 'Update expectations for skimage.'
Now that expectations have moved to use the builder_name rather than
the gm_subdir (see https://code.google.com/p/skia/source/detail?r=10923),
check in a new set which uses the proper name.

Committed: https://code.google.com/p/skia/source/detail?r=10969

Reverted in https://code.google.com/p/skia/source/detail?r=10970
due to failures on builders without an attached device. Can
resubmit once https://codereview.chromium.org/23495007/ is
submitted.

Review URL: https://codereview.chromium.org/23600004

git-svn-id: http://skia.googlecode.com/svn/trunk@10993 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-29 10:24:44 +00:00
scroggo@google.com
7b905ae523 Revert "Update expectations for skimage."
This reverts commit c154d36bd319baa1472189ecb212805e08f3c00b.

Reverting due to build failure in prerender.

git-svn-id: http://skia.googlecode.com/svn/trunk@10970 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-28 10:50:37 +00:00
scroggo@google.com
46ab3d052f Update expectations for skimage.
Now that expectations have moved to use the builder_name rather than
the gm_subdir (see https://code.google.com/p/skia/source/detail?r=10923),
check in a new set which uses the proper name.

Review URL: https://codereview.chromium.org/23600004

git-svn-id: http://skia.googlecode.com/svn/trunk@10969 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-28 10:26:01 +00:00
jvanverth@google.com
f7f19ac419 Ignore gif_test.gif, take two. Add missing comma.
Unreviewed.


git-svn-id: http://skia.googlecode.com/svn/trunk@10613 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-07 16:52:05 +00:00
jvanverth@google.com
fbd370572a Try to ignore gif_test.gif in skimage test
git-svn-id: http://skia.googlecode.com/svn/trunk@10610 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-07 16:07:43 +00:00
scroggo@google.com
84d0bbe125 Remove invalid expectation.
Fixes build.

git-svn-id: http://skia.googlecode.com/svn/trunk@10582 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-06 19:35:48 +00:00
scroggo@google.com
a7df69865c Add expectations files covering new image files.
New image files are in Google Storage, so add expectations for them.
The ICO file is expected to fail, although there is a patch to fix
that out for review (https://chromiumcodereview.appspot.com/18655007/)

Unreviewed.

Since we are currently ignoring failures in skimage, this should at
most produce a warning, but I expect it to remove the current warning
state.

The razr expectation is copied from nexus-7, as razr is currently
not working.

Review URL: https://codereview.chromium.org/18271012

git-svn-id: http://skia.googlecode.com/svn/trunk@9915 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-08 23:17:29 +00:00
scroggo@google.com
fa13a632a0 Expect razr to fail on some decoding tests.
Review URL: https://codereview.chromium.org/18272005

git-svn-id: http://skia.googlecode.com/svn/trunk@9830 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-01 12:38:50 +00:00
scroggo@google.com
0c5618d5a1 Add expectations files for skimage.
These were downloaded from Google Storage after being generated
by the build bots.

Review URL: https://codereview.chromium.org/18117006

git-svn-id: http://skia.googlecode.com/svn/trunk@9798 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-27 20:50:06 +00:00
scroggo@google.com
bc91e8b7d7 Fix run_decoding_tests on xoom.
Builder Test-Android-Xoom-Tegra2-Arm7-Debug fails run_decoding_tests
due to a couple of images. Add a way in skimage to ignore failures
if an image is expected to fail. Add an expectations file for xoom
that includes ignore-failure for the two files which are failing.

I have created https://code.google.com/p/skia/issues/detail?id=1382
to track the fact that these images fail to decode, despite the bot
showing green.

R=borenet@google.com

Review URL: https://codereview.chromium.org/18023008

git-svn-id: http://skia.googlecode.com/svn/trunk@9797 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-27 20:21:01 +00:00
scroggo@google.com
6dd735a86c Add folders for skimage expectations, plus one set
Expectations json files will be stored here for running skimage.

Once we move to git, this directory will be at a higher level, but
keeping here for now for simplicity.

(SkipBuildbotRuns)

BUG=https://code.google.com/p/skia/issues/detail?id=1241
R=borenet@google.com

Review URL: https://codereview.chromium.org/17737002

git-svn-id: http://skia.googlecode.com/svn/trunk@9758 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-25 21:04:02 +00:00