Commit Graph

44801 Commits

Author SHA1 Message Date
Chris Dalton
858cf233ef Call setNeedsStencil() when clearing stencil
Bug: chromium:1008312
Change-Id: I6e1d160515c6689ac6d62c40e712df287d47f955
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248723
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2019-10-14 23:51:51 +00:00
Robert Phillips
7d7aaf46ae Slim down GrFragmentProcessor::TextureSampler and GrPrimitiveProcessor::TextureSampler
I'm gearing up to add a GrBackendFormat to GrPrimitiveProcessor::TextureSampler so this CL just reduces the API surface area I'll need to alter.

The GrFragmentProcess::TextureSampler changes just keep it aligned with its "twin".

Change-Id: Ia9ece03ca76b4f6c8ebdaf0e0ba0061ecde6c5f4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248558
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2019-10-14 19:48:19 +00:00
Joe Gregorio
4cb778e367 Fix usage of depot_tools in containers.
depot_tools w/vpython now seems to require the depot_tools dir
to be on PATH, and also python and curl need to be installed.

  * Creates a new base image that has all the build tools we need for
building Skia: skia-build-tools.
  * Moves skia-release to use that new base image.
  * Moves both the skia-release and wasm builds to use fetch and gclient sync.
  * Changes gcr.io/skia-public/emsdk-base:prod to depend on skia-build-tools.


Bug: skia:993053
Change-Id: Ib6218d8c18dd59d43de84dcf063f204cfc8556d0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248556
Commit-Queue: Joe Gregorio <jcgregorio@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2019-10-14 19:38:40 +00:00
Jim Van Verth
c910602376 Reland "Minimal iOS app: Perform present subsequent to flush"
This is a reland of 4e385e21a4

Original change's description:
> Minimal iOS app: Perform present subsequent to flush
> 
> Currently the backbuffer present is not on the same MTLCommandQueue
> as the flush from Skia, which probably means that it's happening
> concurrently. This can overwhelm the GPU. This CL submits the present
> to the same queue as the flush.
> 
> Change-Id: Ibaf805553931c9dc46368b362a2391425ae3e60e
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248557
> Reviewed-by: Hal Canary <halcanary@skia.org>
> Commit-Queue: Jim Van Verth <jvanverth@google.com>

Change-Id: I118047630b8936838d5da8ef4307ad5c5e8d2ade
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248562
Reviewed-by: Hal Canary <halcanary@skia.org>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2019-10-14 18:32:37 +00:00
Ben Wagner
63acfe3dd6 [infra] Retry failed pushes in Android flavor
It seems like we see quite a few "force quarantined" bots when pushing
resources to the device fails. Rewrite copy_directory_contents_to_device
to use the _adb method, which automatically retries.

Change-Id: Iae36f8e42e85a58fdddc8c9dc80e693a371fab8b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248560
Commit-Queue: Eric Boren <borenet@google.com>
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2019-10-14 18:14:07 +00:00
Mike Klein
33c36e05c3 insist SkPngEncoder's input is initialized
I'd rather catch uninitialized input here than
somewhere deep down in zlib or libpng.

Bug: chromium:1013368
Cq-Include-Trybots: skia.primary:Test-Debian9-Clang-GCE-CPU-AVX2-x86_64-Debug-All-MSAN
Change-Id: I37f5a66a8fc12c7e0ce6d3100de94021bb5343ef
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248551
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-10-14 18:13:37 +00:00
Stephen White
729c78d617 Dawn backend: update to Skia API changes.
Update to GrProgramInfo change.
Implement GrCaps::bytesPerPixel().

Change-Id: Ic695fe85f2cd1389918724d17368df60f88ee2db
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/247796
Commit-Queue: Stephen White <senorblanco@chromium.org>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2019-10-14 17:28:04 +00:00
skia-autoroll
f6d5064f86 Roll skia/third_party/skcms e9158fd9e492..8c5dee1e7fe2 (4 commits)
https://skia.googlesource.com/skcms.git/+log/e9158fd9e492..8c5dee1e7fe2

git log e9158fd9e492..8c5dee1e7fe2 --date=short --no-merges --format='%ad %ae %s'
2019-10-14 mtklein@google.com flip R,G,a for HLG
2019-10-14 mtklein@google.com retract the HLG/PQ APIs a bit
2019-10-14 mtklein@google.com support PQ/HLG in skcms_Transform()
2019-10-14 mtklein@google.com skcms_TransferFunction_invert() for PQ/HLG

Created with:
  gclient setdep -r skia/third_party/skcms@8c5dee1e7fe2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skcms-skia-autoroll
Please CC csmartdalton@google.com,mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel

Bug: None
Change-Id: Iec91cf4c7be050d38ca82eb5187a322a59217095
TBR=csmartdalton@google.com,mtklein@google.com
TBR=csmartdalton@google.com,mtklein@google.com
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248554
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-10-14 17:21:33 +00:00
Jim Van Verth
41b41f9d31 Revert "Minimal iOS app: Perform present subsequent to flush"
This reverts commit 4e385e21a4.

Reason for revert: Causing issues with iOS Skottie app.

Original change's description:
> Minimal iOS app: Perform present subsequent to flush
> 
> Currently the backbuffer present is not on the same MTLCommandQueue
> as the flush from Skia, which probably means that it's happening
> concurrently. This can overwhelm the GPU. This CL submits the present
> to the same queue as the flush.
> 
> Change-Id: Ibaf805553931c9dc46368b362a2391425ae3e60e
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248557
> Reviewed-by: Hal Canary <halcanary@skia.org>
> Commit-Queue: Jim Van Verth <jvanverth@google.com>

TBR=jvanverth@google.com,halcanary@google.com,halcanary@skia.org

Change-Id: I56a9f1f12ebceeb750948e459ff9f90e06b7b2e4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248561
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2019-10-14 16:39:00 +00:00
Chris Dalton
2c8891b6ac Allow fullscreen clears when generating blurs
If we don't care about any of the existing content in the framebuffer
(which we don't in the case of blurs) then fullscreen clears are
always a big win on tilers.

Bug: chromium:1008192
Change-Id: I538ce295ab91c56e88b6cb44773a35644980a162
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/247798
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2019-10-14 16:29:48 +00:00
Jim Van Verth
5f72b494fe Remove fake SDK #defines for Metal backend.
Our base supported SDK is the one available in Xcode 10, so we don't
need these any more.

Bug: skia:9408
Change-Id: I71f4b6ee77a1f9b0a3b2dfa902c1bf23f2d66696
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/247365
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2019-10-14 15:33:28 +00:00
Jim Van Verth
4e385e21a4 Minimal iOS app: Perform present subsequent to flush
Currently the backbuffer present is not on the same MTLCommandQueue
as the flush from Skia, which probably means that it's happening
concurrently. This can overwhelm the GPU. This CL submits the present
to the same queue as the flush.

Change-Id: Ibaf805553931c9dc46368b362a2391425ae3e60e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248557
Reviewed-by: Hal Canary <halcanary@skia.org>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2019-10-14 15:30:49 +00:00
skia-autoroll
775981dffc Roll skia/third_party/skcms ed9daeb11a98..e9158fd9e492 (1 commits)
https://skia.googlesource.com/skcms.git/+log/ed9daeb11a98..e9158fd9e492

git log ed9daeb11a98..e9158fd9e492 --date=short --no-merges --format='%ad %ae %s'
2019-10-14 mtklein@google.com precompute log2(e)

Created with:
  gclient setdep -r skia/third_party/skcms@e9158fd9e492

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skcms-skia-autoroll
Please CC csmartdalton@google.com,mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel

Bug: None
Change-Id: I7831d5377bd0ce2a939554659df67620003d0f3f
TBR=csmartdalton@google.com,mtklein@google.com
TBR=csmartdalton@google.com,mtklein@google.com
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248548
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-10-14 15:28:24 +00:00
skia-autoroll
5f8588ca0a Roll skia/third_party/skcms a52db47aa53f..ed9daeb11a98 (1 commits)
https://skia.googlesource.com/skcms.git/+log/a52db47aa53f..ed9daeb11a98

git log a52db47aa53f..ed9daeb11a98 --date=short --no-merges --format='%ad %ae %s'
2019-10-14 mtklein@google.com serial HLG support

Created with:
  gclient setdep -r skia/third_party/skcms@ed9daeb11a98

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skcms-skia-autoroll
Please CC csmartdalton@google.com,mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel

Bug: None
Change-Id: Iaf769e76e5074dc268a7a9a447add41f963757ed
TBR=csmartdalton@google.com,mtklein@google.com
TBR=csmartdalton@google.com,mtklein@google.com
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248542
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-10-14 14:27:33 +00:00
Robert Phillips
d5c1f342b3 Reduce usage of GrProgramDesc::KeyHeader
Ideally the GrProgramDesc would be a simple program key. We currently can't remove usage of the KeyHeader for "hasPointSize" but this, at least, removes the other uses.

Bug: skia:9455
Change-Id: Ie9e15997ee79c6ffe62b5cd2c96885ca06204383
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/247597
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2019-10-14 14:18:23 +00:00
Greg Daniel
a4828a13c2 Remove GrPixelConfigIsAlphaOnly call and transition calls to it.
Bug: skia:6718
Change-Id: I4d9c31bc0ca42a80e652de29462531587efef031
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248257
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2019-10-14 13:49:14 +00:00
Robert Phillips
4face8300e Plumb GrPrimitiveType down to GrProgramDesc::Build
This defers the decision about whether pointSize is emitted until down in GrProgramDesc::Build. Although a bit wonky in GL's case, this anticipates the world where each cluster of meshes always has the same GrPrimitiveType.

Ultimately, we would like the GrPrimitiveType to be part of the GrProgramInfo and known far earlier.

Change-Id: I65566b2d77eab6a69f7af5aa60a069299b58db65
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/246018
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2019-10-14 12:48:44 +00:00
skia-autoroll
c34e434df0 Roll third_party/externals/angle2 67486ec24551..fede5cb664d9 (12 commits)
67486ec245..fede5cb664

git log 67486ec24551..fede5cb664d9 --date=short --no-merges --format='%ad %ae %s'
2019-10-13 jmadill@chromium.org Vulkan: Remove resource destruction layer suppressions.
2019-10-12 jiajie.hu@intel.com Add sampler array index validation for ESSL 3.00 onwards
2019-10-12 jmadill@chromium.org Roll chromium_revision 43eb5958f7..9325340209 (704334:704874)
2019-10-12 jmadill@chromium.org Add a roll_deps script based on WebRTC.
2019-10-12 jdarpinian@chromium.org Extend ANGLE_request_extension with DisableExtension
2019-10-11 lehoangq@gmail.com Metal implementation pt 1: autogen resources
2019-10-11 cnorthrop@google.com Vulkan: Support binding texture levels as a rendertarget
2019-10-11 tobine@google.com Vulkan:Add support to stage D or S textures
2019-10-11 ianelliott@google.com Vulkan: Update GLES 3.0 expectations files
2019-10-11 b.schade@samsung.com Vulkan: finishToSerial only if the buffer is in use
2019-10-11 cnorthrop@google.com Vulkan: Handle 2Darray base/max level change
2019-10-11 jonahr@google.com GL: Missing check for texture format sample counts

Created with:
  gclient setdep -r third_party/externals/angle2@fede5cb664d9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC csmartdalton@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Bug: None
TBR=csmartdalton@google.com
Change-Id: I6a583009ecdef9d9f1b4c03c3ce32b037e8615e6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248496
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-10-14 05:57:11 +00:00
skia-autoroll
f42f04b3cb Roll ../src 92809357d851..e034419fbc6a (981 commits)
92809357d8..e034419fbc


Created with:
  gclient setdep -r ../src@e034419fbc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-skia-autoroll
Please CC csmartdalton@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
Bug: None
TBR=csmartdalton@google.com
Change-Id: Ia88d704a828c2897afa4f8d714223b8ccc18f993
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248498
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-10-14 04:41:41 +00:00
skia-autoroll
19a311d0ae Roll third_party/externals/swiftshader ae022faf53b9..1c462ebc904c (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/ae022faf53b9..1c462ebc904c

git log ae022faf53b9..1c462ebc904c --date=short --no-merges --format='%ad %ae %s'
2019-10-11 sugoi@google.com Stencil buffer texture sampling

Created with:
  gclient setdep -r third_party/externals/swiftshader@1c462ebc904c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-skia-autoroll
Please CC csmartdalton@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
Bug: None
TBR=csmartdalton@google.com
Change-Id: Ib808f8c4db5c091ffbe44fbb6c32388b20fb0da5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248497
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-10-14 04:38:51 +00:00
skia-recreate-skps
a7e1b45d9c Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: Ibd8d8778c7aa90affeceabcf426c094738f96c62
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248459
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-10-13 23:14:38 +00:00
Herbert Derby
3838fe3c82 Use SkDrawableGlyphBuffer for bitmap rendering
Change-Id: I0e7c995123c55b63b2d4c9ddee033d7098cdc358
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/247416
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2019-10-11 22:09:16 +00:00
Robert Sesek
caf025e8f5 Switch SkSemaphore to use dispatch_semaphore_t on Mac.
The dispatch_semaphore_t is a higher-level, more-efficient semaphore
primitive if the cross-process capabilities of semaphore_t are not
needed.

Bug: chromium:1012386
Change-Id: I7c39fa6b8c015bdf7b4b2275da8165165253c2d1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248259
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2019-10-11 22:08:46 +00:00
recipe-roller
a4b5228e16 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/2cbae8a8b9f61ad88e51f3b9fa30f97824db614b git cl: retry-failed avoid not useful retries. (tandrii@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I38725260ce6ae70b7c99bb947d1f6466b5a9e5d2
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248378
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-10-11 22:02:04 +00:00
recipe-roller
8c6c8b0c42 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/5c869191c19f2a253ccb70d13c71d640244d0b62 Reland "depot_tools: Use vpython to execute fetch." (ehmaldonado@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iee4682832b2af20a1a7765bc8c0e5de97ff4055f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/247917
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-10-11 20:42:05 +00:00
Hal Canary
aae3cc4378 docs/fiddle: add "incomplete" fiddle.
Change-Id: I66246d6c421cf91b459207d91e4899c4c030e45e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248159
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2019-10-11 18:22:34 +00:00
Hal Canary
3d49d08660 SkPDF/tests: add regression test for crbug/494913
Bug: chromium:494913
Bug: skia:9508
Change-Id: I8793fa32b8c4d38b58ec1814b35187ddfc246916
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248256
Auto-Submit: Hal Canary <halcanary@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2019-10-11 18:17:54 +00:00
recipe-roller
bc88b7b9e2 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/1ed55ef713b18458deaf7553399db7ff38cddeb2 Improve the check failure output for StatusSuccess. (gbeaty@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I468883e1c5ef81634fca3def8685d2623ec3746d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248276
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-10-11 18:05:24 +00:00
Greg Daniel
a00bcad94b Remove GrPixelConfig version of CompressedDataSize.
Bug: skia:6718
Change-Id: I0f9c7d89e732c59bdbe76ab45d42934029106efb
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/247684
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
2019-10-11 17:51:05 +00:00
Hal Canary
2f0ca4dbf0 Docs: Update docs to point at named fiddles
for x in docs/examples/* ; do
      if grep -q '// Disabled' $x; then
        continue
      fi
      HASH=$(sed -n 's#^// HASH=\(.*\)$#\1#p' $x)
      NAME=$(sed -n 's#^REG_FIDDLE(\([^,]*\),.*$#\1#p' $x)
      FILES="$(grep -l $HASH site/user/api/*.md)"
      if [ "$FILES" ] ; then
        echo $HASH $NAME $FILES;
        sed -i "s/$HASH/@$NAME/g" $FILES
      fi
    done

https://skia.org/user/api/SkAutoCanvasRestore_Reference?cl=248158
https://skia.org/user/api/SkBitmap_Reference?cl=248158
https://skia.org/user/api/SkBlendMode_Reference?cl=248158
https://skia.org/user/api/SkCanvas_Reference?cl=248158
https://skia.org/user/api/SkColor4f_Reference?cl=248158
https://skia.org/user/api/SkColor_Reference?cl=248158
https://skia.org/user/api/SkFont_Reference?cl=248158
https://skia.org/user/api/SkIPoint_Reference?cl=248158
https://skia.org/user/api/SkIRect_Reference?cl=248158
https://skia.org/user/api/SkImageInfo_Reference?cl=248158
https://skia.org/user/api/SkImage_Reference?cl=248158
https://skia.org/user/api/SkMatrix_Reference?cl=248158
https://skia.org/user/api/SkPaint_Reference?cl=248158
https://skia.org/user/api/SkPath_Reference?cl=248158
https://skia.org/user/api/SkPicture_Reference?cl=248158
https://skia.org/user/api/SkPixmap_Reference?cl=248158
https://skia.org/user/api/SkPoint_Reference?cl=248158
https://skia.org/user/api/SkRRect_Reference?cl=248158
https://skia.org/user/api/SkRect_Reference?cl=248158
https://skia.org/user/api/SkRegion_Reference?cl=248158
https://skia.org/user/api/SkSurface_Reference?cl=248158
https://skia.org/user/api/SkTextBlobBuilder_Reference?cl=248158
https://skia.org/user/api/SkTextBlob_Reference?cl=248158

No-Try: true
Change-Id: I29ff57f3c1dd9f27f67be5511c942e7108908642
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248158
Auto-Submit: Hal Canary <halcanary@google.com>
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
2019-10-11 16:57:05 +00:00
recipe-roller
27c4369651 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/e3703bb8b8af7978ecf1bdfbfe8c3e6c910be8bc Release newest bb tool. (tandrii@chromium.org)
  https://crrev.com/12265a8f7de02667caa3961b95760c0f37d743dd Revert "depot_tools: Add httplib2 to .vpython" (ehmaldonado@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I199f964c53d5e779821947744d22bdf35579add8
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248117
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-10-11 15:49:58 +00:00
Herbert Derby
0be4c2cb86 Introduce SkGlyphDrawableBuffer
Used for efficient glyph id to glyph lookup.

This is part of a larger change:
https://skia-review.googlesource.com/c/skia/+/238196

Change-Id: Ifce43879685bf0d760a7e12dceb32f7a650be687
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/247340
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2019-10-11 15:40:24 +00:00
recipe-roller
9b33e36023 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/e1410883a38ac3a3491ed470883ec405193442f6 depot_tools: Add httplib2 to .vpython (ehmaldonado@chromium.org)
  https://crrev.com/8e57b4bc55c05081b8f6331da37f41b558920dfb python3 improvements (maruel@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ief443917cc6e85a863a995d57a452f0042e56601
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248116
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-10-11 14:51:50 +00:00
Eric Boren
10367f81f7 [infra] Fix presubmit by pinning tools/build
Change-Id: I9f44062d43c8e6810247050521cdb4f450827d23
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/247961
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2019-10-11 14:18:28 +00:00
Greg Daniel
6bc4fd1370 Fix GL RGB format bytes per pixel.
Change-Id: I57c64d1d36a9080c09f2cac83c0c8ebc308210e2
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/247960
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2019-10-11 14:15:01 +00:00
skia-autoroll
106e865164 Roll third_party/externals/angle2 5d9c4ee328bc..67486ec24551 (18 commits)
5d9c4ee328..67486ec245

git log 5d9c4ee328bc..67486ec24551 --date=short --no-merges --format='%ad %ae %s'
2019-10-11 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 82f84c4b8f19..feb154921397 (3 commits)
2019-10-11 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src 4b97a1108114..1ff0c181bb37 (1 commits)
2019-10-11 jmadill@chromium.org D3D11: Fix warning that showed up in VS2019.
2019-10-11 sergeyu@google.com [Fuchsia] Exclude libvk_swiftshader.so on Fuchsia
2019-10-11 timvp@google.com Vulkan: Prevent Creating ES 3.0 Context if Min. Caps. Not Met
2019-10-11 jie.a.chen@intel.com Fix the missing global memory barriers
2019-10-11 m.maiya@samsung.com Vulkan: Enable GL_OES_EGL_image_external_essl3
2019-10-10 jmadill@chromium.org Use relative paths/hooks in DEPS.
2019-10-10 sugoi@google.com Vulkan: Base max renderbuffer size on max framebuffer size
2019-10-10 jmadill@chromium.org Checkout GLES 1.1 conformance from DEPS.
2019-10-10 jmadill@chromium.org Fix debug layers being disabled everywhere.
2019-10-10 sugoi@google.com Correct presubmit error for missing Bug ID
2019-10-10 geofflang@chromium.org Update some implementation limits to match modern drivers.
2019-10-10 lehoangq@gmail.com Metal backend skeleton implementation.
2019-10-10 ianelliott@google.com Generate GLES 3.2 entry points
2019-10-10 lehoangq@gmail.com Added PVRTC compression extension needed for Metal on iOS.
2019-10-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 3c7ff8d4f0a1..82f84c4b8f19 (10 commits)
2019-10-10 kbr@chromium.org Conditionalize DeviceCGL implementation.

Created with:
  gclient setdep -r third_party/externals/angle2@67486ec24551

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC kjlubick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Bug: None
TBR=kjlubick@google.com
Change-Id: I10e09441980855ae6e5ee688bf6a82b4dc4aeeda
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/247955
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-10-11 12:53:01 +00:00
Eric Boren
df640e6d14 Revert "Roll recipe dependencies (trivial)."
This reverts commit 6c2b2bb024.

Reason for revert: breaks presubmit

Original change's description:
> Roll recipe dependencies (trivial).
> 
> This is an automated CL created by the recipe roller. This CL rolls recipe
> changes from upstream projects (e.g. depot_tools) into downstream projects
> (e.g. tools/build).
> 
> 
> More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
> depot_tools:
>   https://crrev.com/e1410883a38ac3a3491ed470883ec405193442f6 depot_tools: Add httplib2 to .vpython (ehmaldonado@chromium.org)
> 
> 
> TBR=borenet@google.com
> 
> Recipe-Tryjob-Bypass-Reason: Autoroller
> Bugdroid-Send-Email: False
> Change-Id: Ie3096ecfdaeb0db9e4e68550dcf77298225cd0f9
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/247797
> Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

TBR=borenet@google.com,recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I46fd0ea3d098aa101034b97c223993fe5514e345
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/247958
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2019-10-11 12:23:38 +00:00
recipe-roller
6c2b2bb024 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/e1410883a38ac3a3491ed470883ec405193442f6 depot_tools: Add httplib2 to .vpython (ehmaldonado@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie3096ecfdaeb0db9e4e68550dcf77298225cd0f9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/247797
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-10-11 00:41:52 +00:00
recipe-roller
9f76596646 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/d8b04ca8f7a3205aa49c804de9b6942437c87faf git-cl: add --fixed / -x option to upload (dbeam@chromium.org)
recipe_engine:
  https://crrev.com/a1609e19fa4bc5914cd681e2819539cf922113bd buildbucket: support swarming.parent_run_id when triggering builds. (tandrii@google.com)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Icaf60c1c10d72f4cf9cc8583e1bf2acd166852a9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/247687
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-10-10 22:01:32 +00:00
recipe-roller
5e53115f4c Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/6a1d77869d77b61189247ce8b47ac9d86684a6c2 gsutil: Bump asn1crypto version to 1.0.1 (ehmaldonado@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Icdf46a6af20a0c73964888cba3af7ef8a40f6840
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/247738
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-10-10 21:33:32 +00:00
Greg Daniel
7fd7a8aef0 Remove uses of GrPixelConfig version of GrBytesPerPixel.
Bug: skia:6718
Change-Id: I8421f38644567973f0b8de29b745ca9a471583bf
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/247598
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2019-10-10 20:39:05 +00:00
Robert Phillips
66ae304f50 Plumb GrTextureProxies down into emitSampler/addSampler
This is still pretty far away from this goal but, the goal here is to be able to create a program w/o requiring instantiated proxies.

Bug: skia:9455
Change-Id: I9526a3a737438c5331fef4a621be4786ef43c080
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/247397
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2019-10-10 19:32:05 +00:00
Kevin Lubick
6e5b07e25b [canvaskit] Enable tests for getGlyphPosition
Change-Id: Ibdd5987689305d383699153cdabdb6cbfd528a3e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/247599
Reviewed-by: Julia Lavrova <jlavrova@google.com>
2019-10-10 18:48:49 +00:00
Robert Phillips
2d8a95ee71 Add "meshCount" to GrProgramInfo
This improves the encapsulation of the GrProgramInfo class.

Bug: skia:9455
Change-Id: Ic241ba4a2c2edea3e774522065371e5ed8cc2da3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/247438
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2019-10-10 17:18:15 +00:00
Mike Klein
b484e7ce24 hand off frames to encoder as they come
Instead of rendering all .mp4 frames then encoding, we can kick off
rendering and have the encoder consume frames in order as they become
available.

This uses std::promise / std::future pairs to make the handoff: frame
producers fulfill thieir promise by moving their image into set_value(),
and the encoder (main thread) consumes them by moving those images out
of the paired std::future().  It may not be obvious, but the line

    sk_sp<SkImage> img = frame.get_future().get();

does move the image into `img`... gMP4Frames does not hold a ref once
.get_future().get() has returned.  (Though depending on when you look,
the surface still might.)

This lets us get going on encoding as soon as the first frame is ready,
and hypothetically means encoding should finish shortly after the last
frame draws.  But, different frames cost different time to draw, and we
can't control the order they'll return.  We _do_ have control over the
order they're started, and we're doing that exactly wrong using a LIFO
thread pool.  I've added .mp4 encoding starvation stats to show this...
when I run in LIFO order it looks typically something like

    starved min 0ms, med 0ms, avg 4.12333ms, max 2115ms, sum 2474ms
    frame time min 12ms, med 292ms, avg 307.208ms, max 711ms, sum 184325ms
    106.68user 57.27system 0:04.55elapsed 3601%CPU (0avgtext+0avgdata 3159748maxresident)k
    0inputs+1528outputs (0major+772790minor)pagefaults 0swaps

Mirroring the batch order with (i = frame_count - 1 - i) results in less
starvation, less memory usage, better scaling, and a quicker wall time.

    starved min 0ms, med 0ms, avg 0.896667ms, max 382ms, sum 538ms
    frame time min 13ms, med 374ms, avg 344.365ms, max 918ms, sum 206619ms
    111.64user 52.56system 0:03.62elapsed 4529%CPU (0avgtext+0avgdata 2660912maxresident)k
    0inputs+1528outputs (0major+649031minor)pagefaults 0swaps

Change-Id: Ic60e8eac856af238ef32e3383d86f6c24e5c7851
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/247674
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-10-10 16:34:31 +00:00
Robert Phillips
835cbdaf70 Pass GrProgramInfo further down Vulkan call chain
This just resolves some lingering TODOs from:

https://skia-review.googlesource.com/c/skia/+/244118 (Add GrProgramInfo to centralize management of program information)

Bug: skia:9455
Change-Id: I58e8a4e039ba8369b381725be196dacf3bcd07c5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/247436
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2019-10-10 15:45:31 +00:00
Jim Van Verth
ce3cf804f1 Draw perspective text as paths.
Perspective glyphs can vary in screen size so it's unclear which SDF
level is best, and even if we choose one for an entire subrun it's
possible that a given glyph will have artifacts if it's too big.
Instead we fall back to paths unless specifically requested to
support perspective SDF.

Bug: skia:9515
Change-Id: I75ac1d60f2eaa0e63de201b5db36fe0485fff463
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/247398
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Herb Derby <herb@google.com>
2019-10-10 15:35:51 +00:00
Robert Phillips
7de1333df7 Add computation of requestedFeatures to GrProgramInfo and use it
This is a deferred TODO/code review request. In general, this improves the encapsulation of program information w/in GrProgramInfo. Additionally, it is desirable to stop using the Desc/Key to access this information.

Bug: skia:9455
Change-Id: I854ff3225a49657d3a523e88e4bfa549128ee486
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/247336
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2019-10-10 15:20:22 +00:00
Kevin Lubick
957bf97414 [debugger] Use alternate buffer
Bug: skia:9524
Change-Id: I8268d1652f55516e009e3cf68b3322f37aa08933
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/247636
Reviewed-by: Nathaniel Nifong <nifong@google.com>
2019-10-10 15:19:42 +00:00
Nigel Tao
477f221d98 Update Wuffs version to 0.2.0-rc.1
Bug: skia:8235
Change-Id: Ia53348d620e1b9b6651ce5035dc4def02da67df6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/247156
Commit-Queue: Leon Scroggins <scroggo@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>
2019-10-10 15:12:21 +00:00