commit-bot@chromium.org
c69b0d0ee5
gm self-test: stop checking stdout and stderr
...
BUG=skia:1568
NOTRY=True
R=bsalomon@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/156023002
git-svn-id: http://skia.googlecode.com/svn/trunk@13324 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-05 18:44:31 +00:00
commit-bot@chromium.org
dd10e0ec4c
make GM self-test run gm/rebaseline_server unittests
...
R=borenet@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/143983017
git-svn-id: http://skia.googlecode.com/svn/trunk@13170 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-24 18:28:35 +00:00
commit-bot@chromium.org
3e62ebf93b
make ignored-tests.txt specify full test name, not partial name
...
BUG=skia:2022
R=bsalomon@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/136883006
git-svn-id: http://skia.googlecode.com/svn/trunk@13060 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-14 02:54:11 +00:00
commit-bot@chromium.org
8519548693
GM: run mode comparisons for all raster configs.
...
GM works like this today:
- Test all enabled configs directly
- Render into 8888
- Test all enabled modes against that 8888.
This change makes it do this:
- Test all enabled configs directly
- for each config, if it's raster, test all enabled modes against its output.
Upshot is, we now check that picture draws identically to raster for 565 too, not just 8888. optimizations-565 is correctly failing.
BUG=skia:1994
R=epoger@google.com , reed@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/129203002
git-svn-id: http://skia.googlecode.com/svn/trunk@13050 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-13 18:27:59 +00:00
commit-bot@chromium.org
711ebb9dfa
fix gm self-test
...
BUG=skia:1971
NOTREECHECKS=True
NOTRY=True
R=caryclark@google.com
TBR=caryclark
Author: epoger@google.com
Review URL: https://codereview.chromium.org/128793002
git-svn-id: http://skia.googlecode.com/svn/trunk@12964 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-08 17:59:22 +00:00
commit-bot@chromium.org
758b7a4c89
rebaseline gm self-tests after https://code.google.com/p/skia/source/detail?r=12850
...
The GM self-test's fragility is already noted in https://code.google.com/p/skia/issues/detail?id=1068 ('make gm self-test more robust')
NOTRY=True
NOTREECHECKS=True
R=mtklein@google.com
TBR=mtklein
Author: epoger@google.com
Review URL: https://codereview.chromium.org/112203006
git-svn-id: http://skia.googlecode.com/svn/trunk@12885 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-03 16:37:16 +00:00
epoger@google.com
00434ec9e8
GM: remove deprecated --ignoreTests flag
...
BUG=skia:1730
R=borenet@google.com
Review URL: https://codereview.chromium.org/27983004
git-svn-id: http://skia.googlecode.com/svn/trunk@11887 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-21 17:25:26 +00:00
epoger@google.com
f711f320a3
GM: add --ignoreFailuresFile as an alternative to --ignoreTests
...
(moved from old review at https://codereview.chromium.org/27752002/ )
This will allow the user to specify the tests to ignore failure on as a file,
rather than listing them out in the command line (and thus busting the
line length limit on Android).
BUG=skia:1730
R=scroggo@google.com
Review URL: https://codereview.chromium.org/29203002
git-svn-id: http://skia.googlecode.com/svn/trunk@11855 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-18 14:55:47 +00:00
edisonn@google.com
9eef56bd3e
Update Housekeeper-PerCommit after adding a new type of gm result.
...
R=epoger@google.com
Review URL: https://codereview.chromium.org/27191002
git-svn-id: http://skia.googlecode.com/svn/trunk@11753 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-14 14:31:14 +00:00
epoger@google.com
1ddfbc201a
gm: if test has no expectations, record its result as no-expectations regardless of ignoreFailure
...
After https://code.google.com/p/skia/source/detail?r=11640 ('Ignore any
pdf-poppler GM failures'), there are a bunch of pdf-poppler tests showing up
as failure-ignored at http://c128.i.corp.google.com/production-gm-diffs/latest/view.html
Make them go away.
R=scroggo@google.com
Review URL: https://codereview.chromium.org/26650005
git-svn-id: http://skia.googlecode.com/svn/trunk@11703 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-10 17:24:20 +00:00
epoger@google.com
3a882dda07
GM: Allow ignored-tests.txt to list configs as well as tests (and combinations too)
...
BUG=skia:1657
This will allow us to ignore poppler failures until bug 1657 is resolved
(but this CL doesn't actually make that change to ignored-tests.txt yet)
R=scroggo@google.com
Review URL: https://codereview.chromium.org/26294004
git-svn-id: http://skia.googlecode.com/svn/trunk@11639 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-07 18:55:09 +00:00
epoger@google.com
5e49738c99
revert temporary r11517
...
Review URL: https://codereview.chromium.org/25215002
git-svn-id: http://skia.googlecode.com/svn/trunk@11518 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-30 07:01:55 +00:00
epoger@google.com
19fcd8e2ef
gm: temporarily re-enable multiple rendermodes, to make sure they haven't regressed
...
Review URL: https://codereview.chromium.org/25213002
git-svn-id: http://skia.googlecode.com/svn/trunk@11517 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-30 06:29:19 +00:00
epoger@google.com
defc487aa9
gm: add --ignoreTests flag
...
BUG=skia:1600
R=scroggo@google.com
Review URL: https://codereview.chromium.org/23526065
git-svn-id: http://skia.googlecode.com/svn/trunk@11374 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-19 06:18:27 +00:00
epoger@google.com
33aa55a077
revert temporary r11371
...
BUG=skia:1641
Review URL: https://codereview.chromium.org/24256003
git-svn-id: http://skia.googlecode.com/svn/trunk@11373 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-19 06:09:32 +00:00
epoger@google.com
1a7e09e2dd
gm: temporarily re-enable multiple rendermodes, to make sure they haven't regressed
...
BUG=skia:1641
Review URL: https://codereview.chromium.org/24153020
git-svn-id: http://skia.googlecode.com/svn/trunk@11371 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-19 05:25:17 +00:00
epoger@google.com
3ad5dd009f
Speed up GM ~50% by NOT running most renderModes by default
...
BUG=skia:1566
R=borenet@google.com , bsalomon@google.com
Review URL: https://codereview.chromium.org/23889030
git-svn-id: http://skia.googlecode.com/svn/trunk@11265 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-09-13 19:56:14 +00:00
epoger@google.com
5852c8b06d
gm: add self-test to confirm that ignore-failure field is respected
...
BUG=skia:1578
R=scroggo@google.com
Review URL: https://codereview.chromium.org/23799004
git-svn-id: http://skia.googlecode.com/svn/trunk@11047 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-30 20:19:25 +00:00
vandebo@chromium.org
8fc3766c58
Update expectations for Mac PDF
...
R=epoger@google.com , vandebo@chromium.org
Review URL: https://codereview.chromium.org/22865029
git-svn-id: http://skia.googlecode.com/svn/trunk@10863 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-21 18:04:09 +00:00
vandebo@chromium.org
0dcbece326
Support multiple PDF rendering backends in the GM
...
R=epoger@google.com , vandebo@chromium.org
Review URL: https://codereview.chromium.org/21669004
git-svn-id: http://skia.googlecode.com/svn/trunk@10841 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-20 23:08:40 +00:00
epoger@google.com
e33e137623
GM: stop recording all *_pdf.png results as "INVALID" on non-Mac platforms
...
BUG=https://code.google.com/p/skia/issues/detail?id=1352
R=edisonn@google.com
Review URL: https://codereview.chromium.org/17366003
git-svn-id: http://skia.googlecode.com/svn/trunk@9912 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-07-08 19:13:33 +00:00
epoger@google.com
5f99545de6
GM: add --missingExpectationsPath option, similar to --mismatchPath
...
This will allow us to make the buildbots record all images EXCEPT those which
match expectations to Google Storage.
R=borenet@google.com
Review URL: https://codereview.chromium.org/17552012
git-svn-id: http://skia.googlecode.com/svn/trunk@9725 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-21 18:16:47 +00:00
epoger@google.com
6f7f14d061
Reland r9682, using new SkString::appendU64()
...
Review URL: https://codereview.chromium.org/17157005
git-svn-id: http://skia.googlecode.com/svn/trunk@9687 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-19 18:28:31 +00:00
epoger@google.com
628de5f1f4
Reverting r9682, which broke on some compilers
...
git-svn-id: http://skia.googlecode.com/svn/trunk@9684 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-19 15:58:00 +00:00
epoger@google.com
6324ac5d81
GM: add --writeChecksumBasedFilenames option
...
as needed for Step 2 of https://goto.google.com/ChecksumTransitionDetail :
make GenerateGMs upload actual images to Google Storage instead of skia-autogen
R=scroggo@google.com
Review URL: https://codereview.chromium.org/17365002
git-svn-id: http://skia.googlecode.com/svn/trunk@9682 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-06-19 15:50:09 +00:00
epoger@google.com
d4993ff360
GM: create GmResultDigest that encapsulates digest type ("bitmap-64bitMD5") and value (12345)
...
R=scroggo@google.com
Review URL: https://codereview.chromium.org/15883004
git-svn-id: http://skia.googlecode.com/svn/trunk@9271 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-24 14:33:28 +00:00
epoger@google.com
a55e48d6ef
Improve tool that analyzes gm JSON summary
...
BUG=https://code.google.com/p/skia/issues/detail?id=1300
R=borenet@google.com
Review URL: https://codereview.chromium.org/15298010
git-svn-id: http://skia.googlecode.com/svn/trunk@9217 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-21 16:06:40 +00:00
epoger@google.com
37d747d383
GM self-tests: add testing for non --hierarchy case
...
R=scroggo@google.com
Review URL: https://codereview.chromium.org/15397007
git-svn-id: http://skia.googlecode.com/svn/trunk@9214 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-21 15:41:35 +00:00
epoger@google.com
26515baa90
Add gm/confirm_no_failures_in_json.py
...
The CompareGMs step will use this (instead of running skdiff over the image
files) to decide whether to go red or green.
R=rmistry@google.com
Review URL: https://codereview.chromium.org/15100003
git-svn-id: http://skia.googlecode.com/svn/trunk@9127 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-14 18:58:12 +00:00
epoger@google.com
ce057fec92
GM: include filename extension (.png) of each output file in JSON summary
...
Doing this so that, once we *do* start writing PDF checksums into the JSON
summary, we'll be able to distinguish those from the PNG checksums.
Otherwise, we could have naming collisions.
R=scroggo@google.com
Review URL: https://codereview.chromium.org/14890017
git-svn-id: http://skia.googlecode.com/svn/trunk@9119 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-14 15:17:46 +00:00
epoger@google.com
ee2c3b9fb3
GM self-test: add --writePath and --mismatchPath , but in a way that works cross-platform
...
R=scroggo@google.com
Review URL: https://codereview.chromium.org/15085007
git-svn-id: http://skia.googlecode.com/svn/trunk@9077 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-09 18:09:06 +00:00
epoger@google.com
fed9db6930
GM self-test: add option to exercise --writePath and --mismatchPath, but not on bots
...
(individual developers can set WRITE_IMAGE_FILES=1 for local testing)
R=rmistry@google.com
Review URL: https://codereview.chromium.org/14863009
git-svn-id: http://skia.googlecode.com/svn/trunk@9056 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-08 14:10:28 +00:00
epoger@google.com
366a770159
GM: now that we use MD5 instead of CityHash, the JSON should say so
...
(this should have been part of https://code.google.com/p/skia/source/detail?r=8992 )
R=bungeman@google.com
Review URL: https://codereview.chromium.org/14758003
git-svn-id: http://skia.googlecode.com/svn/trunk@9038 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-07 15:51:54 +00:00
epoger@google.com
b4ca46d748
SkBitmapHasher: use 64-bit-truncated MD5 instead of 64-bit CityHash
...
BUG=https://code.google.com/p/skia/issues/detail?id=1257
(if we change our mind within the next few days, we can toggle the
BITMAPHASHER_USES_TRUNCATED_MD5 #ifdef ; at some point, we'll remove that
option so we can delete our CityHash implementation entirely)
R=bungeman@google.com
Review URL: https://codereview.chromium.org/14054012
git-svn-id: http://skia.googlecode.com/svn/trunk@8992 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-05-03 17:35:39 +00:00
epoger@google.com
0cc99cf793
GM self-tests: always run all tests (don't stop at first failure)
...
and make rebaseline.sh rebaseline all tests in one go.
(RunBuilders:Skia_PerCommit_House_Keeping)
Review URL: https://codereview.chromium.org/13979017
git-svn-id: http://skia.googlecode.com/svn/trunk@8881 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-26 17:45:06 +00:00
epoger@google.com
76c913db20
GM: specify that currently used checksums are CityHashes of SkBitmaps
...
(distinct from other hash algorithms we may switch to, or hashes of
files such as PDFs that cannot be read into an SkBitmap)
Review URL: https://codereview.chromium.org/14284018
git-svn-id: http://skia.googlecode.com/svn/trunk@8877 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-26 15:06:44 +00:00
bsalomon@google.com
dd8e353bef
Add option to specify defaults configs to --config flag in gm. This makes it easier to run gm defaults configs with a delta. Also make ~ exclude a config.
...
Review URL: https://codereview.chromium.org/13842014
git-svn-id: http://skia.googlecode.com/svn/trunk@8842 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-24 18:07:11 +00:00
epoger@google.com
318a059a0c
GM: add self-test that sets --readPath to a nonexistent directory path
...
Review URL: https://codereview.chromium.org/13844011
git-svn-id: http://skia.googlecode.com/svn/trunk@8664 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-12 19:05:57 +00:00
epoger@google.com
5079d2c2a0
GM: allow caller to specify which result types trigger an error
...
Review URL: https://codereview.chromium.org/14187007
git-svn-id: http://skia.googlecode.com/svn/trunk@8652 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-12 14:11:21 +00:00
epoger@google.com
bcbf5aa77d
GM: print list of GMs run, even in non-verbose mode (rolls back part of r8600)
...
Review URL: https://codereview.chromium.org/14052003
git-svn-id: http://skia.googlecode.com/svn/trunk@8638 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-12 02:11:54 +00:00
epoger@google.com
b0f8b430de
GM: remove enableMissingWarning in favor of verbose flag, and trim output in nonverbose mode
...
Review URL: https://codereview.chromium.org/14080003
git-svn-id: http://skia.googlecode.com/svn/trunk@8600 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-10 18:46:25 +00:00
epoger@google.com
51dbabee67
gm: hide list of tests with ignored errors, by default
...
Review URL: https://codereview.chromium.org/13811031
git-svn-id: http://skia.googlecode.com/svn/trunk@8591 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-10 15:24:53 +00:00
epoger@google.com
c8263e7041
gm: record IntentionallySkipped tests
...
Review URL: https://codereview.chromium.org/13663003
git-svn-id: http://skia.googlecode.com/svn/trunk@8586 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-10 12:17:34 +00:00
epoger@google.com
caac3db48f
re-land r8535, now that src.chromium.org is back up
...
Review URL: https://codereview.chromium.org/13662002
git-svn-id: http://skia.googlecode.com/svn/trunk@8538 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-04 19:23:11 +00:00
epoger@google.com
67caaf8792
Revert r8535
...
git-svn-id: http://skia.googlecode.com/svn/trunk@8536 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-04 18:21:48 +00:00
epoger@google.com
da8db9837e
gm: report ExpectationsMismatch and RenderModeMismatch results separately
...
Review URL: https://codereview.chromium.org/13650002
git-svn-id: http://skia.googlecode.com/svn/trunk@8535 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-04 18:11:31 +00:00
epoger@google.com
310478e72c
re-land r8514 without breaking 32-bit Mac compilers
...
Review URL: https://codereview.chromium.org/13427004
git-svn-id: http://skia.googlecode.com/svn/trunk@8518 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-03 18:00:39 +00:00
epoger@google.com
2212c2e35c
roll out r8514
...
Review URL: https://codereview.chromium.org/13503003
git-svn-id: http://skia.googlecode.com/svn/trunk@8515 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-03 17:12:42 +00:00
epoger@google.com
f60494ba0b
gm: display summary of all results by ErrorType
...
as discussed in https://codereview.chromium.org/12825005/#msg14
Review URL: https://codereview.chromium.org/12851022
git-svn-id: http://skia.googlecode.com/svn/trunk@8514 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-03 17:02:53 +00:00
epoger@google.com
0b62b3dd1c
gm refactor: extract run_multiple_configs() and run_multiple_modes()
...
Review URL: https://codereview.chromium.org/12536007
git-svn-id: http://skia.googlecode.com/svn/trunk@8269 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-20 17:59:28 +00:00