Commit Graph

439 Commits

Author SHA1 Message Date
Mike Klein
6857df77b0 remove EmbededResouces bot
The skia_embed_resoucres flag in GN is gone.

(Both misspellings sic, seriously.)

Change-Id: Ic4424fcea264010ff1cce390b4fd260897c15677
Reviewed-on: https://skia-review.googlesource.com/130147
Reviewed-by: Mike Klein <mtklein@chromium.org>
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2018-05-25 18:55:42 +00:00
Ben Wagner
e7e6e22912 Retry ADB commands on all devices.
Change-Id: Ieb289043bd871ec45c70339787ae45f09d3ac1dc
Reviewed-on: https://skia-review.googlesource.com/130128
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-05-25 15:24:22 +00:00
Ben Wagner
ef839a96ff Use EGL and GLES headers from Khronos.
Bug: skia:7671
Change-Id: Idae96b08f02768f180c7223bdcddb4dead3a5a1b
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/123588
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-05-24 19:45:49 +00:00
Eric Boren
90f050387a [recipes] Rename some modules and files
- Move doxygen and binary size out of core and into their own modules.
- Rename core -> checkout since that's all it does, shorten method names.
- Rename flavors:
  - Everything is GN, so remove GN/gn_ everywhere.
  - Merge gn_flavor into default.
  - Shorten file / module names.

Bug: skia:6473
Change-Id: I8ac9ff9c9a267f366206b9991adfa5eb37126ca7
Reviewed-on: https://skia-review.googlesource.com/129176
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2018-05-24 14:06:55 +00:00
Robert Phillips
b4303caa98 Add a Win10/QuadroP400 SKPBench bot
This will be the baseline (aka non-DDL) bot with which we can compare the DDL times

Change-Id: I9a949447845d31560136d591a0c1a17e7be57ac9
Reviewed-on: https://skia-review.googlesource.com/129506
Reviewed-by: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-05-23 13:19:21 +00:00
Ben Wagner
d26e446927 Rename SwiftShader bots from CPU to GPU.
Bug: skia:7671
Change-Id: I1d6b2a07ca93acbe53c1e93d70335f5284cd494e
NoTry: true
Reviewed-on: https://skia-review.googlesource.com/129500
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-05-22 16:33:05 +00:00
Kevin Lubick
0e42586036 Make ASAN setup of Android bots more fault tolerant
Bug: skia:7975
Change-Id: I3f123337913870a921d1c09714873eaf2949e88f
Reviewed-on: https://skia-review.googlesource.com/129364
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2018-05-21 20:14:08 +00:00
Eric Boren
dd8b1fc41b [recipes] Remove a bunch of unnecessary expectations
Bug: skia:6473
Change-Id: Ic2eee8074476c449cc9bed4701105609e91ea12b
Reviewed-on: https://skia-review.googlesource.com/128929
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2018-05-18 14:26:44 +00:00
Eric Boren
72f6668eb7 [recipes] Move a lot of logic out of vars module
In general, vars should only contain variables which are the same for
all tasks.  Variables specific to compilation belong in the build
module (or compile recipe), and those specific to running tests belong
in the flavor module, or the individual recipe which uses them.

Bug: skia:6473
Change-Id: Ifd55a57118c5801e6f4934a6b5de9d1567415b9a
Reviewed-on: https://skia-review.googlesource.com/128545
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2018-05-18 11:58:14 +00:00
Kevin Lubick
7673f3ba9e Specify the ADB keys to use for ADB
In the golo, specifically, the adb keys used by swarming
are different than those used in the docker instance, unless
configured otherwise.

This means swarming can think a device is ready (authorized)
but the adb we called was not (authorized)

BUG: 843284
Change-Id: I697d5075258a176e7fc7a4b51a9e2c926e1b8fd0
Reviewed-on: https://skia-review.googlesource.com/128930
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-05-17 19:28:43 +00:00
Chris Dalton
2b937f54c2 Add MoltenVK_Vulkan bots
Adds a prebuilt MoltenVK framework asset from:

KhronosGroup/MoltenVK.git:0279543e0bb561f8d0166d4030481136bc914fec

And creates bots that use it.

Bug: skia:
Change-Id: I081b2745c41a25de9ecd94a5363f4fb13b120215
Reviewed-on: https://skia-review.googlesource.com/128646
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2018-05-17 17:35:23 +00:00
Eric Boren
2fbde26018 [recipes] Normalize SwiftShader build dir
Bug: skia:6473
Change-Id: If145e2c29ddafdafaf9b8ed3fecbd6a6de31ac0a
Reviewed-on: https://skia-review.googlesource.com/128481
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-05-16 14:37:44 +00:00
Ravi Mistry
fedc8476cf Use Chromium ToT instead of lkcr
https://chromium.googlesource.com/chromium/src/+/lkcr has not been
updated in months now.
CT uses Chromium ToT and has rarely run into problems because of that.

Bug: skia:7917
Change-Id: I007b8f29b2320ffbc45ab5c5a75b081fbb8d7afa
Reviewed-on: https://skia-review.googlesource.com/128319
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2018-05-16 14:36:54 +00:00
Eric Boren
f3a21d0540 [recipes] Move 'gclient runhooks' from flutter build to core
Bug: skia:6473
Change-Id: I89b384668a6a45eaae9995ad8f7b404a1b7f9824
Reviewed-on: https://skia-review.googlesource.com/128318
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-05-16 12:56:54 +00:00
Eric Boren
0f69010549 [recipes] BUILDTYPE and SKIA_OUT are no longer used
Bug: skia:6473
Change-Id: I67b0dbf6dba26233df1d8e44f3e2f69ca0cc9d3e
Reviewed-on: https://skia-review.googlesource.com/128320
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Stephan Altmueller <stephana@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2018-05-15 19:36:23 +00:00
Ravi Mistry
5ab841f18b Add chromium first to .gclient
Bug: skia:7917
Change-Id: Ie76c73c5b8ea24ca0ac54e79ad7597fdac19d860
Reviewed-on: https://skia-review.googlesource.com/128011
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2018-05-15 19:28:43 +00:00
Mike Klein
77bc821b03 asan_device_setup has moved
Change-Id: I9d9d34f1b663a06605eddeacd945517c3e880f4f
Reviewed-on: https://skia-review.googlesource.com/128016
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2018-05-14 19:44:40 +00:00
Eric Boren
9030b94c60 [recipes] Separate build and test flavors
Bug: skia:6473
Change-Id: If1d6e1f64ec53624e7b540abd9d8a61cc82c4e0a
Reviewed-on: https://skia-review.googlesource.com/125947
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-05-14 17:27:49 +00:00
Eric Boren
b702316d9a [recipes] Remove core.setup()
Each recipe now includes its own setup steps.

Bug: skia:6473
Change-Id: I97eab2cd63f5004c07408e844cbbed735aac355f
Reviewed-on: https://skia-review.googlesource.com/125660
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2018-05-04 18:23:13 +00:00
Eric Boren
44a68b3b3b [infra] Remove PDFium bot and associated recipe code
Bug: skia:7890
Change-Id: I8322b145800dc41ac59322e89804ff9356d8e767
Reviewed-on: https://skia-review.googlesource.com/125864
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-05-04 14:59:32 +00:00
Eric Boren
2f62de01d3 [recipes] Mostly remove bot_update patch_ref hack
We need to do some refactoring to remove the repository hack for
cross-repo tryjobs.

Bug: skia:6473
Change-Id: Ie96fba75f6f1752575a4c7cc5b0208a37f0bd73d
Reviewed-on: https://skia-review.googlesource.com/125724
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-05-03 14:37:31 +00:00
Eric Boren
5cb5c74efd Reland "[recipes] Use named caches for git and workdirs"
This reverts commit 01d3eb64e7.

Bug: skia:
Change-Id: Ic05b89009eb59a231488bef382dd232a50d2b00f
Reviewed-on: https://skia-review.googlesource.com/124260
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-04-27 18:18:48 +00:00
Ben Wagner
01d3eb64e7 Revert "[recipes] Use named caches for git and workdirs"
This reverts commit e8615f969e.

Reason for revert: Causing CommandBuffer builds to time out

Original change's description:
> [recipes] Use named caches for git and workdirs
>
> Bug: skia:
> Change-Id: Iaf3d190252c9483c8b9e58a3ab0305db4173cc1c
> Reviewed-on: https://skia-review.googlesource.com/123929
> Commit-Queue: Eric Boren <borenet@google.com>
> Reviewed-by: Ben Wagner <benjaminwagner@google.com>

----------------

Revert "[infra] Fix missing cache for Bookmaker"

This reverts commit d19f039a16.

Reason for revert: Need to revert https://skia-review.googlesource.com/123929

Original change's description:
> [infra] Fix missing cache for Bookmaker
>
> Bug: skia:
> Change-Id: I12d42fa1bb364ea6c75865f72143daf92b8c12c3
> Reviewed-on: https://skia-review.googlesource.com/124052
> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
> Commit-Queue: Eric Boren <borenet@google.com>

----------------

Revert "Fix missing/duplicate named caches"

This reverts commit 0820a6fb69.

Reason for revert: Need to revert https://skia-review.googlesource.com/123929

Original change's description:
> Fix missing/duplicate named caches
>
> Fixes issue with https://skia-review.googlesource.com/c/skia/+/123929
>
> No-Try: true
> Change-Id: I582b2bba67b8b257f35c5b85ccfe6e6304ff7a7c
> Reviewed-on: https://skia-review.googlesource.com/124180
> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
> Auto-Submit: Ben Wagner <benjaminwagner@google.com>
> Reviewed-by: Ravi Mistry <rmistry@google.com>

----------------

TBR=borenet@google.com,benjaminwagner@google.com,rmistry@google.com

Change-Id: Id8443ad9dc50f018251a6b6892b06fe256e6c578
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/124203
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2018-04-26 22:21:04 +00:00
Eric Boren
e8615f969e [recipes] Use named caches for git and workdirs
Bug: skia:
Change-Id: Iaf3d190252c9483c8b9e58a3ab0305db4173cc1c
Reviewed-on: https://skia-review.googlesource.com/123929
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2018-04-26 18:51:13 +00:00
Kevin Lubick
88611a1a71 Update test expectations for Debian9
The removal of the blacklists is really a no-op because of
https://skia-review.googlesource.com/c/skia/+/9339

Bug: skia:7840
Change-Id: I72e2e03bbbc813737655a3d5f3a1e874d3a41909
Reviewed-on: https://skia-review.googlesource.com/123925
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-04-26 17:16:53 +00:00
Adrienne Walker
6f719aeeae Add CheckGeneratedFiles recipe check for gpu workarounds
Followup to https://skia-review.googlesource.com/122800

Bug: chromium: 829614
Change-Id: Idde753e0f8943290208625ba5b6332a5fdc07184
Reviewed-on: https://skia-review.googlesource.com/123536
Commit-Queue: Adrienne Walker <enne@chromium.org>
Commit-Queue: Eric Boren <borenet@google.com>
Auto-Submit: Adrienne Walker <enne@chromium.org>
Reviewed-by: Eric Boren <borenet@google.com>
2018-04-25 19:26:27 +00:00
Ben Wagner
122b38560f Add SwiftShader Test jobs.
Bug: skia:7671
Change-Id: I29134929071ba6c59de948e5f579d33e973f9baa
Reviewed-on: https://skia-review.googlesource.com/122541
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-04-23 15:01:40 +00:00
Eric Boren
5c2ed720ec [infra] Fast-forward recipes, re-enable roller
Bug: skia:
Change-Id: I3dfda2b49917079350b89d739ba6e00fd12c20f1
Reviewed-on: https://skia-review.googlesource.com/122300
Auto-Submit: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2018-04-23 14:06:50 +00:00
Eric Boren
7817931a5c Switch RecreateSKPs and Bookmaker bots to use service accounts
Bug: skia:
Change-Id: I59aefe7c7e7a6861b00f0e22310e7ceaff3d6d0e
Reviewed-on: https://skia-review.googlesource.com/122944
Reviewed-by: Ravi Mistry <rmistry@google.com>
2018-04-23 13:00:19 +00:00
Ben Wagner
bbdee1befa Add SwiftShader Build jobs.
Bug: skia:7671
No-Try: true
Change-Id: I34015cceca538c84d87a77b6688fa1490c620d04
Reviewed-on: https://skia-review.googlesource.com/121425
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-04-20 16:45:25 +00:00
Kevin Lubick
bc54533b2b Fix Chromecast bots
The psuedo-tty allocation seems to have been wrong and switching
to Kitchen exacerbated the matter.

Bug: skia:
Change-Id: Ie44d3952383d89d398722837e7bbc51798e5833e
Reviewed-on: https://skia-review.googlesource.com/122304
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
Auto-Submit: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-04-19 14:39:56 +00:00
Eric Boren
9599b0fd91 Reland "[infra] Run recipes through Kitchen"
Bug: skia:7050
Change-Id: Icf0bcfbbc505c90a4e8cee7437037a3037bdf33b
Reviewed-on: https://skia-review.googlesource.com/121781
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-04-19 11:27:46 +00:00
Eric Boren
8ff86a6f38 [infra] Support recursive configs in builder_name_schema
This fixes problems with Upload- tasks which just prefix other types of
task names.

Bug: skia:
Change-Id: Icdbcfc5a889e821c6923f635eae0744c3cb0133c
Reviewed-on: https://skia-review.googlesource.com/121786
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2018-04-17 18:56:24 +00:00
Eric Boren
bd2e1f1ca6 Revert "Reland "[infra] Run recipes through Kitchen""
This reverts commit f39bbe5a31.

Reason for revert: Broke lots of bots

Original change's description:
> Reland "[infra] Run recipes through Kitchen"
> 
> Bug: skia:7050
> Change-Id: I331014c408dd5b6f7baafd78ffd12f1235c5bfe7
> Reviewed-on: https://skia-review.googlesource.com/121481
> Commit-Queue: Eric Boren <borenet@google.com>
> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
> Reviewed-by: Ravi Mistry <rmistry@google.com>

TBR=borenet@google.com,benjaminwagner@google.com,rmistry@google.com

Change-Id: I4548c66a9cb0b4f105e2bc3b1c7185d14549172f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:7050
Reviewed-on: https://skia-review.googlesource.com/121463
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-04-17 11:28:54 +00:00
Eric Boren
f39bbe5a31 Reland "[infra] Run recipes through Kitchen"
Bug: skia:7050
Change-Id: I331014c408dd5b6f7baafd78ffd12f1235c5bfe7
Reviewed-on: https://skia-review.googlesource.com/121481
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2018-04-17 11:13:53 +00:00
Eric Boren
276886160b Revert "[infra] Run recipes through Kitchen"
This reverts commit 7bbb26fee0.

Reason for revert: uploads broke task scheduler

Original change's description:
> [infra] Run recipes through Kitchen
> 
> Bug: skia:7050
> Change-Id: I50632444eb4ca7f9ae2b1b30b766e531092ccad4
> Reviewed-on: https://skia-review.googlesource.com/82500
> Commit-Queue: Eric Boren <borenet@google.com>
> Reviewed-by: Ravi Mistry <rmistry@google.com>

TBR=borenet@google.com,rmistry@google.com

Change-Id: Ic3a5404fde844f01eca551d50039a84a20e84e11
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:7050
Reviewed-on: https://skia-review.googlesource.com/121423
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-04-16 13:21:07 +00:00
Eric Boren
7bbb26fee0 [infra] Run recipes through Kitchen
Bug: skia:7050
Change-Id: I50632444eb4ca7f9ae2b1b30b766e531092ccad4
Reviewed-on: https://skia-review.googlesource.com/82500
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2018-04-16 12:07:05 +00:00
Ben Wagner
9bd736b9b4 Add loongson3a Build jobs.
Change-Id: I4a0259f82272099e08df0e7dea91489f6d641ca4
Reviewed-on: https://skia-review.googlesource.com/113670
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
2018-04-04 20:37:28 +00:00
Mike Klein
378679cc47 add Mac ASAN bots
Change-Id: I783c0ad51a33e4731470f457132a1d20025a3431
Reviewed-on: https://skia-review.googlesource.com/118342
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Ben Wagner <bungeman@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-04-04 16:42:18 +00:00
Mike Klein
21aa7b8f24 limit cpu features of skcms on bots we limit skia
Valgrind doesn't support half<->float x86 conversion instructions,
so we build those bots with SK_CPU_LIMIT_SSE41.  We now also need
to limit skcms on those same bots.

Easiest thing to do is build completely portable scalar code, using
the existing -DSKCMS_PORTABLE.  We can get fancier later if needed.

Change-Id: Icf14c72a220818be9df7b97bcf203e4412c3c6b7
Reviewed-on: https://skia-review.googlesource.com/118264
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2018-04-03 19:57:20 +00:00
Mike Klein
a48caa5601 remove CC,CXX,CPPFLAGS from compile environment
I don't believe any of these have any effect now that all
builds are done through GN.  My best recollection is that
they used to affect GYP-based builds.

Change-Id: Ifde9f7c4d531dab43e8d407fc779d2ab6e38411c
Reviewed-on: https://skia-review.googlesource.com/118263
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Eric Boren <borenet@google.com>
2018-04-03 19:25:31 +00:00
Mike Klein
e7d5bb7493 update Ubuntu14 CT bots to Clang
To run on these older bots, looks like we need to statically link
libstdc++ and libgcc.  Luckily that is straightforward.

Change-Id: If523067df196e943c2ba2f64c52eea0711dbfcbd
Reviewed-on: https://skia-review.googlesource.com/115743
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2018-03-22 23:53:09 +00:00
Ben Wagner
ed4ff9c9d0 Reland "Switch Win Exceptions Build to Clang."
This reverts commit 2f2419b936.

Reason for revert: Creating CL to reland

Original change's description:
> Revert "Switch Win Exceptions Build to Clang."
> 
> This reverts commit e1cb4778c7.
> 
> Reason for revert: Need to revert dependency https://skia-review.googlesource.com/c/skia/+/114093
> 
> Original change's description:
> > Switch Win Exceptions Build to Clang.
> > 
> > No-Try: true
> > Change-Id: I119c7853299b6eef65f991b41cbb2afb0a35f431
> > Reviewed-on: https://skia-review.googlesource.com/113673
> > Commit-Queue: Ben Wagner <benjaminwagner@google.com>
> > Reviewed-by: Mike Klein <mtklein@google.com>
> 
> TBR=mtklein@google.com,benjaminwagner@google.com
> 
> Change-Id: I36f4c6cdf890043d4b77b8d5347b4752f58ebd33
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://skia-review.googlesource.com/114420
> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
> Commit-Queue: Ben Wagner <benjaminwagner@google.com>

TBR=mtklein@google.com,benjaminwagner@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Ie4ba6c264b3ab2b3c63ac0e225638b0a4e70cda1
Reviewed-on: https://skia-review.googlesource.com/114822
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-03-20 20:54:37 +00:00
Ben Wagner
7b065e124c [recipes] Add toolchain version to extra_cflags.
In compile recipes, add a dummy define (e.g.
-DDUMMY_clang_linux_version=42) to the compiler flags so that ninja will
recompile from scratch when the toolchain changes.

Bug: skia:7720
Change-Id: I9a330b21af364b3aa6a1eebbe6ac2022cfa82fdc
Reviewed-on: https://skia-review.googlesource.com/115160
Reviewed-by: Eric Boren <borenet@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-03-20 14:05:33 +00:00
Ben Wagner
f20710e00c [recipes] Add asset_version utility function.
Bug: skia:7720
Change-Id: I044ca5281354b21c9deffa408ad7ec20c51d2e2e
Reviewed-on: https://skia-review.googlesource.com/115122
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-03-20 14:02:03 +00:00
Eric Boren
ccbe400174 [recipes] Band-aid on top of a hack: pin depot_tools
Bug: skia:7050
Change-Id: I53b141bf76ab4773909df968f69ba04dc29e0dc9
Reviewed-on: https://skia-review.googlesource.com/114960
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-03-19 12:43:45 +00:00
Ravi Mistry
8b6a9ae701 Revert "Scale the GPU when running perf on Pixel(2)"
This reverts commit aa504cddb9.

Reason for revert: Kevin asked me to revert since this broke things

Original change's description:
> Scale the GPU when running perf on Pixel(2)
> 
> This is a similar followup to:
> https://skia-review.googlesource.com/c/skia/+/93561
> 
> Bug: skia:
> Change-Id: I9b11dbf3d063fd64b1dd712cf1c596618f2c9ffc
> Reviewed-on: https://skia-review.googlesource.com/114340
> Reviewed-by: Eric Boren <borenet@google.com>
> Commit-Queue: Kevin Lubick <kjlubick@google.com>

TBR=borenet@google.com,kjlubick@google.com

Change-Id: Idbc7234f2b7ff8c5e632680903836e1f4eaa50d5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/114425
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2018-03-14 18:31:12 +00:00
Kevin Lubick
aa504cddb9 Scale the GPU when running perf on Pixel(2)
This is a similar followup to:
https://skia-review.googlesource.com/c/skia/+/93561

Bug: skia:
Change-Id: I9b11dbf3d063fd64b1dd712cf1c596618f2c9ffc
Reviewed-on: https://skia-review.googlesource.com/114340
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-03-14 17:46:51 +00:00
Ben Wagner
2f2419b936 Revert "Switch Win Exceptions Build to Clang."
This reverts commit e1cb4778c7.

Reason for revert: Need to revert dependency https://skia-review.googlesource.com/c/skia/+/114093

Original change's description:
> Switch Win Exceptions Build to Clang.
> 
> No-Try: true
> Change-Id: I119c7853299b6eef65f991b41cbb2afb0a35f431
> Reviewed-on: https://skia-review.googlesource.com/113673
> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
> Reviewed-by: Mike Klein <mtklein@google.com>

TBR=mtklein@google.com,benjaminwagner@google.com

Change-Id: I36f4c6cdf890043d4b77b8d5347b4752f58ebd33
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/114420
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-03-14 17:20:13 +00:00
Ben Wagner
e462b80d96 Remove Goma builds and support in gn_flavor.
The experiment with using Goma to speed up Windows compiles was very
close to being successful, but at this point the ongoing maintenance
does not seem to be worth the 50-70 seconds saved.

Change-Id: Ie3900b9a681e448a3e47634efbab7695ebccad33
Reviewed-on: https://skia-review.googlesource.com/114363
Reviewed-by: Mike Klein <mtklein@chromium.org>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-03-14 17:16:52 +00:00