This particular test this is addressing is:
1. very large device (>32K in a test case)
2. drawPoints has special (fast) case where it converts all of the pts (rects) into fixed point
3. overflows fixed -- assert
Paths already don't draw into a device this large (they are limited by 32K I think, smaller if aa)
The (theoretical) solution for paths is to tile the draw itself. Perhaps that approach could be
applied everywhere in bitmapdevice...
This older issue sums up this idea: https://bugs.chromium.org/p/skia/issues/detail?id=2122
Will look into this general solution in a separate CL/effort.
Bug: skia:7425
Change-Id: I57f8da92df78127e6b8e42e422c43e50bb5748d6
Reviewed-on: https://skia-review.googlesource.com/96700
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
To fix gm/bigrect, needed to do adjust "largest" rect so it doesn't become empty when round-tripping with SkRect/SkIRect.
I renamed it after this.
Bug: skia:
Change-Id: I747782c8456da603cf298275d2300ea1996e7629
Reviewed-on: https://skia-review.googlesource.com/95563
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Yuqian Li <liyuqian@google.com>
Will work next to try to make isEmpty() private
Bug: skia:7470
Bug:799715
Change-Id: I7b43028ecd86dca68e0c67225712516d2f2f88a2
Reviewed-on: https://skia-review.googlesource.com/92620
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Bug:798066
Change-Id: Iac324ac5a32fae241a528751c84279ce60ac4baf
Reviewed-on: https://skia-review.googlesource.com/90544
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Reed <reed@google.com>
