Commit Graph

117 Commits

Author SHA1 Message Date
Eric Boren
25062cf420 Fix missing clang_linux package for *SAN
Bug: skia:
Change-Id: I7df6434a5fc538bb070f02efd3e211e1f57aecb5
Reviewed-on: https://skia-review.googlesource.com/21268
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Eric Boren <borenet@google.com>
2017-06-29 19:56:50 +00:00
Eric Boren
fb2050f416 Use the updated local Debian 9 bots
Bug: skia:6612
Change-Id: I569eae4643802a5f081da028bc21addeda48679b
Reviewed-on: https://skia-review.googlesource.com/21160
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2017-06-29 19:33:00 +00:00
Eric Boren
bb198fb371 Fix Linux Swarming dimensions after Debian transition
Bug: skia:6612
Change-Id: I87fe68f485ef5f148ab289c96a916f03db008493
Reviewed-on: https://skia-review.googlesource.com/21101
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2017-06-28 15:56:28 +00:00
Eric Boren
746e2632c6 Move all Linux GCE bots to Debian
NOTREECHECKS:true
Bug: skia:
Change-Id: I612989c6ce2f309d2f70f896500f73e4baa971a7
Reviewed-on: https://skia-review.googlesource.com/19811
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-06-28 12:38:28 +00:00
Ben Wagner
c16d0d5c3b Update Win Haswell/Broadwell driver.
No-Try: true
Change-Id: I3bc19ac43e90de3009ca48a18284485efff21ad8
Reviewed-on: https://skia-review.googlesource.com/20690
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-06-23 19:55:27 +00:00
Ben Wagner
4b1df02324 [infra] Disambiguate GTX960s with cpu dimension.
No-Try: true
Change-Id: Ib55b96bd1ff80fe857b9fa551bb89bf6c2c81f2c
Reviewed-on: https://skia-review.googlesource.com/19968
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-06-15 17:56:48 +00:00
Eric Boren
7e3a364337 Fixes for internal repo infra tests
Bug: skia:6763
Change-Id: I51522693ec8b81ff3b7d4349808d0e6493c5dd5b
Reviewed-on: https://skia-review.googlesource.com/19843
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2017-06-15 13:10:59 +00:00
Greg Daniel
c34aeb722f Update PixelXL bots to O developer preview 3
Bug: skia:6724
Change-Id: I85a2ceed9a2dd662ddd51bfbee6cf185a3fa0eb0
Reviewed-on: https://skia-review.googlesource.com/19810
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2017-06-14 18:04:09 +00:00
Ben Wagner
1d06078fef [infra] Specify GPU driver version in task dimensions.
Bug: skia:6637
Change-Id: I3f692e95efad4079f69fc451c7d4a4b2b8b5df63
Reviewed-on: https://skia-review.googlesource.com/19808
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-06-14 16:23:39 +00:00
Ben Wagner
3668278ee5 [infra] Remove unused flags in gen_tasks.go.
Bug: skia:6637
No-Try: true
Change-Id: Ic2fba996a0fead3cfac61e86874cca13271bb595
Reviewed-on: https://skia-review.googlesource.com/19805
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-06-14 14:30:27 +00:00
Ben Wagner
3d2a2f7220 [infra] Move Android and GPU maps into gen_tasks.go.
Bug: skia:6637
No-Try: true
Change-Id: I1aa47be9d039e8396f8bbf4e1c7e134fe258a1ce
Reviewed-on: https://skia-review.googlesource.com/19095
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-06-14 13:17:43 +00:00
Ben Wagner
50b84682c8 [infra] Isolate tasks don't need compile task.
No-Try: true
Change-Id: I4372c50b183d040e5145ac3ca665cd813da6256a
Reviewed-on: https://skia-review.googlesource.com/19497
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-06-12 17:32:58 +00:00
Ben Wagner
a6b2ba2153 Increase timeout for 32-bit Debug tests.
Bug: skia:6737
No-Try: true
Change-Id: I1e3751f1bce087980bf8f8e4317b1aae1a9fcf8f
Reviewed-on: https://skia-review.googlesource.com/19051
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-06-08 14:54:19 +00:00
Eric Boren
f4a5fc7af0 Use chrome-infra Git CIPD package
Add Git recipe module to easily use this version of Git anywhere.
This fixes recipe bundling and unblocks the recipe roll.

Bug: skia:
Change-Id: Ib4d1361b7a52676e1992025b29e630ea3ada173b
Reviewed-on: https://skia-review.googlesource.com/18833
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2017-06-06 12:45:11 +00:00
Eric Boren
c5a073d031 Fix missing CIPD package for Valgrind perf bots
Bug: skia:
Change-Id: Ia9fb42373d3214ea78976fc140062d5d9b38781a
Reviewed-on: https://skia-review.googlesource.com/18302
Reviewed-by: Eric Boren <borenet@google.com>
2017-06-01 11:31:46 +00:00
Eric Boren
d696df74d4 Add CIPD asset for Valgrind
Bug: skia:6668
Change-Id: I324602b1381f701ec780c02b26775c5e9e09cb84
Reviewed-on: https://skia-review.googlesource.com/17834
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
2017-05-31 19:41:13 +00:00
Kevin Lubick
ffce079f4e Enable chromecast gpu perf
The new #ifndef account for what the chromecast sdk
cannot handle (e.g. posix).

Bug: skia:6581
Change-Id: I3d64d25980d80185f8b95c05badee5f665d97cd3
Reviewed-on: https://skia-review.googlesource.com/13811
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2017-05-24 20:30:05 +00:00
Stephan Altmueller
ddad85b65e Remove transitional parts from iOS job names
Bug: skia:
Change-Id: If19e5a956d3f10448cfe889127c2f79d9c42926e
Reviewed-on: https://skia-review.googlesource.com/17372
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Stephan Altmueller <stephana@google.com>
2017-05-19 18:21:11 +00:00
Ravi Mistry
01b48e7f13 Bot to update buildbucket.config daily
Bug: skia:6591
Change-Id: Ic2ec5b033965ca073a00e272693b1c5e1d0ad69f
Reviewed-on: https://skia-review.googlesource.com/16541
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-05-18 15:01:18 +00:00
Kevin Lubick
9018952290 Use CIPD->Isolate on RPI Perf tasks too
Bug: skia:
NOTRY=true
Change-Id: Ide4c5065ab6c252570a81a52b377cb5fb748d0d5

Change-Id: Ide4c5065ab6c252570a81a52b377cb5fb748d0d5
Reviewed-on: https://skia-review.googlesource.com/16862
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2017-05-15 12:41:43 +00:00
Kevin Lubick
07072944af Isolate CIPD assets for RPI tasks
To verify the assets all end up in the right spot, I wiped all the assets off the phone and then ran
https://chromium-swarm.appspot.com/task?id=36114ccaa41bd810&refresh=10

Overhead comparisons: 
Control: 103s https://chromium-swarm.appspot.com/task?id=360e10170744db10

Cold cache: 105s https://chromium-swarm.appspot.com/task?id=36113c4aec720910
Warm cache: 8s https://chromium-swarm.appspot.com/task?id=361143954c1b1c10

Bug:701930
Bug:skia:5213

Change-Id: I1dc052203ed404b63d0a1974ccbe882d26ff9e48
Reviewed-on: https://skia-review.googlesource.com/16490
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-05-11 18:11:01 +00:00
Eric Boren
234fc140eb [recipes] Remove inputs to BundleRecipes task
This should enable deduplication.

Bug: skia:
Change-Id: I2be98f648acd666c420885f08377c256f9102a8f
Reviewed-on: https://skia-review.googlesource.com/14651
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2017-05-09 17:31:22 +00:00
Ben Wagner
40226b46ad Upgrade Windows 10 to v1703.
No-Try: true
Change-Id: Ifb8528d889233fa14320b9f665ddcaf2f5fae6fb
Reviewed-on: https://skia-review.googlesource.com/15141
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-05-03 17:44:30 +00:00
Ben Wagner
988d15effd [infra/bots] Treat extra_config as a list.
Dependency of https://skia-review.googlesource.com/c/14525/

No-Try: true
Change-Id: I7686576aa48865116fe8a593f08d395f901a1d04
Reviewed-on: https://skia-review.googlesource.com/14524
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-04-27 22:10:47 +00:00
Eric Boren
6ec17e3773 Add releaseAndAbandonGpuContext bot
Bug: skia:5142
Change-Id: I35bd42d1a9da2293092a2f09aaaf523a0f36537a
Reviewed-on: https://skia-review.googlesource.com/14376
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2017-04-26 18:58:24 +00:00
Stephan Altmueller
63e843d891 Enable ios on Raspberry Pi
Adds more jobs to iOS testing and switches to 
RPi based hosts. 

Bug: skia:
Change-Id: I0124c6554173fa3b22b077a198612bb30691d1fb
Reviewed-on: https://skia-review.googlesource.com/11521
Commit-Queue: Stephan Altmueller <stephana@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-04-25 16:56:41 +00:00
Eric Boren
0941950866 Infra: Enable cross-repo tryjobs
Bug: skia:
Change-Id: I560eb00b4b19643346b038822869e5bc77ce1454
Reviewed-on: https://skia-review.googlesource.com/13652
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2017-04-21 16:58:36 +00:00
Ben Wagner
56738d85ae Add Win7 and Win8 bots.
Bug: skia:6517
No-Try: true
Change-Id: I02abf8aae6c356be23612f2d5442e6837919a1dc
Reviewed-on: https://skia-review.googlesource.com/13597
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-04-18 19:47:42 +00:00
Eric Boren
f9c0904048 Make RecreateSKPs use the Go CIPD asset
NOTRY=true
Bug: skia:
Change-Id: I21212b62cd068bd722598fe8daadf184c87785df
Reviewed-on: https://skia-review.googlesource.com/13583
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2017-04-17 11:53:44 +00:00
Eric Boren
ade6920037 Change infra recipe module to use the Go asset
Bug: skia:
Change-Id: Ib2fa0b971f201ea2f16afd0467d7882b66b4047c
Reviewed-on: https://skia-review.googlesource.com/13331
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2017-04-13 16:26:22 +00:00
Kevin Lubick
671cd72c0a Add jobs for Samsung Chromebook Plus
Also refactor the cipd package used to compile these, as it can be reused.

Bug: skia:
NOTRY=true
Change-Id: I53cf5b7fdfcb8cafd50791a0beaaf557fafa65c3
Reviewed-on: https://skia-review.googlesource.com/13252
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-04-12 16:51:21 +00:00
Eric Boren
b8ab7f7634 Fix BundleRecipes depending on Release-Shared build
It doesn't create an actual dependency, but it does cause the
Release-Shared build to be added to the tasks DAG, where it would be
orphaned if not for the other housekeeper.

Bug: skia:
Change-Id: Ia2974728ec353c7f209db45474e572d83cacbda5
Reviewed-on: https://skia-review.googlesource.com/13003
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2017-04-10 15:46:47 +00:00
Eric Boren
f9aa9e5169 Clean up no-longer-used recipes stuff
- Remove buildbot logic
- Remove non-Gerrit logic
- Remove master, slave, and build number properties

Bug: skia:6473
Change-Id: I203d523f3a0e03f933c0c48d29c7aabac503b2b9
Reviewed-on: https://skia-review.googlesource.com/12625
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2017-04-10 14:27:58 +00:00
Eric Boren
768f52ff85 Rename recipes: swarm_[name] -> [name]
Bug: skia:6473
Change-Id: Id78f0b5cb50ae2243b9a5aed8e552f7ed8202228
Reviewed-on: https://skia-review.googlesource.com/12060
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2017-04-10 12:47:43 +00:00
Kevin Lubick
cb6f3980a5 Add ChromeOS Test/Perf jobs and recipe changes
Minor cleanup of left over Tab3 tests.

Bug: skia:6442
Change-Id: I03bb4a034101a2773619abd2be7a300a70f6ac3d
Reviewed-on: https://skia-review.googlesource.com/11414
Reviewed-by: Eric Boren <borenet@google.com>
2017-04-07 14:41:07 +00:00
Eric Boren
23a6ec6eb3 Reland: Use bundled recipes for all test/perf tasks
It won't save as much time for faster machines, but it should still
shave a few seconds, and it'll be nice to be consistent.

Bug: skia:
Change-Id: I0b2aa010579b527c66325cb5b691bfb549b31316
Reviewed-on: https://skia-review.googlesource.com/11418
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2017-04-07 13:26:10 +00:00
Eric Boren
085bf7cce6 Revert "Remove CPU dimension for Win GCE bots"
This reverts commit 25bf350d10.

Reason for revert: Speculatively reverting to see if this unsticks try jobs.

Original change's description:
> Remove CPU dimension for Win GCE bots
> 
> This is mainly to collapse the two groups on the capacity stats page.
> 
> Bug: skia:
> Change-Id: Icc125f6fa773ebf11909b0606bc7958146da5983
> Reviewed-on: https://skia-review.googlesource.com/11417
> Reviewed-by: Kevin Lubick <kjlubick@google.com>
> Commit-Queue: Eric Boren <borenet@google.com>
> 

TBR=borenet@google.com,kjlubick@google.com,reviews@skia.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Change-Id: I52f01f6a915fa0ac4446bd492b9e455a07841ee9
Reviewed-on: https://skia-review.googlesource.com/11484
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2017-04-06 17:32:56 +00:00
Eric Boren
25bf350d10 Remove CPU dimension for Win GCE bots
This is mainly to collapse the two groups on the capacity stats page.

Bug: skia:
Change-Id: Icc125f6fa773ebf11909b0606bc7958146da5983
Reviewed-on: https://skia-review.googlesource.com/11417
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2017-04-06 14:12:45 +00:00
Eric Boren
6276a7c999 Revert "Use bundled recipes on all Test/Perf tasks"
This reverts commit 43b9c6bbf6.

Reason for revert: Windows failing

Original change's description:
> Use bundled recipes on all Test/Perf tasks
> 
> It won't save as much time for faster machines, but it should still
> shave a few seconds, and it'll be nice to be consistent.
> 
> Bug: skia:5813
> Change-Id: I5724e7aae83851edff3129265a9ffee5c3f95825
> Reviewed-on: https://skia-review.googlesource.com/11340
> Commit-Queue: Eric Boren <borenet@google.com>
> Reviewed-by: Kevin Lubick <kjlubick@google.com>
> 

TBR=borenet@google.com,kjlubick@google.com,reviews@skia.org,iannucci@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Change-Id: I2a9cc1c12079755969879e37da5cae9f93921ddd
Reviewed-on: https://skia-review.googlesource.com/11416
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2017-04-06 12:53:42 +00:00
Eric Boren
43b9c6bbf6 Use bundled recipes on all Test/Perf tasks
It won't save as much time for faster machines, but it should still
shave a few seconds, and it'll be nice to be consistent.

Bug: skia:5813
Change-Id: I5724e7aae83851edff3129265a9ffee5c3f95825
Reviewed-on: https://skia-review.googlesource.com/11340
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2017-04-06 12:34:31 +00:00
Kevin Lubick
261ea19c4d Add recipe to build for Asus Flip Chromebook
This build includes the GPU-specific code (EGL, GLES)

The armhf_sysroot should be generic enough to support
other ARM targets, like the Raspberry Pi.

I split out the EGL dependencies into their own CIPD package
(chromebook_c100p_lib) to facilitate the modularity of the approach.

When we add another ARM chromebook, maybe one that has different libraries,
we should be able to re-use armhf_sysroot and then a newly created CIPD asset for
that specific GPU (if needed).

Maybe this also can be used to build for the chromecasts (thus the TODO)

Bug: skia:
NOTRY=true

Change-Id: Icc131025932dc8d41da5be39f3c5cad0aa95d848
Reviewed-on: https://skia-review.googlesource.com/11064
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-04-05 11:39:04 +00:00
Eric Boren
8b3f9e64ff Bundle recipes for use on RPi
This saves ~1:30 of overhead when the isolate cache is warm.

Bug: skia:5813
Change-Id: I5053d66e865ca6500b82567f83be8042568e22cf
Reviewed-on: https://skia-review.googlesource.com/11063
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2017-04-04 16:01:47 +00:00
Kevin Lubick
4610a9b3c1 Consolidate Linux GCE dimensions
It appears we were not setting the CPU for our Build
Tasks, which confused our capacity metrics.


BUG=skia:

Change-Id: I60cbe3b99b9de6865141f124df5618975bf65a05
Reviewed-on: https://skia-review.googlesource.com/10020
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-03-22 21:33:16 +00:00
Kevin Lubick
291547d4e7 Add Chromecast Perf jobs
It starts out with some skps and resource-based perf
because all skps wouldn't fit and skimages are far too large

BUG=skia:

Change-Id: Icb07ffa84d39a85a8bc595e74ef934df921e749a
Reviewed-on: https://skia-review.googlesource.com/9901
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-03-21 14:52:26 +00:00
Stephan Altmueller
5f3b94074e Move build tasks to MacOS 10.12
BUG=skia:

Change-Id: I5317dde5262ff6e880fa54a660f09205c616f1a4
Reviewed-on: https://skia-review.googlesource.com/9898
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Stephan Altmueller <stephana@google.com>
2017-03-21 14:33:48 +00:00
Kevin Lubick
dcd2a908f4 Add jobs for building for Chromecast
BUG=skia:6345

Change-Id: Iaf09eb7f57ae71687c6804221837a8cc8ef04931
Reviewed-on: https://skia-review.googlesource.com/9419
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-03-08 19:41:14 +00:00
Ben Wagner
adfeaf1831 Remove special build for Valgrind.
Valgrind uses the unmodified binary. See skia:6267.

BUG=skia:6267

Change-Id: I3fcecf9ffce67ebec88d4005e464c66d25c6aa21
Reviewed-on: https://skia-review.googlesource.com/8833
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-02-22 15:18:13 +00:00
Eric Boren
5d9f3bfd2f Do not retry test or perf tasks
BUG=skia:

Change-Id: I153978a92420eb2c39024213ebcdf95d1b8bde30
Reviewed-on: https://skia-review.googlesource.com/8839
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
2017-02-22 14:08:27 +00:00
Ben Wagner
46df2a1372 Split Valgrind jobs -- one DM/NB run per task.
Reland of https://skia-review.googlesource.com/c/8723/1

BUG=skia:2789
NOTRY=true

Change-Id: I1fbd314457a9d411543c8d7af4df166608d1acc7
Reviewed-on: https://skia-review.googlesource.com/8832
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-02-22 00:13:10 +00:00
Ben Wagner
7c25f963b9 Revert "Split Valgrind jobs -- one DM/NB run per task."
This reverts commit bc9cd524d8.

Reason for revert: Unable to find Valgrind binary.

Original change's description:
> Split Valgrind jobs -- one DM/NB run per task.
> 
> Remove special build for Valgrind -- Valgrind uses the unmodified binary. See skia:6267.
> 
> BUG=skia:2789,skia:6267
> 
> Change-Id: Id56c460abf36eb2be633ac3a309e0dbc7a278f41
> Reviewed-on: https://skia-review.googlesource.com/8723
> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
> Reviewed-by: Eric Boren <borenet@google.com>
> Reviewed-by: Mike Klein <mtklein@chromium.org>
> 

TBR=mtklein@chromium.org,borenet@google.com,mtklein@google.com,benjaminwagner@google.com,reviews@skia.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:2789,skia:6267

Change-Id: I16876a8528c441805931ed21e9aa8688ab2e0b4c
Reviewed-on: https://skia-review.googlesource.com/8831
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-02-21 23:56:57 +00:00