joshualitt
43b46d1f56
rebase from early clip
...
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/707413003
2014-11-11 07:40:16 -08:00
jvanverth
428b2a5a4f
Re-enable no-longer-flaky GMs
...
TBR=jcgregorio@google.com
Review URL: https://codereview.chromium.org/684413004
2014-11-10 12:12:55 -08:00
jvanverth
3c10c0d444
Reignore some tests that use distance fields
...
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/708173002
2014-11-07 14:57:13 -08:00
jvanverth
6f1cad4030
Rebaseline for https://codereview.chromium.org/703463002/ .
...
TBR=egdaniel@google.com
Review URL: https://codereview.chromium.org/709043002
2014-11-07 08:16:49 -08:00
joshualitt
2c93efeb6f
Clip in grdrawtarget
...
NOTREECHECKS=true
BUG=skia:
Review URL: https://codereview.chromium.org/685883003
2014-11-06 12:57:13 -08:00
egdaniel
036a2bbbcc
Remove gm from ignore expectation file
...
No gm's actually changed from my recent change to dashing gm. This was the desired
outcome since the added calls were lines of length zero
TBR=robertphillips@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/706633002
2014-11-05 08:57:16 -08:00
egdaniel
21402e3851
Bug fix for cull_line in SkDashPathEffect.
...
In cull_line we must also check if both points are the same. Otherwise we
fail the assert in the else "SkASSERT(dy && !dx)".
This is currently blocking the roll as it fails a webkit test.
BUG=skia:
Review URL: https://codereview.chromium.org/703783002
2014-11-05 05:02:27 -08:00
joshualitt
2f5cb2fb95
update baselines and ignores for texture_domain
...
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/697233003
2014-11-03 17:47:47 -08:00
jvanverth
ada68ef2dc
Improve quality of distance field rendering
...
- Update spacing of LODs to get better results scaling up to 256
- Remove unnecessary "bolding" from dftext
- Add debug colors for dftext LODs
BUG=skia:2933,skia:2935
Review URL: https://codereview.chromium.org/703463002
2014-11-03 14:00:24 -08:00
joshualitt
50408adfd2
Test factory uses the inorder draw buffer
...
BUG=skia:
Review URL: https://codereview.chromium.org/696353002
2014-11-03 12:31:15 -08:00
robertphillips
66cad7669b
Always enable layer hoisting in Skia
...
This will prevent bit rot of the layer hoisting code and position us better for turning this on in Chromium.
Review URL: https://codereview.chromium.org/698493002
2014-11-03 07:19:30 -08:00
joshualitt
a39c5374f4
rebaseline
...
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/696853002
2014-10-31 16:16:56 -07:00
joshualitt
92e496f96a
Beginning to refactor nvpr code
...
BUG=skia:
Review URL: https://codereview.chromium.org/687563008
2014-10-31 13:56:50 -07:00
jvanverth
9154dd4552
Rebaseline GMs for https://codereview.chromium.org/687283002/
...
BUG=skia:2935
Review URL: https://codereview.chromium.org/684833003
2014-10-31 07:16:54 -07:00
jvanverth
b61283f9c7
Support multiple scales for dfpaths.
...
Adds miplevel as part of dfpath key, and scale factor so we know
how much to adjust to fit desired scale.
BUG=skia:2935
Review URL: https://codereview.chromium.org/687283002
2014-10-30 05:57:21 -07:00
senorblanco
8f3937d9fc
Fix bounds computation of all 0-input filters.
...
The SkRectShaderImageFilter had the same bug as previously fixed for
SkBitmapSource and SkPictureImageFilter. Rather than copy-and-paste
the implementation, this change makes all filters with 0 inputs return
their source bounds, instead of returning false.
BUG=427251
Review URL: https://codereview.chromium.org/681643003
2014-10-29 12:36:32 -07:00
joshualitt
7a56931784
one more test updated
...
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/681373003
2014-10-28 17:23:35 -07:00
joshualitt
584e4fd2b8
rebaselines
...
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/682123003
2014-10-28 17:07:44 -07:00
joshualitt
ea04d2d0bb
more ignores
...
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/688443002
2014-10-28 13:22:56 -07:00
joshualitt
0e602827df
Working patch to remove constant attributes. This may cause some gm mismatches, I will rebaseline tonight.
...
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/84c94c0dfd1e12e97d8a835882dda575f36e41d2
Committed: https://skia.googlesource.com/skia/+/95f5194abce19e8ed875f3495fd16c79a9b931b4
Review URL: https://codereview.chromium.org/678073005
2014-10-28 10:27:44 -07:00
joshualitt
98102a8f79
Revert of Patch to remove constant attributes (patchset #8 id:120002 of https://codereview.chromium.org/678073005/ )
...
Reason for revert:
I'll checkin tonight when the tree is quieter
Original issue's description:
> Working patch to remove constant attributes. This may cause some gm mismatches, I will rebaseline tonight.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/84c94c0dfd1e12e97d8a835882dda575f36e41d2
>
> Committed: https://skia.googlesource.com/skia/+/95f5194abce19e8ed875f3495fd16c79a9b931b4
TBR=bsalomon@google.com ,egdaniel@google.com,joshualitt@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/683203002
2014-10-28 09:08:35 -07:00
joshualitt
95f5194abc
Working patch to remove constant attributes. This may cause some gm mismatches, I will rebaseline tonight.
...
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/84c94c0dfd1e12e97d8a835882dda575f36e41d2
Review URL: https://codereview.chromium.org/678073005
2014-10-28 07:54:54 -07:00
hcm
4396fa594e
Revert of Use approximate scratch textures for image filters. (patchset #2 id:20001 of https://codereview.chromium.org/679113004/ )
...
Reason for revert:
Continued GM failures
Original issue's description:
> Use approximate scratch textures for image filters.
>
> Committed: https://skia.googlesource.com/skia/+/96c60686eef6fc514feba6136f1b475f71dbf3ec
>
> Committed: https://skia.googlesource.com/skia/+/50a140563c5960acb2479d2be7c437d146963b3f
TBR=senorblanco@google.com ,senorblanco@chromium.org,bsalomon@google.com
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/681183002
2014-10-27 21:43:30 -07:00
hcm
d0f1969100
Revert of Fix bounds computation of all 0-input filters. (patchset #2 id:20001 of https://codereview.chromium.org/681643003/ )
...
Reason for revert:
try again
Original issue's description:
> Fix bounds computation of all 0-input filters.
>
> The SkRectShaderImageFilter had the same bug as previously fixed for
> SkBitmapSource and SkPictureImageFilter. Rather than copy-and-paste
> the implementation, this change makes all filters with 0 inputs return
> their source bounds, instead of returning false.
>
> BUG=427251
>
> Committed: https://skia.googlesource.com/skia/+/ba036cc82b5a543a13cafd11a19ba0e3087fca38
TBR=bsalomon@google.com ,senorblanco@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=427251
Review URL: https://codereview.chromium.org/678273002
2014-10-27 20:55:01 -07:00
hcm
4984d473ab
Revert of Rebaseline imagemagnifier and dropshadowimagefilter tests. (patchset #3 id:40001 of https://codereview.chromium.org/685523002/ )
...
Reason for revert:
Getting to revert for failures on image filter tests in Skia and Blink
Original issue's description:
> Rebaseline imagemagnifier and dropshadowimagefilter tests.
>
> BUG=skia:
> TBR=hcm@google.com
> NOTRY=true
>
> Committed: https://skia.googlesource.com/skia/+/0fc71ea432d3895ede198a24080f877e607cd264
TBR=senorblanco@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/678043003
2014-10-27 20:53:25 -07:00
hcm
ac011a5f90
Revert of Re-add suppressions for magnifier and dropshadow GMs. (patchset #1 id:1 of https://codereview.chromium.org/686573002/ )
...
Reason for revert:
Trying to get revert of patchset potentially causing failures on image filter tests
Original issue's description:
> Re-add suppressions for magnifier and dropshadow GMs.
>
> Brian's change has invalidated the new baselines, so they'll need
> to be rebaselined again once his changed has worked its way through.
>
> TBR=bsalomon
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/fa4689d56384da5bb264a480e636fac126fb93ca
TBR=bsalomon@google.com ,senorblanco@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/679413002
2014-10-27 20:48:57 -07:00
joshualitt
9f2825f249
Revert of Patch to remove constant attributes (patchset #6 id:100001 of https://codereview.chromium.org/678073005/ )
...
Reason for revert:
Breaks the K1
Original issue's description:
> Working patch to remove constant attributes. This may cause some gm mismatches, I will rebaseline tonight.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/84c94c0dfd1e12e97d8a835882dda575f36e41d2
TBR=bsalomon@google.com ,egdaniel@google.com,joshualitt@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/679363002
2014-10-27 17:56:18 -07:00
joshualitt
84c94c0dfd
Working patch to remove constant attributes. This may cause some gm mismatches, I will rebaseline tonight.
...
BUG=skia:
Review URL: https://codereview.chromium.org/678073005
2014-10-27 15:33:33 -07:00
senorblanco
fa4689d563
Re-add suppressions for magnifier and dropshadow GMs.
...
Brian's change has invalidated the new baselines, so they'll need
to be rebaselined again once his changed has worked its way through.
TBR=bsalomon
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/686573002
2014-10-27 14:26:26 -07:00
senorblanco
0fc71ea432
Rebaseline imagemagnifier and dropshadowimagefilter tests.
...
BUG=skia:
TBR=hcm@google.com
NOTRY=true
Review URL: https://codereview.chromium.org/685523002
2014-10-27 14:12:58 -07:00
bsalomon
50a140563c
Use approximate scratch textures for image filters.
...
Committed: https://skia.googlesource.com/skia/+/96c60686eef6fc514feba6136f1b475f71dbf3ec
Review URL: https://codereview.chromium.org/679113004
2014-10-27 13:56:20 -07:00
senorblanco
ba036cc82b
Fix bounds computation of all 0-input filters.
...
The SkRectShaderImageFilter had the same bug as previously fixed for
SkBitmapSource and SkPictureImageFilter. Rather than copy-and-paste
the implementation, this change makes all filters with 0 inputs return
their source bounds, instead of returning false.
BUG=427251
Review URL: https://codereview.chromium.org/681643003
2014-10-27 13:38:13 -07:00
jvanverth
87ab518627
Update GM expectations for https://codereview.chromium.org/677463002/
...
BUG=skia:2935
TBR=mtklein@google.com
Review URL: https://codereview.chromium.org/677123002
2014-10-24 12:53:01 -07:00
mtklein
da0de7ed90
rebaseline for new shaderproc
...
BUG=skia:
Review URL: https://codereview.chromium.org/674123003
2014-10-24 08:05:59 -07:00
bsalomon
8dae0f364b
Rebaseline lots of images, associate some with bug 3063.
...
TBR=
NOTRY=true
Review URL: https://codereview.chromium.org/661323003
2014-10-24 07:26:01 -07:00
jvanverth
b3eb687f8a
Set temporary paths volatile so we don't cache them.
...
Any path that is generated frame-to-frame should not be rendered by using the
DistanceFieldPathRenderer, because generating the initial distance field,
uploading it and rendering it takes longer than the SoftwarePathRenderer.
BUG=skia:2935
Review URL: https://codereview.chromium.org/677463002
2014-10-24 07:12:51 -07:00
mtklein
afc9b6ec95
squelch filterindiabox too
...
TBR=bsalomon@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/677463003
2014-10-23 15:24:11 -07:00
senorblanco
cbf6b6ecd5
Fix imagemagnifier GM quality and speed.
...
The imagemagnifier GM was applying the filter both to a saveLayer()
restore() around the whole scene, as well as to each individual
text draw.
Applying the filter only in the saveLayer() makes it run ~20x faster
on my Linux box, and the quality is improved as well (since the
primitives are not double-filtered).
BUG=skia:
Review URL: https://codereview.chromium.org/637283009
2014-10-23 15:00:12 -07:00
mtklein
14e4d392d4
Revert "Revert of create shaderproc for nofilter-opaque-dx (patchset #7 id:120001 of https://codereview.chromium.org/664783004/ )"
...
This reverts commit 430b795cc8
and adds suppressions.
BUG=skia:
Review URL: https://codereview.chromium.org/673023002
2014-10-23 14:35:01 -07:00
bsalomon
efd7d45fc0
Don't use MIP filter mode on compressed textures
...
Add compressed texture image downsample GMs
BUG=chromium:426331
Review URL: https://codereview.chromium.org/672863003
2014-10-23 14:17:46 -07:00
senorblanco
c4d619e145
Remove test expectations from ignored-tests.txt.
...
TBR=mtklein@google.com
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/659393006
2014-10-23 14:01:38 -07:00
sugoi
234f036b3e
Adding an option to render only the shadow in SkDropShadowImageFilter
...
This is basically how blink uses the filter. Currently, I can't use it for "ShadowOnly" mode with the filter at all, but instead of copying the code and risking to have the codepaths diverge, I'm simply going to add the option here.
BUG=skia:
Review URL: https://codereview.chromium.org/646213004
2014-10-23 13:59:52 -07:00
senorblanco
d0777fd2cf
Rebaselines for tests affected by image filter PDF change.
...
(aka https://codereview.chromium.org/644323006/ )
TBR=mtklein@google.com
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/671303003
2014-10-23 13:50:54 -07:00
joshualitt
99db3b1308
some more expectations, update ignores
...
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/668393002
2014-10-22 20:23:08 -07:00
joshualitt
9292fafd4a
one more test to ignore
...
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/674713002
2014-10-22 17:52:31 -07:00
joshualitt
5ead6da4ab
Oval and stroke AA rect now batch
...
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/bc54fab1a4e5b51628a8c1557c62bc74e078870d
Committed: https://skia.googlesource.com/skia/+/18055afb838a278b5a8436cd51dbfbb688e1e0a0
Review URL: https://codereview.chromium.org/664193002
2014-10-22 16:00:30 -07:00
joshualitt
67f7f74fb2
Revert of Oval and stroke AA rect now batch (patchset #7 id:110001 of https://codereview.chromium.org/664193002/ )
...
Reason for revert:
whoops, accidental commit
Original issue's description:
> Oval and stroke AA rect now batch
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/bc54fab1a4e5b51628a8c1557c62bc74e078870d
>
> Committed: https://skia.googlesource.com/skia/+/18055afb838a278b5a8436cd51dbfbb688e1e0a0
TBR=robertphillips@google.com ,bsalomon@google.com,joshualitt@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/675623002
2014-10-22 15:51:52 -07:00
joshualitt
18055afb83
Oval and stroke AA rect now batch
...
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/bc54fab1a4e5b51628a8c1557c62bc74e078870d
Review URL: https://codereview.chromium.org/664193002
2014-10-22 15:48:48 -07:00
mtklein
9deb696f58
Revert of Oval and stroke AA rect now batch (patchset #7 id:110001 of https://codereview.chromium.org/664193002/ )
...
Reason for revert:
Many GMs failing, e.g. http://build.chromium.org/p/client.skia.android/builders/Test-Android-Nexus5-Adreno330-Arm7-Release/builds/95/steps/Compare%20GMs/logs/stdio
Original issue's description:
> Oval and stroke AA rect now batch
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/bc54fab1a4e5b51628a8c1557c62bc74e078870d
TBR=robertphillips@google.com ,joshualitt@google.com,bsalomon@google.com,joshualitt@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/671993003
2014-10-22 15:23:29 -07:00
joshualitt
bc54fab1a4
Oval and stroke AA rect now batch
...
BUG=skia:
Review URL: https://codereview.chromium.org/664193002
2014-10-22 14:41:45 -07:00