borenet
2c3112d517
[recipes] Increase test coverage
...
Remove a bunch of "pragma: no cover" by removing unused code or adding test bots to cover.
BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2215443003
Review-Url: https://codereview.chromium.org/2215443003
2016-08-05 06:30:10 -07:00
borenet
e2251acbaa
[recipes] Separate builder_spec into compile/test/perf recipes
...
BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2205473002
Review-Url: https://codereview.chromium.org/2205473002
2016-08-05 05:40:59 -07:00
borenet
d460a3c256
[recipes] Remove build environment vars from default_env
...
BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2209423002
Review-Url: https://codereview.chromium.org/2209423002
2016-08-05 05:18:06 -07:00
msarett
b8d1aac87a
Create a separate src for colorspace tests
...
This will allow me to run these tests in sRGB mode, while
leaving most of the image tests disabled.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2206953006
Review-Url: https://codereview.chromium.org/2206953006
2016-08-04 12:22:06 -07:00
borenet
3f5a47599b
[recipes] Fixes for Coverage bot
...
BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2217523002
Review-Url: https://codereview.chromium.org/2217523002
2016-08-04 12:16:03 -07:00
borenet
c7233ef925
[recipes] Stop pretending that buildbot_spec is a step, simplify
...
Since we no longer have to call out to obtain the buildbot_spec, merge
the two functions in vars API. As a side effect, this applies
default_env to the sync steps as well, which shouldn't have an
appreciable effect on bot behavior.
BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2209343002
Review-Url: https://codereview.chromium.org/2209343002
2016-08-04 11:33:02 -07:00
borenet
538d5b68e8
Move builder_spec, [dm|nanobench]_flags, builder_name_schema to recipes
...
- builder_name_schema becomes its own recipe module.
- builder_spec, dm, and nanobench flags move into vars module.
- recipe expectation diffs include:
- no more buildbot_spec.py step
- "real" dm and nanobench flags, instead of --dummy-flags
- some inconsequential stuff in visualbench, which is removed anyway.
BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2215803002
Review-Url: https://codereview.chromium.org/2215803002
2016-08-04 11:07:10 -07:00
borenet
bc20a701d8
[Recipes] Move test and perf steps into test and perf recipes
...
This looks like another big change, but I really just moved blocks of code around. Again, no expectations diffs because no behavior is changed.
BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2198973002
Review-Url: https://codereview.chromium.org/2198973002
2016-08-03 10:38:44 -07:00
borenet
9e3d3d8b36
Fix fake_specs.py, update recipe expectation
...
BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2200763002
Review-Url: https://codereview.chromium.org/2200763002
2016-08-03 10:10:07 -07:00
borenet
1436a09e1f
Re-organize Skia recipes
...
Break Skia recipe module into:
- skia_vars: defines and stores variables (eg. paths)
- skia_step: utilities for running Skia steps
- skia_flavor: flavor-specific stuff
- skia: top-level setup, checkout, test/perf steps, etc etc
This establishes a saner dependency structure for the recipes; skia_vars
is at the bottom level, skia_step depends on it, skia_flavor depends on
both of them, skia depends on all of the above, and the recipes
themselves may depend on any or all of them.
Next steps:
- Merge buildbot_spec into skia_vars
- Move test_steps and perf_steps from skia recipe_module into
swarm_test and swarm_perf recipes
- Cleaner checkout_steps process
BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2198173002
Review-Url: https://codereview.chromium.org/2198173002
2016-08-03 08:23:10 -07:00
borenet
b6aafe66a0
Fix Chrome build for RecreateSKPs and CommandBuffer bots for GYP->GN
...
BUG=skia:5597
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2199273002
Review-Url: https://codereview.chromium.org/2199273002
2016-08-02 07:02:52 -07:00
borenet
ed696276fd
More fixes for SwarmBucket
...
BUG=skia:5581
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2202053005
NOTRY=true
Review-Url: https://codereview.chromium.org/2202053005
2016-08-02 06:50:50 -07:00
borenet
d6dd44140d
Roll recipe DEPS
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2205863002
Review-Url: https://codereview.chromium.org/2205863002
2016-08-02 05:11:16 -07:00
borenet
f5b675efbe
Stop running nanobench on Test.*Debug bots
...
We'll need to add Perf.*Debug bots to achieve the same coverage.
BUG=skia:4768
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2189393002
NOTREECHECKS=true
Review-Url: https://codereview.chromium.org/2189393002
2016-08-01 05:08:52 -07:00
jcgregorio
01f696e30f
perf: Upload results to gs://skia-perf, not gs://chromium-skia-gm.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2197643002
Review-Url: https://codereview.chromium.org/2197643002
2016-07-29 10:54:30 -07:00
mtklein
830c913625
GN: ccache+clang needs -Qunused-arguments
...
An alternative is to define CCACHE_CPP2, but
I thought I'd try this more visible way first.
(CCACHE_CPP2 may turn out to be required anyway
if we start seeing warnings about tautological compares.)
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2193203002
TBR=jcgregorio@google.com
NOTRY=true
Review-Url: https://codereview.chromium.org/2193203002
2016-07-29 06:03:52 -07:00
mtklein
2a1134e3f5
GN: Always quote cc and cxx.
...
To fix:
ERROR at the command-line "--args":1:34: Unexpected token '+'
is_debug=true cc=clang cxx=clang++
TBR=jcgregorio@google.com
NOTRY=true
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2193593003
Review-Url: https://codereview.chromium.org/2193593003
2016-07-29 05:39:35 -07:00
mtklein
9081ceb123
GN: use ccache if available and the requested compiler.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2186553006
Review-Url: https://codereview.chromium.org/2186553006
2016-07-29 05:07:39 -07:00
jcgregorio
50d1847815
Fix expectations for GN bot.
...
BUG=skia:
Review-Url: https://codereview.chromium.org/2191933002
2016-07-28 11:55:51 -07:00
borenet
f49d9d77bb
Add swarmbucket_wrapper recipe
...
BUG=skia:5581
NOTRY=true
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2185203003
Review-Url: https://codereview.chromium.org/2185203003
2016-07-28 10:50:54 -07:00
jcgregorio
ba59595ea3
recipes: Add a GN flavor.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2189713003
Review-Url: https://codereview.chromium.org/2189713003
2016-07-28 09:38:59 -07:00
borenet
9c18546b78
Fixes for SwarmBucket bot
...
- Print all build properties for debugging purposes.
- Use correct path root for swarmbucket.
- Write a dummy .gclient file if missing.
BUG=skia:5581
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2190933002
Review-Url: https://codereview.chromium.org/2190933002
2016-07-28 08:58:38 -07:00
borenet
151aee4220
Fix silently-failing compile
...
Ouch...
TBR=rmistry
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2191663002
Review-Url: https://codereview.chromium.org/2191663002
2016-07-27 14:05:54 -07:00
kjlubick
e772aeea08
Add Vulkan runtime dll
...
This gets copied into the out/ dir on compile and allows dm.exe to run anywhere, even if the Vulkan SDK is not installed.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2188543002
Review-Url: https://codereview.chromium.org/2188543002
2016-07-27 12:59:12 -07:00
borenet
b53a886924
Include "revision" tag for all Swarming tasks
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2186993002
Review-Url: https://codereview.chromium.org/2186993002
2016-07-27 09:36:17 -07:00
borenet
7b2ed4c649
Fix Perf data upload
...
BUG=skia:5563
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2187603005
Review-Url: https://codereview.chromium.org/2187603005
2016-07-27 08:51:55 -07:00
egdaniel
735109c248
Add gyp define to enable vulkan debug layers
...
On Debug vulkan bots, running with the debug layers on seems to be adding
more than an hour to the total running time. Since we suppress any output
on the bots anyways the debug layers are serving no purpose. Thus I am
adding a gyp define to disable the layers on the bot.
With this change, by default when running vulkan in Debug, the debug_layers
will be enabled. The bots should disable the layers. Android framework
should also have them disabled by default.
TBR=djsollen@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2185953003
Review-Url: https://codereview.chromium.org/2185953003
2016-07-27 08:03:57 -07:00
borenet
1ed2ae45f5
Move Skia recipes from build repo
...
BUG=skia:5563
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2175373002
Review-Url: https://codereview.chromium.org/2175373002
2016-07-26 11:52:17 -07:00