Commit Graph

2086 Commits

Author SHA1 Message Date
recipe-roller
2a59d8d05d Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/e660e3fb9abbe7c04be5ba54a92e0a52dc57dff1 Support target_arch for WindowsSDK (scottmg@chromium.org)
  https://crrev.com/c1e6594df5801603668f4dcea4473c78b08c9223 [roll-dep] Use Bug: instead of BUG= (iannucci@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I446f159adaa3923c30278692336cfaf879d21389
Reviewed-on: https://skia-review.googlesource.com/c/163482
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-10-18 18:35:34 +00:00
Leon Scroggins III
3abcd82356 Blacklist PNGs with CRC errors when using platform
The platform generators seem to leave memory uninitialized on these
files without reporting an error. Blacklist them so we do not get lots
of random images in Gold

Change-Id: If5f2b65d7a20c8a3c71716591d194556bdbf17a5
Reviewed-on: https://skia-review.googlesource.com/c/163254
Commit-Queue: Leon Scroggins <scroggo@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Auto-Submit: Leon Scroggins <scroggo@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-10-18 18:31:54 +00:00
skia-recreate-skps
8c653b9b1e Update go_deps asset
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I8d7956e062668e3491fd2afe602a005a6cbde8a4
Reviewed-on: https://skia-review.googlesource.com/c/163374
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2018-10-18 05:58:03 +00:00
recipe-roller
d0f4c394c0 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/488362624b6d263e7e59f5198f10216db1f284e6 metrics: Add a mechanism to notify users when we want to collect additional metrics. (ehmaldonado@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I388ee3cd4dd530a790337870cb0738adaf14320d
Reviewed-on: https://skia-review.googlesource.com/c/163245
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-10-18 02:37:58 +00:00
recipe-roller
5deda2e930 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/51bdf8c8dda4b8861e50be686fb3847606deba07 Reland "git cl: delete no longer used Rietveld methods." (tandrii@chromium.org)
  https://crrev.com/3e002fb86279bda61e475ab9224046152448830d git cl land: remove Rietveld-only options. (tandrii@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic50590f569cecf8a59d36594cd71f6006d5b2f98
Reviewed-on: https://skia-review.googlesource.com/c/163244
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-10-18 02:02:01 +00:00
recipe-roller
d296ebc9f2 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/4ac892e4d1266937a48f77a87bb4d16b86982230 Use lowercase machine architecture. (ehmaldonado@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia5513cc2b5ab62fb17e77aa2155fc2f330633604
Reviewed-on: https://skia-review.googlesource.com/c/163243
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-10-18 01:24:20 +00:00
recipe-roller
8982aa3754 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/1333933200c6a4885786cdf61f88ba49d7925510 bot_update: stop failing with a KeyError in the recipe on failure. (jbudorick@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iff8b62caec35ea05f952cbe9a788392a52556bdc
Reviewed-on: https://skia-review.googlesource.com/c/163221
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2018-10-17 19:43:01 +00:00
Kevin Lubick
f2a146c6ad [canvaskit] Add perf jobs
Of note, the perf results reported are not directly
comparable CPU->GPU because the GPU ones are likely
emulated (no real gpu in the Docker container on an
GCE VM).

Bug: skia:
Change-Id: I52259085f4d9e22c45b67f3e8ce1211a5c6c6d3e
Reviewed-on: https://skia-review.googlesource.com/c/163126
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-10-17 19:41:16 +00:00
skia-recreate-skps
64021dd2c2 Update go_deps asset
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Ie7b747e9b2fbca6d39f18e99c0b91b9e7d8c871f
Reviewed-on: https://skia-review.googlesource.com/c/163064
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2018-10-17 15:48:18 +00:00
skia-recreate-skps
583161c09a Update go_deps asset
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I2e4a0e55cba19866d9b0db63dda6437676f68594
Reviewed-on: https://skia-review.googlesource.com/c/163060
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2018-10-17 06:03:47 +00:00
recipe-roller
0a8faf3f55 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/63517c85fb961d6261a104f6cd92671fbec27b82 Add instructions to check for metrics collection. (ajp@chromium.org)
  https://crrev.com/08faab99d41bd4f1f727267586ff28a227f80cd3 Set unique build ID. (yyanagisawa@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iefeb9315db170578a079da1d035f515a3e7fb6d1
Reviewed-on: https://skia-review.googlesource.com/c/163000
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-10-17 01:57:00 +00:00
Hal Canary
4690c51ef5 SkQP-on-GCE: print exit status in logs
Change-Id: I74b03763e48184c43218422597828ac582566107
Reviewed-on: https://skia-review.googlesource.com/c/162741
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2018-10-17 01:21:34 +00:00
recipe-roller
9ad8b1e07f Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/b0b43f3a9e8fe333590a7134c7afebd84c10dc2b git-cl: Log response IP and host for Gerrit RPC failures. (ehmaldonado@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4e42614a0a4202898db90b4215172955344504b8
Reviewed-on: https://skia-review.googlesource.com/c/162824
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-10-16 23:38:50 +00:00
recipe-roller
f831b64ed4 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/1e488131ffcde9e4df573c9be3514c0cdc42d28b Revert "git cl: delete no longer used Rietveld methods." (tandrii@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic297316e55fcfdc66b78d30241954ce056343c82
Reviewed-on: https://skia-review.googlesource.com/c/162823
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2018-10-16 22:14:35 +00:00
Leon Scroggins III
6e45ce7e06 Fix uninitialized errors in SkPngCodec
- Initialize rowsDecoded in SkSampledCodec. Otherwise,
fillIncompleteImage may be called with an uninitialized
value. This change was originally uploaded to AOSP as
https://android-review.googlesource.com/c/platform/external/skia/+/785816
- If SkPngCodec hits an error, still transform from the
interlace buffer (if needed) and set rowsDecoded properly.
- Do not copy uninitialized memory from the interlace buffer.
- Make BRD treat kErrorInInput like kIncompleteInput. The two errors
are different for the purposes of incremental decode. For a direct
decode, they're essentially the same - part was decoded, but then
the decode was interrupted. This allows testing images with
errors on the bots without reporting a failure.
- Add some images to test incomplete pngs
  - errorInInput.png: color_wheel.png truncated with extra 0s at the
    end to trigger kErrorInInput
  - incInterlaced.png: basi3p02.png (from PNGSuite) similarly modified.
    This triggers kIncompleteInput. We have several incomplete PNGs that
    we are testing on the bots, but this is the first interlaced
  - errorInInputInterlaced.png: This is the same as incInterlaced with
    more zeroes at the end. The incorrect CRC (all zeroes) results in
    kErrorInInput


Change-Id: I25e1ea917e1c1ca212f104cb9d70290265a51b2d
Reviewed-on: https://skia-review.googlesource.com/c/161822
Commit-Queue: Leon Scroggins <scroggo@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-10-16 20:30:48 +00:00
recipe-roller
76d26edd27 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/f46a599f105746e2f0ce7068c630e312f2113893 [cipd] Do not assume that all packages have refs or tags. (iannucci@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I16a307f322c3c78f375ed6a4071bee2c42e703b6
Reviewed-on: https://skia-review.googlesource.com/c/162621
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-10-16 18:09:21 +00:00
Kevin Lubick
3d99b1e347 Add Correctness tests for CanvasKit
Also make a CPU only and GPU only build (although
the latter still has a lot of CPU logic).

Bug: skia:
Change-Id: I857c2300021c2adb5344865c28e4ad3e8d332954
Reviewed-on: https://skia-review.googlesource.com/c/162022
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-10-16 14:32:28 +00:00
Kevin Lubick
1bfcbb57e6 Blacklist tests for internal bot
Bug: skia:8470
Change-Id: Ia68223bde692873761dc320b4d3edbd5ff9ff585
Reviewed-on: https://skia-review.googlesource.com/c/162541
Reviewed-by: Eric Boren <borenet@google.com>
2018-10-16 14:13:20 +00:00
recipe-roller
a583a06f83 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/c68a1753c53a02b1bd292035e4a72a18e55814f3 git cl try-results: delete Rietveld support. (tandrii@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4194dad484ca1c957151f4311a93cbc7d79809d7
Reviewed-on: https://skia-review.googlesource.com/c/162445
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2018-10-16 07:45:33 +00:00
recipe-roller
5cb400d961 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/dd672fb3c5916a8ccd12593593c895c785c1cbe4 git cl description: rename gerrit test. (tandrii@chromium.org)
  https://crrev.com/b07575f6ab398b8b7efade4a470a4eea28b76b98 git cl: rename and relocate CreateDescriptionFromLog func. (tandrii@chromium.org)
  https://crrev.com/38d36a616db2bfd86379225cc45c981f89161ced git cl: delete no longer used Rietveld methods. (tandrii@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6ec48025564edbc982c8eb2374b6025bfdf6b703
Reviewed-on: https://skia-review.googlesource.com/c/162443
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2018-10-16 07:08:29 +00:00
recipe-roller
d115d18055 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/642641d03012ad1504e6bb6a385f819da9ba9e60 git cl comments: remove Rietveld support. (tandrii@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8cc52211805f9ff7ae7f050ddb4dd74f022d06ae
Reviewed-on: https://skia-review.googlesource.com/c/162442
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2018-10-16 06:38:12 +00:00
skia-recreate-skps
dd719ba309 Update go_deps asset
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Id11bfa7f333fa365580e486c1470dd8552d09cd8
Reviewed-on: https://skia-review.googlesource.com/c/162397
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2018-10-16 06:14:25 +00:00
recipe-roller
f600a54d3d Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/feec80e97144d81bb6fc7d1c8c9e4cb90019f4bc git cl: no longer support --rietveld flag when forcing codereview. (tandrii@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I80d0c87346425f2f603bf6df7e016fd5e22a71cc
Reviewed-on: https://skia-review.googlesource.com/c/162441
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2018-10-16 01:51:31 +00:00
recipe-roller
3a47c2d2ed Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/7d7bbc3b530f11eec8fa347d330c16006390cd65 git cl upload: delete no longer supported flags. (tandrii@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id92522618a2bfb7f7e48f998607f35909c41744f
Reviewed-on: https://skia-review.googlesource.com/c/162281
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2018-10-15 19:59:05 +00:00
Brian Salomon
0087c83a7c Make GrTextureOp disable filtering/aa in more cases.
Previously we didn't do this at all for multiple-texture ops.

Improve the test detecting when filtering can be disabled.

Make draw_image_set GM create tiles with pixel of overlap for correct
filtering.

Add draw_image_set_rect_to_rect to exercise filtering/aa disablement
in combination with tiling.

Makes SkGpuDevice filter out inverted src rects (as is done implicitly
in SkBaseDevice by relying on drawImageRect).

Puts GrTextureOp::fFilter in bitfield.

Change-Id: Iee96cb54d665877c7f4aee422a3a7af2b249b1d6
Reviewed-on: https://skia-review.googlesource.com/c/161641
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
2018-10-15 19:28:05 +00:00
recipe-roller
8df16d0d6b Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/2f727917ac2531cd26c4b4d4fc805398c0bbd132 git cl: add reviewers and ccs to git push command if possible. (tandrii@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic5ef88209aa8d5bdaaabf66000b8578ae98aded2
Reviewed-on: https://skia-review.googlesource.com/c/162161
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-10-15 18:04:20 +00:00
recipe-roller
f06bf17fc2 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/9f274436bd0d6eee2cf33ef5ef761f522fd1b5f7 git cl: partially remove Rietveld support for uploading code. (tandrii@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I2b5432894b514012189b0ca1792c6d121afb2b79
Reviewed-on: https://skia-review.googlesource.com/c/162038
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-10-15 17:24:50 +00:00
recipe-roller
646d917d3c Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/f5569d26086918a2bdb350e3d813c63a20de4017 git cl: start deleting Rietveld support. (tandrii@chromium.org)
  https://crrev.com/03da150665d9d5d57db62028dd53ac7f536f043e git cl: delete Rietveld support for tryjobs. (tandrii@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iafdcb2fb8163a18aeee363da5843912cf64bd481
Reviewed-on: https://skia-review.googlesource.com/c/161944
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2018-10-15 04:25:27 +00:00
recipe-roller
2b2c00f6ec Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/76988a8c5288791cf677d5cc20f35d44276e943a git cl: compute reviewers and ccs before pushing change to Gerrit. (tandrii@chromium.org)
  https://crrev.com/ba7b0a466d7dca239c1b34bd7242c815a97de016 git cl: find which reviewers and ccs are OK for Gerrit before upload. (tandrii@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I7d3e409333261424866a10edf713ad9320650e0a
Reviewed-on: https://skia-review.googlesource.com/c/161943
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-10-15 03:56:47 +00:00
skia-recreate-skps
681692726f Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: I8707e034915e39e26f4f7ec935ad75b6a2ad9c9e
Reviewed-on: https://skia-review.googlesource.com/c/161970
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2018-10-14 08:32:12 +00:00
skia-recreate-skps
23775a2e97 Update go_deps asset
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I6159a78330eb0f8fc15184323721d60eb5073f74
Reviewed-on: https://skia-review.googlesource.com/c/161966
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2018-10-14 05:52:02 +00:00
recipe-roller
7435f2553f Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/dd78844442fef7e3613f6896dbe325cffb495a66 git cl: bring label setting closer to git push in Gerrit case. (tandrii@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id7f086a281f18c8d40147ec14a5408eaf1055fc4
Reviewed-on: https://skia-review.googlesource.com/c/161941
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-10-13 18:29:01 +00:00
skia-recreate-skps
b28db529c8 Update go_deps asset
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I5854229edf2e6ba81690d8ca7a4ce8e8992e3b3f
Reviewed-on: https://skia-review.googlesource.com/c/161937
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2018-10-13 06:01:21 +00:00
recipe-roller
d38382d060 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/94faf3281c6a09958f685322a8c5e67daeb90fcf git cl upload: also explicitly use eu1 mirror for retries. (tandrii@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib58e186c4d3d03405dfa8e2a99042124f64a2c02
Reviewed-on: https://skia-review.googlesource.com/c/161832
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-10-12 22:08:34 +00:00
Kevin Lubick
3655e4059e Have BuildStats use Flutter's stripped lib
That's what their treemap says and we should try to match it.

Bug: skia:
Change-Id: Iefa95c0440eb6b45a94a72c1beffb8a1199152a4
Reviewed-on: https://skia-review.googlesource.com/c/161825
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-10-12 21:32:54 +00:00
Kevin Lubick
556350de37 Add Perf jobs for PathKit
We have a similar ingestion strategy to Gold.

I tried to use something off the shelf like benchmark.js
but passing the PathKit context into the benchmarks was
non-trivial. Plus, making a basic benchmarking tool
ended up being not too hard.

We should be able to re-use the docker container/aggregator
for CanvasKit too.

Bug: skia:
Change-Id: I613dfc58ea57c31cf71566a8ac55f8df9272ad25
Reviewed-on: https://skia-review.googlesource.com/c/161620
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Reviewed-by: Stephan Altmueller <stephana@google.com>
2018-10-12 19:50:04 +00:00
Kevin Lubick
a60a1945eb Add Vulkan to BuildStats-Mini
Bug: skia:
Change-Id: I320b7945e5e2939404e039cb83831b2bb408aaac
Reviewed-on: https://skia-review.googlesource.com/c/161842
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-10-12 18:37:37 +00:00
Kevin Lubick
3fc1c0dfaa Fix gold aggregator for pathkit
Bug: skia:
Change-Id: Ib54625fa54b0c07ee72b3bec9cf13a3e9556cdf8
Reviewed-on: https://skia-review.googlesource.com/c/161626
Reviewed-by: Stephan Altmueller <stephana@google.com>
2018-10-12 14:57:43 +00:00
skia-recreate-skps
75d36e5e28 Update go_deps asset
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I027b6c6582527262111ed9ebbb3463bb3ebb9e82
Reviewed-on: https://skia-review.googlesource.com/c/161765
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2018-10-12 05:49:23 +00:00
recipe-roller
2a13854464 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/dffa0b83f071c910d625955d6bb61335696e3a08 Add UUID recipe module (smut@google.com)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia77ee9ecda0d4d44abb88e58cf8baca6096db850
Reviewed-on: https://skia-review.googlesource.com/c/161702
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-10-11 23:21:19 +00:00
recipe-roller
a7b544cab5 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/47faa068e8ff935d4cc2cef4a4b1fb74b5e90cde git-cl: Make request to upload logs more visible. (ehmaldonado@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9220ef8ac5ae0ab74c52678b3511b39213841572
Reviewed-on: https://skia-review.googlesource.com/c/161681
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-10-11 20:17:25 +00:00
Brian Osman
38a62bdf64 Remove obsolete checks about colorType and colorSpace
Also remove the unit tests that were enforcing those rules,
and the blacklist of that unit test.

Bug: skia:
Change-Id: I802c9e81a412fe0b19d02f9224b801f4fbd901f2
Reviewed-on: https://skia-review.googlesource.com/c/161562
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: Brian Osman <brianosman@google.com>
2018-10-11 19:38:53 +00:00
Robert Phillips
9945f76cd8 Add "--reduceOpListSplitting" to more bots
Change-Id: Id9e86327bf85f766fac67704078e00bac4af346d
Reviewed-on: https://skia-review.googlesource.com/c/161422
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-10-11 16:42:21 +00:00
skia-recreate-skps
932759e9b4 Update go_deps asset
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Ibfe78cc9a9c42f940421dc26d42d9410835a4dc5
Reviewed-on: https://skia-review.googlesource.com/c/161342
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2018-10-11 05:38:02 +00:00
recipe-roller
6187f09dcf Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/2fddb95698211db1373ebe2b16091a54eac51c9c [git recipe_module] Add tags flag for fetch (hinoka@google.com)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I09e1e6e522db8dc5330b225f66b2720ad96cfd83
Reviewed-on: https://skia-review.googlesource.com/c/161145
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-10-10 19:23:31 +00:00
Robert Phillips
8505a0a842 Add --reduceOpListSplitting to a swath of bots
Change-Id: I92ea1b75bc72515d55bd753d42a6bfa0e701829e
Reviewed-on: https://skia-review.googlesource.com/c/161045
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-10-10 18:21:24 +00:00
Kevin Lubick
37baac128f Remove old code size analysis
Was replaced with:
https://skia-review.googlesource.com/c/skia/+/160220
https://skia-review.googlesource.com/c/skia/+/160765
https://skia-review.googlesource.com/c/skia/+/160920

Bug: skia:
Change-Id: Ia87f4d548cd33dcd6c21c3711aef65ac2dab9f60
Reviewed-on: https://skia-review.googlesource.com/c/160940
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-10-10 14:25:17 +00:00
Kevin Lubick
2626104520 Track Skia's Code size in Flutter
This creates a nice readable display, since Bloaty
doesn't allow filtering through the CLI.

Additionally, rename the flutter job to accurately
represent what settings it actually is (32 bit ARM built
with clang).

Bug: skia:
Change-Id: Iaed313caf43a31105adc8c85c545cc6cb2bcbe30
Reviewed-on: https://skia-review.googlesource.com/c/160920
Reviewed-by: Mike Klein <mtklein@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-10-10 14:24:57 +00:00
skia-recreate-skps
f5a0921474 Update go_deps asset
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Id359fe42939bcb91ee4e087d52280f470af9c81c
Reviewed-on: https://skia-review.googlesource.com/c/161000
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2018-10-10 05:49:33 +00:00
recipe-roller
a38ab3b094 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/83bd7f4cd5fa45c7b2b8a9187d3c3d3c13525621 git-cl: Print response headers on 404 Gerrit RPC status. (ehmaldonado@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie8bd678e65d32e2cbaccc706e594e785ec8a492e
Reviewed-on: https://skia-review.googlesource.com/c/160902
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-10-10 01:10:52 +00:00