Commit Graph

124 Commits

Author SHA1 Message Date
Ben Wagner
29380bdd56 Remove carriage returns.
Also add a presubmit so they don't get added to source code.

Change-Id: I6a85c6a934b1068a63646a0dcc0d3a08baa96ced
Reviewed-on: https://skia-review.googlesource.com/57110
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2017-10-09 20:41:14 +00:00
Ben Wagner
9fb285e322 Switch many jobs to Clang.
No-Try: true
Change-Id: Ie255d46ff50d13d25d045791c1c3066f06ab9243
Reviewed-on: https://skia-review.googlesource.com/53601
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2017-10-03 16:17:19 +00:00
Ben Wagner
9d5b100d87 Fix job name in PRESUBMIT.py.
Job was removed in https://skia-review.googlesource.com/c/skia/+/46306

No-Try: true
Change-Id: I1c6e1a25c7395c27401811cdca653ee49d5e64e6
Reviewed-on: https://skia-review.googlesource.com/52762
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-09-28 17:26:37 +00:00
Eric Boren
8e0c2c9832 Manually roll recipe DEPS
Bug: skia:
Change-Id: I55641aa4bef5a7ac863e3aae3d2902ef408f0384
Reviewed-on: https://skia-review.googlesource.com/52121
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2017-09-27 17:24:38 +00:00
Ravi Mistry
6f0751e50f Fix behavior of automatically adding 'Cq-Include-Trybots' in presubmit
NoTry: true
Bug: skia:7041
Change-Id: I4660db5e9526b29e2135bf4d5f0d134f1f9a5dce
Reviewed-on: https://skia-review.googlesource.com/45880
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2017-09-12 18:06:35 +00:00
Ravi Mistry
a70cb8ae9b Add checks for 'DO NOT''SUBMIT' in description and file content
NoTry: true
Bug: skia:
Change-Id: I5ce8c40a7deae690b04e7fbe4ac22fa63888ffc7
Reviewed-on: https://skia-review.googlesource.com/45882
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-09-12 18:02:20 +00:00
Eric Boren
47f0709aac Update CQ extra trybots after switch to Debian
Bug: skia:
Change-Id: I6611638097b473d719106c239012b5382d962941
Reviewed-on: https://skia-review.googlesource.com/21266
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-06-29 19:35:40 +00:00
Ravi Mistry
355feabac2 Use Gerrit style format for footers in Presubmit
This also fixes a bug where CQ keywords were added multiple times because it was
looking for them in the wrong place (new_description_lines instead of the footers).

Bug: skia:6667
Change-Id: I91232297343145884b3fe7c2e923373679cf029e
Reviewed-on: https://skia-review.googlesource.com/17704
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-05-23 20:44:36 +00:00
Ravi Mistry
ee06ffe455 Separate lines added via post upload from original description
BUG=skia:6598
NOTRY=true

Change-Id: I23fa415788e91da01d33ab3ab912aa420636574c
Reviewed-on: https://skia-review.googlesource.com/15869
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2017-05-08 17:05:11 +00:00
Ravi Mistry
9bbed5ecd0 Revert "Presubmit: ensure empty line between CL title and description"
This reverts commit 9518830650.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Presubmit: ensure empty line between CL title and description
> 
> Bug: skia:
> Change-Id: If1b2d655e9be4b960f76d2d17ce1cf1126f7b2d4
> Reviewed-on: https://skia-review.googlesource.com/15624
> Reviewed-by: Eric Boren <borenet@google.com>
> Commit-Queue: Eric Boren <borenet@google.com>
> 

TBR=borenet@google.com,rmistry@google.com
NOTRY=true
# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I311ee790f152dbb8325214650838839f6821c995
Reviewed-on: https://skia-review.googlesource.com/15862
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-05-08 16:40:44 +00:00
Eric Boren
9518830650 Presubmit: ensure empty line between CL title and description
Bug: skia:
Change-Id: If1b2d655e9be4b960f76d2d17ce1cf1126f7b2d4
Reviewed-on: https://skia-review.googlesource.com/15624
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2017-05-05 17:42:26 +00:00
Eric Boren
bf17eecf46 Change PRESUBMIT.py to use [Get|Update]DescriptionLines
This should fix the "git cl upload" failures on the recipe roller.

Change-Id: I1c433a5a6dc7f52034bef8b2178b3041b8f4661e
Reviewed-on: https://skia-review.googlesource.com/11020
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2017-04-05 12:49:32 +00:00
Mike Klein
160907f8de Clean up more references to GYP.
Delete files only used by GYP, and files that used GYP.  Neither can
possibly be actively used.  Beyond that, just a couple doc tweaks.

Change-Id: I0220d7226e7bb9ed7c54a7d8f2906a718313c521
Reviewed-on: https://skia-review.googlesource.com/8062
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Hal Canary <halcanary@google.com>
2017-02-06 17:55:35 +00:00
Ravi Mistry
fbff329787 Add hcm@ to public API owners
BUG=skia:
NOTRY=true

Change-Id: I4d54591db0d50ceca02a87868fd125309bd4531e
Reviewed-on: https://skia-review.googlesource.com/7275
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Mike Reed <reed@google.com>
2017-01-19 17:36:06 +00:00
Ravi Mistry
8c6a43a1c0 Do not use post upload hooks for 'GOLD_TRYBOT_URL'
That information will be provided via a plugin soon.

# This code is not exercised by trybots.
NOTRY=true
BUG=skia:6000

Change-Id: I6ea60783c0581e32317a781e4349e95b38b71da0
Reviewed-on: https://skia-review.googlesource.com/5207
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2016-11-23 18:34:23 +00:00
Eric Boren
508313064b [nobuildbot] Migrate all Linux GCE bots
BUG=skia:

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4994

Change-Id: Ib63f36b3803117d5357c8e70c572653afd151abe
Reviewed-on: https://skia-review.googlesource.com/4994
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2016-11-23 14:49:14 +00:00
Mike Klein
a5fb6157e5 Split SkSL and utils apart again into .gni files.
Also extend GN format presubmit check to .gni files.

BUG=skia:

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3976

Change-Id: I292f3136437101e3e2c3271e260536ab7a24b192
Reviewed-on: https://skia-review.googlesource.com/3976
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 18:56:37 +00:00
borenet
2dbbfa5d37 Add infra_tests.py, recipe, buildbotless bot
Have the presubmit (upload) run infra_tests.py if anything in infra/ changed.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2415193002

Review-Url: https://codereview.chromium.org/2415193002
2016-10-14 06:32:09 -07:00
Mike Klein
7a1c53d0f6 Fix GN formatting presubmit on Windows.
BUG=skia:

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3182

Change-Id: I6e19b18d6851516357f71930e406b9fb324ea81f
Reviewed-on: https://skia-review.googlesource.com/3182
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Reviewed-by: Herb Derby <herb@google.com>
2016-10-11 18:13:17 +00:00
Ravi Mistry
dbb84c268b Fix public API msg in PRESUBMIT.py
BUG=skia:5825

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2989

Change-Id: Ia074ab00ccd1500bee10a5b313636581e8265461
Reviewed-on: https://skia-review.googlesource.com/2989
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2016-10-05 17:08:55 +00:00
Ravi Mistry
39eabb6ccb PRESUBMIT.py improvements
* Updated code to check for owners in reviewers for Gerrit issues instead for in the TBR= line.
* The previous TBR parsing code was not accounting for adding comments. Eg: "TBR=rmistry (Testing only)".

BUG=skia:5825

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2981

Change-Id: I910a3ae71a9f57c14f80c0b0404041cbe451a77c
Reviewed-on: https://skia-review.googlesource.com/2981
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2016-10-05 16:38:38 +00:00
borenet
60b0a2d85c Add --test to gen_tasks.go, add presubmit check
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2392083002

Review-Url: https://codereview.chromium.org/2392083002
2016-10-04 12:45:41 -07:00
mtklein
9f262811b7 To prep for removing CMake bots, take them off the CQ and presubmit.
GN is now far more capable than our CMake builds.
Time to officially end that experiment.

Reminder how this lands:
  1) this CL
  2) remove the bots from the masters
  3) remove the CMake recipe files
  4) remove the CMake files

I'm willing to wait on 4) until we can do GN -> CMake generation, but I don't want the bots to hold us back.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2350073002

Review-Url: https://codereview.chromium.org/2350073002
2016-09-19 09:08:07 -07:00
rmistry
07f0446e9a Fix PostUploadHook for Gerrit issues
A gerrit change must contain the "Change-Id" at the end. This CL strips
out the changeId from the description and adds it back in at the end.

BUG=skia:5676
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2299303002
NOTRY=true

Review-Url: https://codereview.chromium.org/2299303002
2016-09-01 13:36:31 -07:00
rmistry
db0283bec9 Enable Gerrit support in Skia's PostUploadHook
BUG=skia:5676
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2299203002
NOTRY=true

Review-Url: https://codereview.chromium.org/2299203002
2016-09-01 09:54:01 -07:00
rmistry
b9a9e8788f Use methods from depot_tool's Changelist object instead of Rietveld RPC
This will make support for both Gerrit and Rietveld easier.

BUG=skia:5676
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2307593002
NOTRY=true

Review-Url: https://codereview.chromium.org/2307593002
2016-09-01 09:52:32 -07:00
mtklein
04fff6373e Fix up presubmit for SAN GCC->Clang fix.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2302553002

Review-Url: https://codereview.chromium.org/2302553002
2016-08-31 12:43:14 -07:00
rmistry
b398ecc2a4 Add Gerrit API support to Skia's PRESUBMIT.py
Also skip post upload hooks for Gerrit.

BUG=skia:5674
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2281123002

Review-Url: https://codereview.chromium.org/2281123002
2016-08-29 08:13:29 -07:00
mtklein
d434b01c7e Roll GN: gn format is --in-place by default
As usual, might as well roll, and this new behavior is a small convenience.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2231833002

Review-Url: https://codereview.chromium.org/2231833002
2016-08-10 07:30:58 -07:00
mtklein
4db3b7969f Require gn format in presubmit
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2203283003

Review-Url: https://codereview.chromium.org/2203283003
2016-08-03 14:18:23 -07:00
mtklein
3da80f5ecd Only run recipe simulation tests if infra/ changes.
This should lessen the need for mortals to have coverage.py,
and saves 1.8s (of 3.6s) on my desktop for this non-infra change.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2187713002

Review-Url: https://codereview.chromium.org/2187713002
2016-07-27 04:14:07 -07:00
borenet
1ed2ae45f5 Move Skia recipes from build repo
BUG=skia:5563
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2175373002

Review-Url: https://codereview.chromium.org/2175373002
2016-07-26 11:52:17 -07:00
rmistry
d8f0988b34 Specifying master names with "master." prefix is deprecated
NOTRY=true
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2151623002

Review-Url: https://codereview.chromium.org/2151623002
2016-07-13 12:57:42 -07:00
rmistry
3b3ee20d93 Do not use the deprecated CQ_EXTRA_TRYBOTS
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2135063003

Review-Url: https://codereview.chromium.org/2135063003
2016-07-11 08:27:49 -07:00
rmistry
d88b0bec43 Fix Gold trybot results URL
BUG=skia:5324
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=1996103002

Review-Url: https://codereview.chromium.org/1996103002
2016-05-20 03:50:01 -07:00
mtklein
bb5f309bce 10.9 is no more
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1732353002

Review URL: https://codereview.chromium.org/1732353002
2016-02-25 06:52:18 -08:00
borenet
d9fa758292 Port Skia recipe to normal Python scripts, move to Skia repo
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1703663002

Review URL: https://codereview.chromium.org/1703663002
2016-02-18 08:05:48 -08:00
rmistry
11f457e162 Add link to Gold trybot runs in every uploaded Skia CL
BUG=skia:4433
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1521913005

Review URL: https://codereview.chromium.org/1521913005
2015-12-15 06:23:33 -08:00
halcanary
6950de6c41 Comments Style: s/skbug.com/bug.skia.org/
DOCS_PREVIEW= https://skia.org/?cl=1432503003

Review URL: https://codereview.chromium.org/1432503003
2015-11-07 05:29:00 -08:00
mtklein
ab8296b48a Automatically add TSAN bots to the CQ for changes affecting SkAtomics.h
BUG=skia:

Review URL: https://codereview.chromium.org/1396523002
2015-10-07 11:49:00 -07:00
rmistry
5827653e42 Automatically add extra CQ trybots for predetermined paths
If the CL does not contain a "CQ_EXTRA_TRYBOTS=" section then it constructs one from the paths modified in your CL.

If you already have an existing "CQ_EXTRA_TRYBOTS=" section in your CL then it parses it, preserves your options, and only adds the builders and masters that were missing.

Also ensures no trybots are repeated (i.e. each master trybot combination only shows up once).

And I killed the hashtags feature in this CL, nobody was using it.

BUG=skia:4364

Review URL: https://codereview.chromium.org/1383743002
2015-10-01 08:24:03 -07:00
rmistry
9806d4ded5 Resolve TODOs in PRESUBMIT.py
BUG=skia:

Review URL: https://codereview.chromium.org/1384453004
2015-10-01 08:10:54 -07:00
mtklein
bda1267770 update presubmit to know about include/private
BUG=skia:4126

Review URL: https://codereview.chromium.org/1259953004
2015-07-28 08:54:12 -07:00
Mike Klein
478c9e4851 Revert "Move headers used by headers in include/ to include/private."
This reverts commit 928e16565f.

BUG=skia:

Review URL: https://codereview.chromium.org/1213093004.
2015-07-01 16:35:59 -04:00
mtklein
928e16565f Move headers used by headers in include/ to include/private.
Some of this is transitive, like SkRecords.h used by SkMiniRecorder.h
used by (public) SkPictureRecorder.h.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/a89f55198bdc58f0b6f6196907ab25a6afc1a661

Review URL: https://codereview.chromium.org/1217293004
2015-07-01 11:55:42 -07:00
jvanverth
4417c7f8bb Revert "Move headers used by headers in include/ to include/private."
This reverts commit a89f55198b.

Reason: breaking the roll.

TBR=mtklein@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1216033008
2015-07-01 09:45:46 -07:00
mtklein
a89f55198b Move headers used by headers in include/ to include/private.
Some of this is transitive, like SkRecords.h used by SkMiniRecorder.h
used by (public) SkPictureRecorder.h.

BUG=skia:

Review URL: https://codereview.chromium.org/1217293004
2015-07-01 08:41:15 -07:00
borenet
af6005c8a2 Presubmit: add PRESUBMIT=false to non-master branch changes
BUG=skia:

Review URL: https://codereview.chromium.org/1161973005
2015-06-04 15:15:42 -07:00
mtklein
e4b19c4593 Add presubmit to run {dm,nanobench}_flags.py test when changed.
BUG=skia:

Review URL: https://codereview.chromium.org/1129443005
2015-05-05 10:28:44 -07:00
rmistry
04abf130bb Bypass owners check for dry run CLs.
BUG=skia:
NOTRY=true

Review URL: https://codereview.chromium.org/1068853002
2015-04-07 07:41:51 -07:00
rmistry
57291dcc95 Find the HASHTAGS file even if you are not at the checkout root.
The post upload hook was failing if you were not at the root, this fixes it.

NOTRY=true

Review URL: https://codereview.chromium.org/1058483002
2015-04-01 09:12:51 -07:00
rmistry
3cfd1ad6c7 Add post upload hook to substitute hashtags for their mapped text
BUG=skia:3586
NOTRY=true

Review URL: https://codereview.chromium.org/1004733009
2015-03-25 12:53:36 -07:00
mtklein
18e55800c6 More file types to check for (C).
- objective C++           (31)
 - objective C             (4)
 - C                       (2)
 - alternate C++ extension (1)
 - Go                      (1)

BUG=skia:

Review URL: https://codereview.chromium.org/1032143002
2015-03-25 07:21:20 -07:00
borenet
c7c91806e3 Add copyright check to PRESUBMIT
BUG=skia:1724

Review URL: https://codereview.chromium.org/1003363005
2015-03-25 04:47:02 -07:00
rmistry
f91b717a99 Ignore public API checks if COMMIT=false is in the description
BUG=skia:
NOTRY=true

Committed: https://skia.googlesource.com/skia/+/d1783aefcc0da86c5ff1d124c54704252d817621

Review URL: https://codereview.chromium.org/1006473002
2015-03-12 09:48:10 -07:00
mtklein
a10ea431cf Revert of Ignore public API checks if COMMIT=false is in the description (patchset id:80001 of https://codereview.chromium.org/1006473002/)
Reason for revert:
I cannot upload patches:

~/skia (skskp) $ git clu --bypass-hooks
++ git log -1 --pretty=%B
+ git cl upload -t update
Using 50% similarity for rename/copy detection. Override with --similarity.
Loaded authentication cookies from /Users/mtklein/.codereview_upload_cookies
Running presubmit upload checks ...

** Presubmit ERRORS **
Since the CL is editing public API, you must have an LGTM from one of: ('reed@chromium.org', 'reed@google.com', 'bsalomon@chromium.org', 'bsalomon@google.com', 'djsollen@chromium.org', 'djsollen@google.com')

Original issue's description:
> Ignore public API checks if COMMIT=false is in the description
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/d1783aefcc0da86c5ff1d124c54704252d817621

TBR=borenet@google.com,rmistry@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1005583002
2015-03-12 09:33:46 -07:00
rmistry
d1783aefcc Ignore public API checks if COMMIT=false is in the description
BUG=skia:

Review URL: https://codereview.chromium.org/1006473002
2015-03-12 08:43:22 -07:00
rmistry
01cbf6c467 Make presubmit check that #if or #ifdef does not come before includes.
BUG=skia:3362

Review URL: https://codereview.chromium.org/998273002
2015-03-12 07:48:40 -07:00
rmistry
896f3932c8 Automatically add NOTREECHECKS when uploading CLs from non master branches
These changes are possible due to the recently submitted depot_tools change
https://codereview.chromium.org/949273002/ ('Add ability to specify and run post upload hooks').

BUG=skia:

Review URL: https://codereview.chromium.org/963553002
2015-02-26 11:52:05 -08:00
rmistry
d223fb21d6 Automatically add a docs preview link and NOTRY=true when there are only docs changes.
These changes are possible due to the recently submitted depot_tools change
https://codereview.chromium.org/949273002/ ('Add ability to specify and run post upload hooks').

BUG=skia:3474

Review URL: https://codereview.chromium.org/960203002
2015-02-26 10:16:13 -08:00
rmistry
9407eceb27 PRESUBMIT should only check owners for the top level include directory
BUG=skia:1846
R=borenet@google.com

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/511503002
2014-08-26 14:00:55 -07:00
rmistry
f2d83caf13 Public API changes are allowed if an owner is TBR'ed.
The following TBR formats are supported:
* TBR=reed
* TBR=reed@google.com
* TBR=xyz,reed
* TBR=xyz,reed@google.com

BUG=skia:2870
R=borenet@google.com

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/504843003
2014-08-26 10:30:30 -07:00
rmistry
83fab4732a Adding djsollen to list of owners
(SkipBuildbotRuns)

BUG=skia:
R=djsollen@google.com

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/397813007
2014-07-18 05:25:57 -07:00
Eric Boren
bb0ef0a134 Use new common tools in Python scripts
BUG=skia:2682
R=rmistry@google.com

Review URL: https://codereview.chromium.org/330423004
2014-06-25 11:13:27 -04:00
commit-bot@chromium.org
745e08caf2 Check if the issue owner is in the AUTHORS file in PRESUBMIT.py
BUG=skia:2072
NOTRY=true
(SkipBuildbotRuns)

R=borenet@google.com, hcm@google.com

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/131293005

git-svn-id: http://skia.googlecode.com/svn/trunk@13277 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-03 14:18:32 +00:00
commit-bot@chromium.org
cfdc596227 Do not enforce the public API presubmit check for Revert CLs.
NOTRY=true

BUG=skia:2068
R=borenet@google.com

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/151573002

git-svn-id: http://skia.googlecode.com/svn/trunk@13270 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-31 17:33:04 +00:00
commit-bot@chromium.org
c249088061 Adding rmistry for emergency reverts.
(SkipBuildbotRuns)

TBR=
NOTRY=true
NOTREECHECKS=true
BUG=skia:

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/148583005

git-svn-id: http://skia.googlecode.com/svn/trunk@13212 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-01-28 01:52:49 +00:00
rmistry@google.com
fb4a68de43 If any change is made to the public API then make sure there is an LGTM from an owner.
This feature has been requested by reed@.

If no LGTM is found from an owner then the following msg is displayed:

** Presubmit ERRORS **
Since the CL is editing public API, you must have an LGTM from one of: ('reed@chromium.org', 'reed@google.com', 'bsalomon@chromium.org', 'bsalomon@google.com')

(SkipBuildbotRuns)

R=borenet@google.com

Review URL: https://codereview.chromium.org/22453004

git-svn-id: http://skia.googlecode.com/svn/trunk@10676 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-12 14:51:20 +00:00
rmistry@google.com
547012dc05 If the tree is closed then print information about contacting the sheriff.
The motivation for this CL is because it is not very obvious on how to submit when tree is closed in git.

Also added a section 'How to submit when tree is closed' in https://sites.google.com/site/skiadocs/developer-documentation/tree-sheriff

(SkipBuildbotRuns)
Review URL: https://codereview.chromium.org/13932026

git-svn-id: http://skia.googlecode.com/svn/trunk@8666 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-04-12 19:45:46 +00:00
rmistry@google.com
f6c5f75b3c Display prompt for caution only if it is an interactive shell.
Created to fix https://code.google.com/p/skia/issues/detail?id=1197 : Skia Commit Queue quits if the tree is in Caution.

(SkipBuildbotRuns)
Review URL: https://codereview.chromium.org/13325002

git-svn-id: http://skia.googlecode.com/svn/trunk@8446 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-29 17:26:00 +00:00
rmistry@google.com
713276b143 Presubmit should check that source files end in atleast one newline
Review URL: https://codereview.appspot.com/7193063

git-svn-id: http://skia.googlecode.com/svn/trunk@7399 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-25 18:27:34 +00:00
rmistry@google.com
c29934489f Display a warning prompt in presubmit if the tree status is in 'Caution'.
Example presubmit output:


Running presubmit upload checks ...

** Presubmit Warnings **
Tree state is: caution

***************
Please use caution in checkins
http://skia-tree-status-staging.appspot.com/banner-status?format=json
***************

There were presubmit warnings. Are you sure you wish to continue? (y/N):
Review URL: https://codereview.appspot.com/7200043

git-svn-id: http://skia.googlecode.com/svn/trunk@7337 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-23 14:35:58 +00:00
rmistry@google.com
6be0b4c63d Adding CheckChangeHasOnlyOneEol to upload and commit presubmit checks
Review URL: https://codereview.appspot.com/7151043

git-svn-id: http://skia.googlecode.com/svn/trunk@7247 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-17 14:50:59 +00:00
rmistry@google.com
8e3ff8cf0b Top-level presubmit script for Skia trunk that checks https://skia-tree-status.appspot.com/banner-status?format=json before a CL is committed.
gcl and git-cl will check for and run the presubmit script before you upload and/or commit your changes.
Review URL: https://codereview.appspot.com/7138046

git-svn-id: http://skia.googlecode.com/svn/trunk@7242 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-01-17 12:55:34 +00:00