Matt Sarett
922e5be6e2
Fixes for SkColorLookUpTable::interp3D
...
(1) Fix subtle comparison bug so we interpolate the proper tetrahedral.
(2) Add new comments - the clamp is necessary.
(3) SkCSXformPrintf requires an extra friend class to compile.
BUG:668784
Change-Id: Id1a5c561f23ccfe25e141b8490cddee4c2482326
Reviewed-on: https://skia-review.googlesource.com/5238
Reviewed-by: Robert Aftias <raftias@google.com>
Commit-Queue: Matt Sarett <msarett@google.com>
2016-11-29 21:48:09 +00:00
Eric Boren
cb4feeb7db
[nobuildbot] Win GCE bots
...
BUG=skia:
Change-Id: Id0d0319f68a1c6d970c13bb5b6006786ae04ffec
Reviewed-on: https://skia-review.googlesource.com/5265
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2016-11-29 12:05:31 +00:00
Eric Boren
b409c6ae56
[nobuildbot] Mac bots
...
BUG=skia:
Change-Id: I089a21941b65d4bb53e803c4d5081b26bda30f14
Reviewed-on: https://skia-review.googlesource.com/5210
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2016-11-28 12:22:43 +00:00
UpdateSKPs
064f8e2d70
Update SKP version
...
Automatic commit by the RecreateSKPs bot.
TBR=update-skps@skia.org
NO_MERGE_BUILDS
Change-Id: Ib3ea1f88ec5aaf0e11e23c127191653701a0793b
Reviewed-on: https://skia-review.googlesource.com/5219
Reviewed-by: update-skps <update-skps@skia.org>
Commit-Queue: update-skps <update-skps@skia.org>
2016-11-27 06:18:46 +00:00
UpdateSKPs
9c61682bba
Update SKP version
...
Automatic commit by the RecreateSKPs bot.
TBR=update-skps@skia.org
NO_MERGE_BUILDS
Change-Id: Ie281be52f150f3380090d91a83ed8f51afe58e4a
Reviewed-on: https://skia-review.googlesource.com/5215
Reviewed-by: update-skps <update-skps@skia.org>
Commit-Queue: update-skps <update-skps@skia.org>
2016-11-23 21:09:45 +00:00
Eric Boren
bd488f886d
[nobuildbot] Remaining (non-CT) Linux bots
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=5187
Change-Id: Ibce633b602623510f3c43cca2862a97b41d45b52
Reviewed-on: https://skia-review.googlesource.com/5187
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2016-11-23 19:08:31 +00:00
Eric Boren
508313064b
[nobuildbot] Migrate all Linux GCE bots
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4994
Change-Id: Ib63f36b3803117d5357c8e70c572653afd151abe
Reviewed-on: https://skia-review.googlesource.com/4994
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2016-11-23 14:49:14 +00:00
Eric Boren
628e78bf0b
[nobuildbot] Remaining Android devices
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4933
Change-Id: I4e38d25c37e6a336f90e46d2260fcbb4f9899901
Reviewed-on: https://skia-review.googlesource.com/4933
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2016-11-18 05:17:18 +00:00
Eric Boren
524f11a50a
[nobuildbot] More Android bots
...
- GalaxyS7
- NVIDIA_Shield
- Nexus10
- Nexus7
- Nexus9
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4915
Change-Id: Ie4fb27085fe154ddf15de4774de9932cde28e842
Reviewed-on: https://skia-review.googlesource.com/4915
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2016-11-17 03:04:20 +00:00
Kevin Lubick
cb67766851
Add vulkan build to skpbench.
...
This also fixes the name of the tasks because skpbench is always GPU.
There was a config for monitoring the gpu clock instead of the cpu clock,
but this was removed because the gpu clock isn't very useful at the moment.
cpu clock is basically wall-time, i.e. an accurate measurement of the
entire test.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4873
Change-Id: If1c7dd3141e24f79555ee7b3756f09618df54cb4
Reviewed-on: https://skia-review.googlesource.com/4873
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2016-11-16 19:36:50 +00:00
Eric Boren
860fc6662d
[nobuildbot] Nexus 5
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4870
Change-Id: Id8bcb72926155d8754e99e5ec5b3ae2461b22e0f
Reviewed-on: https://skia-review.googlesource.com/4870
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2016-11-16 12:15:34 +00:00
Eric Boren
f5a90e8a3f
[nobuildbot] RecreateSKPs
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4836
Change-Id: Idee05a4b1ea909c5dc1de2e9ebc8c2f9631c78e2
Reviewed-on: https://skia-review.googlesource.com/4836
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2016-11-15 22:52:06 +00:00
Eric Boren
f89aa0d254
[nobuildbot] Nexus 6p
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4788
Change-Id: I5049bd59eccfc3106991096652765b79c9dbaffd
Reviewed-on: https://skia-review.googlesource.com/4788
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2016-11-15 12:55:38 +00:00
Kevin Lubick
b03b5aca54
Add skpbench job
...
This entails a few parts:
1. Isolating tools/skpbench/ to be used by the perf task.
2. Adding skpbench to BUILD_PRODUCTS_ISOLATE_WHITELIST
3. Add recipe commands to run skpbench. While it is conceptually similar
to nanobench, it doesn't support images nor svgs, only skps, so we don't
need to copy those to devices or bring them in via CIPD.
4. Add recipe commands to parse skpbench output and upload to Perf.
5. Update gen_tasks.go to handle skpbench jobs and tasks.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4551
Change-Id: I09bf0b078067279e138e95eca9316e55539ec735
Reviewed-on: https://skia-review.googlesource.com/4551
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2016-11-14 20:34:04 +00:00
Matt Sarett
a354b04931
Add new A2B color space test images
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4763
Change-Id: I8972a4b31b2e284602e6f168d1d3ee20dcf537f1
Reviewed-on: https://skia-review.googlesource.com/4763
Reviewed-by: Matt Sarett <msarett@google.com>
Commit-Queue: Matt Sarett <msarett@google.com>
2016-11-14 17:28:54 +00:00
Eric Boren
1f2f64b4ce
[nobuildbot] Copy timeouts from swarm_trigger
...
BUG=skia:
TBR=benjaminwagner
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4642
Change-Id: Ia81609af8ae11c0171c99c459e8711fa786c1e20
Reviewed-on: https://skia-review.googlesource.com/4642
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2016-11-10 01:00:02 +00:00
Mike Klein
27dcee1643
Android builders do not need host toolchains.
...
This trims a few packages. We do the same in buildbot.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4634
Change-Id: I4c76d744917cb244ca3390d55d9ea602cda2dd58
Reviewed-on: https://skia-review.googlesource.com/4634
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-11-09 22:44:46 +00:00
Mike Klein
cb36f3cacf
auto-add Build jobs
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4639
Change-Id: I61acce39abf08c4307e5a7ec990ec8857539f943
Reviewed-on: https://skia-review.googlesource.com/4639
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-11-09 22:35:50 +00:00
Eric Boren
02201e73d6
[nobuildbot] AndroidOne bots
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4627
Change-Id: I9479ba49cc75f658b0cf0ac724c6462cb06598ea
Reviewed-on: https://skia-review.googlesource.com/4627
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2016-11-09 21:16:18 +00:00
Eric Boren
792079cf33
Change iOS bots to new-style, no-buildbot bots
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4582
Change-Id: Ied11c727a491382fce113b6e02831a67d944ca2f
Reviewed-on: https://skia-review.googlesource.com/4582
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Stephan Altmueller <stephana@google.com>
2016-11-09 19:53:04 +00:00
Eric Boren
4b254b9b95
gen_tasks.go: Implement TODOs, bring up to speed with swarm_trigger
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4547
Change-Id: Ia22a4836732dd33f30f4f6e4e49f5b39294ec53f
Reviewed-on: https://skia-review.googlesource.com/4547
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2016-11-08 19:21:29 +00:00
Mike Klein
6749af4073
Add GN iOS builder.
...
This gets up a bot to build for iOS via GN as much as we can right now. This is unlikely to be the long term structure of the iOS bots... by the time we add Test/Perf bots we'll likely need to have a gn_ios_flavor.py. But for now, this keeps the GN iOS build such as it is working.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4457
Change-Id: Ideb10ae3f4ab5530ad153237a343dd5c0e7dd02f
Reviewed-on: https://skia-review.googlesource.com/4457
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Eric Boren <borenet@google.com>
2016-11-07 21:20:18 +00:00
Matt Sarett
a225e9be53
Finish color space support for SkCodec
...
Implements color space xforms and F16 for SkRawCodec and SkWbmpCodec.
BUG=skia:4895
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4459
Change-Id: I8c72918e46387350b49a9811ce654d26b1ab352a
Reviewed-on: https://skia-review.googlesource.com/4459
Commit-Queue: Matt Sarett <msarett@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>
2016-11-07 16:00:11 +00:00
update-skps
301dfc0bba
Update SKP version
...
Automatic commit by the RecreateSKPs bot.
TBR=
NO_MERGE_BUILDS
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2482733002
Review-Url: https://codereview.chromium.org/2482733002
2016-11-06 01:05:03 -08:00
skia.buildbots
2478c73bb8
Make buildbotless trybots only support Gerrit
...
BUG=skia:5723
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4460
Change-Id: Ia5630de72f8b473551a5357fdf50eb3dd288b9a7
Reviewed-on: https://skia-review.googlesource.com/4460
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2016-11-04 22:09:21 +00:00
Matt Sarett
61eedebe4c
Add F16, SkColorSpaceXform support to SkGifCodec
...
BUG=skia:4895
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4396
Change-Id: I7c521760891852daf4f3933ecf02dc08acec64c0
Reviewed-on: https://skia-review.googlesource.com/4396
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Matt Sarett <msarett@google.com>
2016-11-04 20:55:16 +00:00
Matt Sarett
1b96c6f913
Add F16, SkColorSpaceXform support to SkBmpCodec
...
BUG=skia:4895
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4390
Change-Id: I9cb727e7f13816b0ac882f62ec635a4528c3a524
Reviewed-on: https://skia-review.googlesource.com/4390
Reviewed-by: Matt Sarett <msarett@google.com>
Commit-Queue: Matt Sarett <msarett@google.com>
2016-11-03 20:58:13 +00:00
Matt Sarett
6193568fed
Revert "Add F16, SkColorSpaceXform support to SkBmpCodec"
...
This reverts commit d851795e79
.
Reason for revert: <INSERT REASONING HERE>
Original change's description:
> Add F16, SkColorSpaceXform support to SkBmpCodec
>
> BUG=skia:4895
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4300
>
> Change-Id: I2f2b8d3854ea3a8c5904dd3c5bea0342e2be9789
> Reviewed-on: https://skia-review.googlesource.com/4300
> Reviewed-by: Leon Scroggins <scroggo@google.com>
> Commit-Queue: Matt Sarett <msarett@google.com>
>
Speculative revert for MSAN
TBR=borenet@google.com ,msarett@google.com,scroggo@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Change-Id: Ie48c03c0c3156267763fbcf96818477567c5069d
Reviewed-on: https://skia-review.googlesource.com/4378
Commit-Queue: Matt Sarett <msarett@google.com>
Reviewed-by: Matt Sarett <msarett@google.com>
2016-11-03 17:27:27 +00:00
Matt Sarett
d851795e79
Add F16, SkColorSpaceXform support to SkBmpCodec
...
BUG=skia:4895
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4300
Change-Id: I2f2b8d3854ea3a8c5904dd3c5bea0342e2be9789
Reviewed-on: https://skia-review.googlesource.com/4300
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Matt Sarett <msarett@google.com>
2016-11-03 16:33:33 +00:00
Mike Klein
0d1708e6b7
Run gen_tasks.go for new package version.
...
I'm learning...
TBR=borenet@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4367
Change-Id: I1ae6572b8c1b8722a738e0857bfd85be6640f312
Reviewed-on: https://skia-review.googlesource.com/4367
Reviewed-by: Mike Klein <mtklein@chromium.org>
2016-11-02 22:31:44 +00:00
Mike Klein
21f364df99
We don't need no SDK.
...
The buildbot bots don't use this package, so the buildbotless ones don't need it either.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4317
Change-Id: Ife1a31a8a33ea99a925834ddff13d4866eb52b6d
Reviewed-on: https://skia-review.googlesource.com/4317
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Eric Boren <borenet@google.com>
2016-11-02 20:11:31 +00:00
Mike Klein
e9215f0e24
Shorten android_ndk_windows to n to save some precious path budget.
...
We're going above 260 as-is.
If this doesn't work... hopefully we don't need any of the long-named files.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4316
Change-Id: I3074c28adfbd4fccb5230eaacf2d6f0c4980bbbe
Reviewed-on: https://skia-review.googlesource.com/4316
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Eric Boren <borenet@google.com>
2016-11-02 19:54:37 +00:00
Mike Klein
86c2c0f077
Add a Windows Android builder.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4320
Change-Id: Ifd693f5de978565f694bc0173a1248e705303e68
Reviewed-on: https://skia-review.googlesource.com/4320
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-11-02 17:35:47 +00:00
update-skps
09b007f0ef
Update SKP version
...
Automatic commit by the RecreateSKPs bot.
TBR=
NO_MERGE_BUILDS
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2461223002
Review-Url: https://codereview.chromium.org/2461223002
2016-10-30 02:12:18 -07:00
scroggo
2111633dc6
Upload an image that demonstrates issue 5883
...
This GIF is missing a color table. We should draw a blank frame. This
was fixed in crrev.com/2450943002 (DIFFERENT ISSUE). This image will
test this case.
BUG=skia:5883
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2452133003
Review-Url: https://codereview.chromium.org/2452133003
2016-10-27 14:23:00 -07:00
borenet
8a91da9459
Fix SKP version in tasks.json, make upload_skps.py update tasks.json
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2426863003
Review-Url: https://codereview.chromium.org/2426863003
2016-10-18 05:20:26 -07:00
borenet
5238343ab2
Add a buildbotless Android bot
...
BUG=skia:5626
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2428603002
Review-Url: https://codereview.chromium.org/2428603002
2016-10-17 10:17:53 -07:00
borenet
2dbbfa5d37
Add infra_tests.py, recipe, buildbotless bot
...
Have the presubmit (upload) run infra_tests.py if anything in infra/ changed.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2415193002
Review-Url: https://codereview.chromium.org/2415193002
2016-10-14 06:32:09 -07:00
borenet
55bc873e73
[task scheduler] Trybots assume rietveld for now
...
Eventually we'll switch to gerrit-only. Supporting both will probably be
more complicated than it's worth.
BUG=skia:5723
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2413653005
Review-Url: https://codereview.chromium.org/2413653005
2016-10-13 10:25:52 -07:00
borenet
98b2e7a9e4
Recipe fixes to support try jobs in task scheduler
...
BUG=skia:5723
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2410843002
Review-Url: https://codereview.chromium.org/2410843002
2016-10-13 06:23:45 -07:00
borenet
db182c770f
[task scheduler] Add gen_tasks.go
...
This mimics the flow of infra/bots/recipes/swarm_trigger.py
but it builds the tasks.json file instead of triggering the
actual tasks.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2386663002
Review-Url: https://codereview.chromium.org/2386663002
2016-09-30 12:53:12 -07:00
borenet
fbf23b80d0
[task scheduler] Add uploads to tasks.json
...
BUG=skia:5719
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2376713002
Review-Url: https://codereview.chromium.org/2376713002
2016-09-27 08:22:03 -07:00
borenet
50537e46e4
Add Jobs to tasks.json
...
BUG=skia:5723
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2363443002
Review-Url: https://codereview.chromium.org/2363443002
2016-09-22 05:09:56 -07:00
borenet
32799a45ec
[task scheduler] Fix CIPD package versions
...
BUG=skia:5626
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2301413003
Review-Url: https://codereview.chromium.org/2301413003
2016-09-02 12:16:56 -07:00
borenet
443c5843aa
[task scheduler] Add extra_args in tasks.json
...
NOTREECHECKS=true
BUG=skia:5626
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2301313002
Review-Url: https://codereview.chromium.org/2301313002
2016-09-02 08:58:38 -07:00
borenet
de3184fd84
Add infra/bots/tasks.json
...
This is an initial version which adds a trio of buildbot-less bots. I
expect these to be totally broken while I work out the issues.
In the future, we'll have a script to generate tasks.json.
BUG=skia:5626
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2302983002
Review-Url: https://codereview.chromium.org/2302983002
2016-09-01 12:32:23 -07:00