Commit Graph

20979 Commits

Author SHA1 Message Date
caryclark
a7b16858d5 remove legacy flags
R=fmalita@chromium.org
BUG=573166
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1707383002

Review URL: https://codereview.chromium.org/1707383002
2016-02-18 06:16:31 -08:00
caryclark
a110538912 fix asan error deref-ing null ptr
TBR=tomhudson@google.com
BUG=skia:4549
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1709023002

Review URL: https://codereview.chromium.org/1709023002
2016-02-18 06:13:25 -08:00
scroggo
ef0fed3bf0 Remove position from FrontBufferedStream
When FrontBufferedStream was written, it implemented getPosition()
and returned true for hasPosition(). The CL that introduced it
(crrev.com/23717055) does not have any indication why, but I'm guessing
it was because it was easy to implement. None of our decoders rely on
this (only some tests do).

Now that we have a decoder (SkRawCodec) that expects to be able to seek
a stream if it has a position (which makes sense - SkStream.h
associates that with SkStreamSeekable, and there is no other way to
check to see if a stream is seekable), it is failing because
FrontBufferedStream reports it has a position and the decoder tries to
seek.

Remove FrontBufferedStream::hasPosition() (reverting to the default,
false) and ::getPosition() (so it will return 0).

Fix tests - do not call FrontBufferedStream::getPosition()

Update CodexTest to test using an FrontBufferedStream, like Android
does.

BUG=b/27218441
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1703293002

Review URL: https://codereview.chromium.org/1703293002
2016-02-18 05:59:25 -08:00
caryclark
6b14c6b329 remove legacy bitmap filter
R=fmalita@chromium.org
BUG=skia:2261
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1711683002

Review URL: https://codereview.chromium.org/1711683002
2016-02-18 05:45:33 -08:00
joshualitt
adab5a2a4b fix comma in GrAuditTrail json
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1704133002

Review URL: https://codereview.chromium.org/1704133002
2016-02-18 05:04:39 -08:00
caryclark
8e7b19d0f0 add interp path
Add path methods to determine if a pair of paths
can be interpolated, and to interpolate them.

R=reed@google.com, robertphillips@google.com
BUG=skia:4549
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1703943003

Review URL: https://codereview.chromium.org/1703943003
2016-02-18 04:11:49 -08:00
herb
c5eddd7d8d Add bilerp filtering.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1705203002

Review URL: https://codereview.chromium.org/1705203002
2016-02-17 19:50:05 -08:00
reed
576af8f0cc some modes need clamping due to numerical imprecision
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1710453003

TBR=

Review URL: https://codereview.chromium.org/1710453003
2016-02-17 18:02:49 -08:00
cblume
e2412d5738 Adding direct access to SkMipMap levels.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1639693002

Review URL: https://codereview.chromium.org/1639693002
2016-02-17 14:53:23 -08:00
mtklein
3bc2624a4b try plain-old code for sk_memset16/32 now that NEON is compile-time
Most of these implementations now just say "always inline".
Let's see if we can get away with the simplicity of doing that all the time.

These inlined implementations can autovectorize easily.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1639863002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Review URL: https://codereview.chromium.org/1639863002
2016-02-17 14:21:28 -08:00
msarett
2775cf548c Speculative fix for Google3 iOS build
Now that SkImageGenerator is hooked up to use SkCodec by default,
we need to compile SkCodec in order to compile Skia.

The good news is that we can now turn on/off individual codecs.

This CL enables SkCodec on iOS, but does not turn on any of the
codecs that require third_party libraries.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1710493002

Review URL: https://codereview.chromium.org/1710493002
2016-02-17 14:14:25 -08:00
msarett
2a98bac9cb Return the proper error code in SkBmpRLECodec
BUG=skia:4963
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1707933002

Review URL: https://codereview.chromium.org/1707933002
2016-02-17 14:06:46 -08:00
jvanverth
d2d2eb9a01 Add GrGpu support for Vulkan command buffer flush
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1705133002

Review URL: https://codereview.chromium.org/1705133002
2016-02-17 14:04:46 -08:00
robertphillips
48e78468f5 Mark existing image filter entry points that will be going away with Deprecated
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1709753002

Review URL: https://codereview.chromium.org/1709753002
2016-02-17 13:57:17 -08:00
mtklein
b65fcd4283 Don't you just feel bad every time you type 'delete'?
This should fix
https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-ASAN/builds/4787/steps/nanobench/logs/stdio

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1703203003

Review URL: https://codereview.chromium.org/1703203003
2016-02-17 13:50:46 -08:00
brianosman
32f1908f4c Further reduction of GPU workload in shapes benchmarks. Hopefully this squelches the random crashes on Mali 400.
BUG=skia:4937
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1703233002

Review URL: https://codereview.chromium.org/1703233002
2016-02-17 13:43:40 -08:00
bungeman
bf521ff941 Move SkTArray to include/private.
TBR=reed
Agreed moving to private is good.

Review URL: https://codereview.chromium.org/1702073002
2016-02-17 13:13:44 -08:00
msarett
82709da122 Delete KTX tests to fix Android build
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1707053002

Review URL: https://codereview.chromium.org/1707053002
2016-02-17 13:10:14 -08:00
halcanary
68af68a0ef bin/sync-and-gyp: better error checking
NOTRY=true

Review URL: https://codereview.chromium.org/1704143002
2016-02-17 13:07:37 -08:00
iroth
5f0de06c43 Enable GL interfaces for iOS build
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1703923002

Review URL: https://codereview.chromium.org/1703923002
2016-02-17 12:47:27 -08:00
caryclark
6900641e02 add last move to serialized path
A deserialized path keeps the last move location so that
a subsequent append to the path does not add an unwanted
close verb.

R=reed@oogle.com
BUG=skia:4847
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1702393002

Review URL: https://codereview.chromium.org/1702393002
2016-02-17 12:16:27 -08:00
herb
134ad3e5b0 Fix name creation scope.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1701413003

Review URL: https://codereview.chromium.org/1701413003
2016-02-17 11:57:24 -08:00
ethannicholas
cecbbe2fa9 converted skiaserve PNGs from RGBA to RGB
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1703893003

Review URL: https://codereview.chromium.org/1703893003
2016-02-17 11:49:43 -08:00
msarett
d9ec32090e Do not create BmpMaskCodecs with invalid bits per pixel
BUG=skia:4962
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1704063002

Review URL: https://codereview.chromium.org/1704063002
2016-02-17 11:26:56 -08:00
joshualitt
6b3cf73af5 Add batch information to json
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1705093002

Review URL: https://codereview.chromium.org/1705093002
2016-02-17 11:20:26 -08:00
cdalton
91e457d17f Fix "^" in --match flag for nanobench SKPs
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1706923002

Review URL: https://codereview.chromium.org/1706923002
2016-02-17 11:10:16 -08:00
senorblanco
9bd5f746ca Remove 6-param applyCropRect() from lighting filters (GPU path).
This required adding a texture domain effect if the destination bounds are not contained within the source bounds.

BUG=skia:4502
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1698913004

Review URL: https://codereview.chromium.org/1698913004
2016-02-17 10:59:47 -08:00
bsalomon
c43f2af60e Add a script to build and copy the command buffer shared library. This script will be used by the bots to test skia on the command buffer.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1699273002

NOTREECHECKS=true
NOTRY=true
BUG=skia:4957

Review URL: https://codereview.chromium.org/1699273002
2016-02-17 10:42:46 -08:00
ethannicholas
272af6ecd7 Revert of further skiaserve image performance improvements (patchset #1 id:1 of https://codereview.chromium.org/1707453003/ )
Reason for revert:
Broke skiaserve GPU rendering

Original issue's description:
> further skiaserve image performance improvements
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1707453003
>
> Committed: https://skia.googlesource.com/skia/+/68c063bf11c91b2b3b15cb93168cf2af9b2c642d

TBR=joshualitt@google.com,jcgregorio@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1708683002
2016-02-17 10:30:27 -08:00
bungeman
70bb808021 Add request cache to SkFontHost_fontconfig.
The current code deduplicates SkTypeface instances as all font lookups
should for better use of the glyph cache. This adds a request cache as
well, so that repeated recent requests will return the cached result
instead of doing a full lookup.

BUG=chromium:424082, chromium:444894

Review URL: https://codereview.chromium.org/1683883002
2016-02-17 10:13:49 -08:00
msarett
8715d47e24 Make SkPicture/SkImageGenerator default to SkCodec
Remove reference to SkImageDecoder from SkPicture. Make the default
InstallPixelRefProc passed to CreateFromStream use
SkImageGenerator::NewFromEncoded instead.

Make SkImageGenerator::NewFromEncoded create an SkCodecImageGenerator.
Remove the old version that used SkImageDecoder.

Remove all versions of lazy_decode_bitmap/LazyDecodeBitmap. The default
now behaves lazily.

Update all clients to use the default.

Move SkImageDecoderGenerator into KtxTest.cpp, and use it directly.

This is a rebased version of:
https://codereview.chromium.org/1671193002/

TBR=reed@google.com

BUG=skia:4691
BUG=skia:4290
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1699183004

Review URL: https://codereview.chromium.org/1699183004
2016-02-17 10:02:29 -08:00
herb
feec878e85 Simplified linear pipeline.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1704583003

Review URL: https://codereview.chromium.org/1704583003
2016-02-17 10:00:07 -08:00
ethannicholas
68c063bf11 further skiaserve image performance improvements
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1707453003

Review URL: https://codereview.chromium.org/1707453003
2016-02-17 09:17:35 -08:00
halcanary
117672db3f bin/sync-and-gyp: pass --deps='...' to gclient sync.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1705063002

Review URL: https://codereview.chromium.org/1705063002
2016-02-17 08:39:23 -08:00
msarett
39b2d5a1ac Individually enable and disable SkCodecs
BUG=skia:4956
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1702533004
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot

Review URL: https://codereview.chromium.org/1702533004
2016-02-17 08:26:32 -08:00
ebrauer
46d2aa824c Updates Piex and uses it to obtain the DNG dimensions.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1659873002

Review URL: https://codereview.chromium.org/1659873002
2016-02-17 08:04:00 -08:00
mtklein
0cf795fd11 fast sk4f <-> sk4i SSE methods
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1707673002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Review URL: https://codereview.chromium.org/1707673002
2016-02-17 07:23:36 -08:00
reed
d96e7e503f misc fixes to make float buffers work a little better
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1703013002

TBR=fmalita

Review URL: https://codereview.chromium.org/1703013002
2016-02-17 07:15:30 -08:00
mtklein
34d26b9652 dead code: really kill these off again
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1702343002

Review URL: https://codereview.chromium.org/1702343002
2016-02-17 06:47:52 -08:00
mtklein
dc469adf04 come on, this is how you drive-by
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1708563002

Review URL: https://codereview.chromium.org/1708563002
2016-02-17 06:37:51 -08:00
fmalita
d10f5b3ac9 Use geometric mean when selecting a mipmap scale
Workaround for anisotropic mipmap quality issues.

R=reed@google.com,robertphillips@google.com
BUG=skia:4863,chromium:586894
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1697423002

Review URL: https://codereview.chromium.org/1697423002
2016-02-17 06:17:12 -08:00
yujieqin
879adccf60 Update PIEX version. This should solve the stack buffer overflow issue
BUG=skia:4902
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1690853003

Review URL: https://codereview.chromium.org/1690853003
2016-02-17 06:12:12 -08:00
joshualitt
8db867820b Fix memory leak
TBR=bsalomon@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1706773002

Review URL: https://codereview.chromium.org/1706773002
2016-02-17 05:40:00 -08:00
kkinnunen
e06ed25540 Do not try to use GL_texture_rectangle on GL ES
Do not try to use ARB_GL_texture_rectangle on GL ES.
Command buffer exposes it, but it's not recommended. It also
does not work with TexImage2D, and ANGLE does not
have support for it on with GL ES 3.0 source context.

Bug triggered only when trying to use command buffer in
GL ES 3.0 mode.

BUG=angleproject:1313
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1691853003

Review URL: https://codereview.chromium.org/1691853003
2016-02-16 23:15:40 -08:00
mtklein
32a45f6c96 These files must be in the gypi for GN to remove them...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1696373005

Review URL: https://codereview.chromium.org/1696373005
2016-02-16 20:56:13 -08:00
mtklein
e90b4859a0 restore empty files so that Chrome GN config can remove them...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1700023005

Review URL: https://codereview.chromium.org/1700023005
2016-02-16 20:23:49 -08:00
iroth
ab669def65 Fix linker errors when skia_ios target is used a dependency of an iOS app.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1701153002

Review URL: https://codereview.chromium.org/1701153002
2016-02-16 19:17:01 -08:00
mtklein
048494c1e2 clean up more dead code
- SkSHA1 is unused
  - SkRunnable is obsolete now that we have std::function

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1705583003

Review URL: https://codereview.chromium.org/1705583003
2016-02-16 19:06:15 -08:00
mtklein
f60a8908d2 Delete dead code. SkBitmapHasher has not been used since gm.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1704783002

Review URL: https://codereview.chromium.org/1704783002
2016-02-16 18:38:15 -08:00
kjlubick
2a42f48b58 Add ability to fuzz images using scaling and different modes
This also fixes the tryAllocPixels/SkColorTable mismatch which was causing the
"Image might be too large (32 x 32)" problems.

BUG=skia:4952
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1698963003

Review URL: https://codereview.chromium.org/1698963003
2016-02-16 16:14:23 -08:00