Commit Graph

10888 Commits

Author SHA1 Message Date
robertphillips@google.com
105a4a584c Collapse matrix & clip stack in PictureRecord
https://codereview.chromium.org/137093004/



git-svn-id: http://skia.googlecode.com/svn/trunk@13402 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-11 15:10:40 +00:00
commit-bot@chromium.org
93d5ffda58 Change growth function for SkWriter32
Add setCountExact to SkTDArray to allow external control of array growth.
Use it to allow SkWriter to control the buffer growth pattern.
Change buffer growth pattern to 1.5n+4096

BUG=skia:2125
R=tomhudson@google.com, mtklein@google.com, reed@google.com

Author: iancottrell@google.com

Review URL: https://codereview.chromium.org/150663014

git-svn-id: http://skia.googlecode.com/svn/trunk@13401 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-11 15:07:26 +00:00
commit-bot@chromium.org
ac14aac67b Whitespace change to test bugdroid links.
(SkipBuildbotRuns)
BUG=skia:2139
TBR=
NOTREECHECKS=true
NOTRY=true

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/142393004

git-svn-id: http://skia.googlecode.com/svn/trunk@13400 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-11 13:57:15 +00:00
commit-bot@chromium.org
589bd3da34 Revert of Add the perceptual difference metric to the rebaseline server (https://codereview.chromium.org/147453003/)
Reason for revert:
Caused failure in RunGmSelfTests:
http://108.170.219.160:10117/builders/Housekeeper-PerCommit/builds/154/steps/RunGmSelfTests/logs/stdio

Filed:
https://code.google.com/p/skia/issues/detail?id=2160

Original issue's description:
> Add the perceptual difference metric to the rebaseline server
>
> * Finds the location of the skpdiff binary.
> * Calculates the perceptual difference percentage using the skpdiff binary.
> * Replaces the weightedDiffMeasure in view.html with perceptualDifferent.
>
> BUG=skia:2019
> NOTRY=true
>
> Committed: http://code.google.com/p/skia/source/detail?r=13398

R=epoger@google.com
TBR=epoger@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2019

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/131453017

git-svn-id: http://skia.googlecode.com/svn/trunk@13399 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-11 13:30:33 +00:00
commit-bot@chromium.org
af34eb9b74 Add the perceptual difference metric to the rebaseline server
* Finds the location of the skpdiff binary.
* Calculates the perceptual difference percentage using the skpdiff binary.
* Replaces the weightedDiffMeasure in view.html with perceptualDifferent.

BUG=skia:2019
NOTRY=true
R=epoger@google.com

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/147453003

git-svn-id: http://skia.googlecode.com/svn/trunk@13398 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-11 12:33:58 +00:00
commit-bot@chromium.org
afe38b16f0 Fix broken debug build
BUG=skia:
R=tomhudson@google.com

Author: iancottrell@google.com

Review URL: https://codereview.chromium.org/143223005

git-svn-id: http://skia.googlecode.com/svn/trunk@13397 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-11 11:18:12 +00:00
commit-bot@chromium.org
046f1f6ff4 Cleaner external buffer handling in SkWriter32
This unifies the internal and external buffer handling so that the difference only has to be noticed when growing.
Removing the branches from the common read and write cases gives a significant speedup.

BUG=skia:2125
R=tomhudson@google.com, mtklein@google.com, reed@google.com

Author: iancottrell@google.com

Review URL: https://codereview.chromium.org/156683004

git-svn-id: http://skia.googlecode.com/svn/trunk@13396 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-11 10:17:02 +00:00
mike@reedtribe.org
1195a28892 Revert "SkBitmap now really stores SkImageInfo -- config is just a ruse"
BUG=skia:

Review URL: https://codereview.chromium.org/147733004

git-svn-id: http://skia.googlecode.com/svn/trunk@13395 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-11 03:24:02 +00:00
mike@reedtribe.org
b53317c6fa fix test for empty config
handle empty setconfig

BUG=skia:

Review URL: https://codereview.chromium.org/159533002

git-svn-id: http://skia.googlecode.com/svn/trunk@13394 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-11 03:10:54 +00:00
skia.committer@gmail.com
8ed6443e6c Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@13393 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-11 03:02:13 +00:00
mike@reedtribe.org
c9114856e8 fix warnings
BUG=skia:

Review URL: https://codereview.chromium.org/153003005

git-svn-id: http://skia.googlecode.com/svn/trunk@13392 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-11 02:40:11 +00:00
mike@reedtribe.org
169a0ed50a SkBitmap now really stores SkImageInfo -- config is just a ruse
(edited) clone of https://codereview.chromium.org/159173004/

Review URL: https://codereview.chromium.org/159463003

git-svn-id: http://skia.googlecode.com/svn/trunk@13391 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-11 02:20:17 +00:00
commit-bot@chromium.org
7e90e8dbb9 fix minor error between kStroke_PathAsRect and kFill_PathAsRect in SkPath::asRect
R=caryclark@google.com, reed@google.com

Author: yunchao.he@intel.com

Review URL: https://codereview.chromium.org/138703008

git-svn-id: http://skia.googlecode.com/svn/trunk@13390 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-11 01:38:30 +00:00
commit-bot@chromium.org
6d254ee4ac Use SkToBool to fix a warning.
NOTRY=true
TBR=djsollen@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/159333002

git-svn-id: http://skia.googlecode.com/svn/trunk@13389 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-10 22:46:08 +00:00
commit-bot@chromium.org
74b88b70b8 Allow buffered stream to work with an offset.
If the stream being buffered is buffered from somewhere other than
the start, the SkFrontBufferedStream needs to take that into account
when reporting its length.

R=djsollen@google.com, bungeman@google.com, reed@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/157103002

git-svn-id: http://skia.googlecode.com/svn/trunk@13388 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-10 22:03:21 +00:00
commit-bot@chromium.org
ba9354b9d4 SkOnce in is_lcd_supported instead of hand rolled double-checked locking.
BUG=skia:
R=bungeman@google.com, reed@google.com

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/155963003

git-svn-id: http://skia.googlecode.com/svn/trunk@13387 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-10 19:58:49 +00:00
commit-bot@chromium.org
50b393a768 SkPictureRecord: silently do nothing for non-drawable SkBitmaps.
BUG=skia:2135
R=reed@google.com

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/154083004

git-svn-id: http://skia.googlecode.com/svn/trunk@13386 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-10 18:29:10 +00:00
commit-bot@chromium.org
9985ef5ed8 rebaseline_server: add ImagePair class, a step towards new intermediate JSON schema
See https://goto.google.com/ChangingRbsJson and bug 1919 for additional context

BUG=skia:1919
NOTRY=True
R=rmistry@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/157593006

git-svn-id: http://skia.googlecode.com/svn/trunk@13385 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-10 18:19:30 +00:00
robertphillips@google.com
3e0c64ad1e Stateful PathRenderer implementation
https://codereview.chromium.org/23926019/



git-svn-id: http://skia.googlecode.com/svn/trunk@13384 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-10 16:46:23 +00:00
commit-bot@chromium.org
0888b7534c DM: catch -r foo -w foo.
BUG=skia:
R=reed@google.com

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/152223003

git-svn-id: http://skia.googlecode.com/svn/trunk@13383 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-10 16:39:40 +00:00
reed@google.com
6be31f42ca remove SK_SUPPORT_LEGACY_ONLOCKPIXELS completely
BUG=skia:

Review URL: https://codereview.chromium.org/158893005

git-svn-id: http://skia.googlecode.com/svn/trunk@13382 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-10 15:43:29 +00:00
commit-bot@chromium.org
5764165127 Split opts_check_arm.cpp into per-class files
Signed-off-by: Kévin PETIT <kevin.petit@arm.com>

BUG=skia:
R=djsollen@google.com

Author: kevin.petit@arm.com

Review URL: https://codereview.chromium.org/157863003

git-svn-id: http://skia.googlecode.com/svn/trunk@13381 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-10 15:01:05 +00:00
senorblanco@chromium.org
a83f059f3e New Xoom baselines for imagefilter tests.
(The Xoom bots were asleep when I did the first round.)

BUG=skia:2150
TBR=bsalomon@google.com

Review URL: https://codereview.chromium.org/153883005

git-svn-id: http://skia.googlecode.com/svn/trunk@13380 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-10 14:58:45 +00:00
robertphillips@google.com
f66cf72c68 Move fLastMoveToIndex from SkPath to SkPathRef
https://codereview.chromium.org/146913002/



git-svn-id: http://skia.googlecode.com/svn/trunk@13379 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-10 13:51:32 +00:00
bsalomon@google.com
2693eb9523 Mark imagefiltersbase_gpu as ignore-failure on IntelRhb release. The color of one of the lines around test cases changes subtly between runs.
BUG=skia:2005
BUG=skia:2085
BUG=skia:2120

Review URL: https://codereview.chromium.org/139443005

git-svn-id: http://skia.googlecode.com/svn/trunk@13378 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-09 13:28:11 +00:00
bsalomon@google.com
5847b68888 Rebase files after recent GPU clipping changes
BUG=skia:2051

Review URL: https://codereview.chromium.org/158443002

git-svn-id: http://skia.googlecode.com/svn/trunk@13377 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-09 04:46:47 +00:00
skia.committer@gmail.com
f0b0cda76f Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@13376 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-09 03:02:01 +00:00
commit-bot@chromium.org
f053980016 Specialize GrConvexPolyEffect for AA rects, use for AA clip rects.
BUG=skia:2051
R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/140093004

git-svn-id: http://skia.googlecode.com/svn/trunk@13375 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-08 19:31:05 +00:00
bsalomon@google.com
fffc9dcf57 Rebaselines from gpu convex poly clip changes.
BUG=skia:2051
BUG=skia:2120

Review URL: https://codereview.chromium.org/153163004

git-svn-id: http://skia.googlecode.com/svn/trunk@13374 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-08 04:52:01 +00:00
commit-bot@chromium.org
6dee8759ab Add workaround for Xoom crashing after discard removed from shader.
R=robertphillips@google.com
TBR=robertphillips@google.com

BUG=skia:2149

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/133703016

git-svn-id: http://skia.googlecode.com/svn/trunk@13373 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-07 22:39:01 +00:00
fmalita@google.com
f04c21dd64 More bench rebaselines for new SKPs.
Review URL: https://codereview.chromium.org/130633009

git-svn-id: http://skia.googlecode.com/svn/trunk@13372 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-07 21:21:14 +00:00
commit-bot@chromium.org
b21fac156d Make GMs aware of what tool they're being run in.
Add a saveLayer set of draws to convex_poly_clip and fix GPU bug where polygon clips don't account for the translation between clip and device space.

BUG=skia:2051
R=robertphillips@google.com, reed@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/148283017

git-svn-id: http://skia.googlecode.com/svn/trunk@13371 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-07 21:13:11 +00:00
bsalomon@google.com
5bc7339aab Rebase canvas-state on N7
Review URL: https://codereview.chromium.org/156533004

git-svn-id: http://skia.googlecode.com/svn/trunk@13370 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-07 21:13:03 +00:00
commit-bot@chromium.org
b000d76af4 Drawing fake bold text, line and normal text made normal text bolder on PDF.
When PDF uses fake bold text, it uses stroke and fill for the
text. After that, line is drawn. It creates new ContextEntry which
GraphicStateEntry has 0 fTextScaleX. Since fTextScaleX is 0,
GraphicStackState::updateDrawingState() doesn't update text fill mode or
the PDF page. When the normal text is drawn, it reuse the line's
ContextEntry because GraphicStateEntry::compareInitialState() returns
true. However, since the reused GraphicsStateEntry's fTextScaleX is 0,
the text fill mode is not updated to fill, and the text is drawn in
stroke and fill mode.

When the fTextScaleX is changed, we should not reuse GraphicStateEntry
even if ether of fTextScaleX is 0.

BUG=skia:2132
R=reed@google.com, vandebo@chromium.org, bungeman@google.com

Author: yuki.sekiguchi@access-company.com

Review URL: https://codereview.chromium.org/137923005

git-svn-id: http://skia.googlecode.com/svn/trunk@13369 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-07 19:39:57 +00:00
fmalita@google.com
244b288431 Fix garbled Nexus7 bench expectations entry.
Review URL: https://codereview.chromium.org/136953009

git-svn-id: http://skia.googlecode.com/svn/trunk@13368 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-07 18:43:40 +00:00
commit-bot@chromium.org
164052e9ce Create a common utility for finding and running binaries in out/
NOTRY=true
BUG=skia:2019
R=epoger@google.com

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/156173005

git-svn-id: http://skia.googlecode.com/svn/trunk@13367 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-07 18:41:49 +00:00
commit-bot@chromium.org
e6af4fb34b rebaseline_server: properly handle unexpected GETs
BUG=skia:2147
NOTRY=True
R=rmistry@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/157773002

git-svn-id: http://skia.googlecode.com/svn/trunk@13366 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-07 18:21:59 +00:00
fmalita@google.com
480ae28b64 Bench rebaseline for the new SKPs
TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/156733003

git-svn-id: http://skia.googlecode.com/svn/trunk@13365 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-07 17:14:01 +00:00
reed@google.com
d5911c4d8f remove unneeded SK_SUPPORT_LEGACY_NEWRENDERTARGETDIRECT
BUG=skia:
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/141063004

git-svn-id: http://skia.googlecode.com/svn/trunk@13364 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-07 16:23:27 +00:00
reed@google.com
5d54c29c70 remove unneeded SK_SUPPORT_LEGACY_CANVAS_CREATECOMPATIBLEDEVICE
git-svn-id: http://skia.googlecode.com/svn/trunk@13363 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-07 16:09:26 +00:00
reed@google.com
20c4ebe9bf remove legacy LightingColorFilter impl
TBR:djsollen

Review URL: https://codereview.chromium.org/151353005

git-svn-id: http://skia.googlecode.com/svn/trunk@13362 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-07 16:02:41 +00:00
commit-bot@chromium.org
6516d4b831 Set scissor to clip bounding box when using GrConvexPolyEffect
BUG=skia:2051
R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/156843005

git-svn-id: http://skia.googlecode.com/svn/trunk@13361 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-07 14:04:48 +00:00
commit-bot@chromium.org
c435360f20 Fix android build issues with atomics
Uses inline methods for sk_atomic_inc/add/dec instead of #define.
Since those methods are declared as static in SkThread.h, they need
a definition or else the compiler generates an error. Also corrects
a typo.

BUG=skia:
R=djsollen@google.com, bungeman@google.com, bsalomon@google.com

Author: cdalton@nvidia.com

Review URL: https://codereview.chromium.org/148113010

git-svn-id: http://skia.googlecode.com/svn/trunk@13360 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-07 13:55:57 +00:00
commit-bot@chromium.org
1f1dd96336 Whitespace change to test Bugdroid II
(SkipBuildbotRuns)

TBR=
NOTRY=true
BUG=skia:2139

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/144713009

git-svn-id: http://skia.googlecode.com/svn/trunk@13359 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-07 13:29:21 +00:00
commit-bot@chromium.org
d4d87df3c5 Whitespace change to test Bugdroid
(SkipBuildbotRuns)

TBR=
NOTRY=true
BUG=2139

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/157393003

git-svn-id: http://skia.googlecode.com/svn/trunk@13358 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-07 13:27:59 +00:00
commit-bot@chromium.org
5e0995e4b3 Revert of Revert "Serialization of SkPictureImageFilter" (https://codereview.chromium.org/153583007/)
Reason for revert:
New SKPs with version20 are in Google Storage due to http://108.170.219.160:10117/builders/Housekeeper-Nightly-RecreateSKPs/builds/22

Original issue's description:
> Revert "Serialization of SkPictureImageFilter"
>
> This reverts commit 227321b30106e57942929eb96fa5bc22544f6c9e.
>
> Revert "Sanitizing source files in Housekeeper-Nightly"
>
> This reverts commit baf28584b7636c01355f8d8d972e06aa7fb66d77.
>
> TBR=robertphillips@google.com,sugoi@google.com
>
> Committed: https://code.google.com/p/skia/source/detail?r=13356

R=robertphillips@google.com, sugoi@google.com, fmalita@google.com, fmalita@chromium.org
TBR=fmalita@chromium.org, fmalita@google.com, robertphillips@google.com, sugoi@google.com
NOTREECHECKS=true
NOTRY=true

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/143163005

git-svn-id: http://skia.googlecode.com/svn/trunk@13357 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-07 12:20:04 +00:00
fmalita@google.com
7713c38dc0 Revert "Serialization of SkPictureImageFilter"
This reverts commit 227321b30106e57942929eb96fa5bc22544f6c9e.

Revert "Sanitizing source files in Housekeeper-Nightly"

This reverts commit baf28584b7636c01355f8d8d972e06aa7fb66d77.

TBR=robertphillips@google.com,sugoi@google.com

Review URL: https://codereview.chromium.org/153583007

git-svn-id: http://skia.googlecode.com/svn/trunk@13356 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-07 05:55:39 +00:00
skia.committer@gmail.com
c5acc6c827 Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@13355 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-07 03:02:05 +00:00
commit-bot@chromium.org
4f6318d2e6 Serialization of SkPictureImageFilter
BUG=skia:

Committed: http://code.google.com/p/skia/source/detail?r=13347

R=senorblanco@google.com, reed@google.com, mtklein@google.com, sugoi@google.com, senorblanco@chromium.org, robertphillips@google.com, scroggo@google.com

Author: sugoi@chromium.org

Review URL: https://codereview.chromium.org/138063005

git-svn-id: http://skia.googlecode.com/svn/trunk@13354 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-07 02:09:50 +00:00
reed@google.com
70ac79b754 use new instead of createCompatibleDevice, since we know the subclass we want
BUG=skia:
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/141443009

git-svn-id: http://skia.googlecode.com/svn/trunk@13353 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-06 22:03:17 +00:00