Commit Graph

410 Commits

Author SHA1 Message Date
Kevin Lubick
3d99b1e347 Add Correctness tests for CanvasKit
Also make a CPU only and GPU only build (although
the latter still has a lot of CPU logic).

Bug: skia:
Change-Id: I857c2300021c2adb5344865c28e4ad3e8d332954
Reviewed-on: https://skia-review.googlesource.com/c/162022
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-10-16 14:32:28 +00:00
Kevin Lubick
3655e4059e Have BuildStats use Flutter's stripped lib
That's what their treemap says and we should try to match it.

Bug: skia:
Change-Id: Iefa95c0440eb6b45a94a72c1beffb8a1199152a4
Reviewed-on: https://skia-review.googlesource.com/c/161825
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-10-12 21:32:54 +00:00
Kevin Lubick
556350de37 Add Perf jobs for PathKit
We have a similar ingestion strategy to Gold.

I tried to use something off the shelf like benchmark.js
but passing the PathKit context into the benchmarks was
non-trivial. Plus, making a basic benchmarking tool
ended up being not too hard.

We should be able to re-use the docker container/aggregator
for CanvasKit too.

Bug: skia:
Change-Id: I613dfc58ea57c31cf71566a8ac55f8df9272ad25
Reviewed-on: https://skia-review.googlesource.com/c/161620
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Reviewed-by: Stephan Altmueller <stephana@google.com>
2018-10-12 19:50:04 +00:00
Kevin Lubick
a60a1945eb Add Vulkan to BuildStats-Mini
Bug: skia:
Change-Id: I320b7945e5e2939404e039cb83831b2bb408aaac
Reviewed-on: https://skia-review.googlesource.com/c/161842
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-10-12 18:37:37 +00:00
Kevin Lubick
37baac128f Remove old code size analysis
Was replaced with:
https://skia-review.googlesource.com/c/skia/+/160220
https://skia-review.googlesource.com/c/skia/+/160765
https://skia-review.googlesource.com/c/skia/+/160920

Bug: skia:
Change-Id: Ia87f4d548cd33dcd6c21c3711aef65ac2dab9f60
Reviewed-on: https://skia-review.googlesource.com/c/160940
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-10-10 14:25:17 +00:00
Kevin Lubick
6ca0d8a767 Add BuildStats job for Mini
Bug: skia:
Change-Id: Ibb47179315d191af5023039212e4c9b5e784bb75
Reviewed-on: https://skia-review.googlesource.com/c/160765
Reviewed-by: Eric Boren <borenet@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-10-09 17:33:46 +00:00
Ravi Mistry
eea245c896 Turn down CT_* bots
Specifically, turn down:
* Perf-Ubuntu14-Clang-GCE-CPU-AVX2-x86_64-Release-All-CT_BENCH_1k_SKPs
* Perf-Ubuntu14-Clang-Golo-GPU-QuadroP400-x86_64-Release-All-CT_BENCH_1k_SKPs
* Test-Ubuntu14-Clang-GCE-CPU-AVX2-x86_64-Debug-All-CT_DM_100k_SKPs
* Test-Ubuntu14-Clang-GCE-CPU-AVX2-x86_64-Debug-All-CT_DM_1m_SKPs
* Test-Ubuntu14-Clang-GCE-CPU-AVX2-x86_64-Debug-All-CT_IMG_DECODE_100k_SKPs

Also deletes the no longer needed recipe_modules:
* ct
* isolate
* skia_swarming
* swarming
* swarming_client

Bug: skia:8455
Bug: skia:6704
Change-Id: Ia4912830909081d060f7361706d16fd751b3bda0
Reviewed-on: https://skia-review.googlesource.com/c/160764
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-10-09 15:05:24 +00:00
Kevin Lubick
8e9750d3c5 Add CanvasKit build
Building CanvasKit uses very similar logic to PathKit, so there
was a fair amount of copy/paste/customize.

Fixes the name of skia.js/wasm -> canvaskit.js/wasm and
adds a package.json to formally track versions.

Also move PathKit helper scripts to align better.

Docs-Preview: https://skia.org/?cl=160463
Bug: skia:
Change-Id: Ie75b30592dcc4d520dca41f6f5579006aaa8849b
Reviewed-on: https://skia-review.googlesource.com/c/160463
Reviewed-by: Eric Boren <borenet@google.com>
2018-10-09 13:56:56 +00:00
Kevin Lubick
eba2624e2c Use right bucket for buildstats
Additionally, include the revision name in the json file name
to avoid collisions.

Bug: skia:
Change-Id: I6601c28679f82406721d740041a60077b460c0f4
Reviewed-on: https://skia-review.googlesource.com/c/160560
Reviewed-by: Eric Boren <borenet@google.com>
2018-10-08 19:23:56 +00:00
Kevin Lubick
35b87a5b44 Add Build and Test jobs for SKQP using docker.
Uses Docker to compile an APK and then run it on an emulator.

We use a specialized image for build (includes Clang, etc)
And then the 3rd party base image for just the test (which
has the emulator and SDK on it).

Bug: skia:7578, skia:7692
Change-Id: I948e0b091868e7173b00e3affd7c3d59a5cd1ec2
Reviewed-on: https://skia-review.googlesource.com/c/159681
Reviewed-by: Stephan Altmueller <stephana@google.com>
Reviewed-by: Hal Canary <halcanary@google.com>
2018-10-08 19:17:25 +00:00
Kevin Lubick
4968843293 Add BuildStats pipeline for PathKit binaries
This should be extensible to do something similar
for libskia and other outputs.

Bug: skia:
Change-Id: Id9f30a82f4eb0e7ce868a32409b1be429917e7f6
Reviewed-on: https://skia-review.googlesource.com/c/160220
Reviewed-by: Eric Boren <borenet@google.com>
2018-10-08 18:15:32 +00:00
Kevin Lubick
de1a1a2de3 Open non-perf Quadro bots to rack 2
Bug: 784662
Change-Id: I49b8b396956e3442713ca2750fe19fd35f0797f0
Reviewed-on: https://skia-review.googlesource.com/158221
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-10-01 14:25:25 +00:00
Eric Boren
84ae6410b9 [infra] Add nightly UpdateGoDEPS
The go_deps asset is almost two months old...

Bug: skia:
Change-Id: I3910d1812a3c8ec4b599e959b76f8d60202b877a
Reviewed-on: https://skia-review.googlesource.com/157425
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2018-09-27 19:54:26 +00:00
Ben Wagner
6c6bd073ee Revert "[infra] Enable QuadroP400 bots on rack:2"
This reverts commit 297caafc58.

Reason for revert: I think I have identified a test that shows the perf differences: https://perf.skia.org/e/?begin=1537548564&end=1537984657&keys=5743052312281088

Original change's description:
> [infra] Enable QuadroP400 bots on rack:2
> 
> I tried to determine the differences between rack:1 and rack:2 using
> trybots, but didn't have much luck. Hopefully whatever issue that was
> causing differences has gone away, but if not, hopefully it will be
> easier to identify the differences using Perf.
> 
> Change-Id: If9b16e8e247737cfc61bf00629eb68b8751bbf3a
> Reviewed-on: https://skia-review.googlesource.com/156500
> Reviewed-by: Kevin Lubick <kjlubick@google.com>
> Commit-Queue: Ben Wagner <benjaminwagner@google.com>

TBR=benjaminwagner@google.com,kjlubick@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Icc89ef83d0f981d22edb15ef934ac07ba1ab5bf3
Reviewed-on: https://skia-review.googlesource.com/157221
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-09-26 18:32:00 +00:00
Ben Wagner
297caafc58 [infra] Enable QuadroP400 bots on rack:2
I tried to determine the differences between rack:1 and rack:2 using
trybots, but didn't have much luck. Hopefully whatever issue that was
causing differences has gone away, but if not, hopefully it will be
easier to identify the differences using Perf.

Change-Id: If9b16e8e247737cfc61bf00629eb68b8751bbf3a
Reviewed-on: https://skia-review.googlesource.com/156500
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-09-25 16:37:36 +00:00
Kevin Lubick
2f9c1cccdd Remove coverage bots
See https://skia-review.googlesource.com/c/buildbot/+/156232

Bug: skia:
Change-Id: I731db6dd63d39e04b84a65dd7a18b7236d24a708
Reviewed-on: https://skia-review.googlesource.com/156365
Auto-Submit: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-09-24 15:46:49 +00:00
Ben Wagner
17d1896a44 Update OS on GalaxyS7.
Change-Id: Iee1dbb2f008a4b79f7c213016ff97b9b50fbd673
Reviewed-on: https://skia-review.googlesource.com/154500
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-09-17 14:49:05 +00:00
Ben Wagner
d8327f4c91 Update Win version.
Change-Id: Ieb0885c2638629634b60e78d3ff99af446ac7d67
Reviewed-on: https://skia-review.googlesource.com/154620
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-09-13 22:18:51 +00:00
Kevin Lubick
1b5ece0f06 Add mesa_intel_driver asset and dockerfile for creating
This deletes the previous hand-built drivers and the
distinction between a debug and non-debug driver.

Bug: skia:
Change-Id: Ia733783d703da803f76361c61b938d9ce70c88f0
Reviewed-on: https://skia-review.googlesource.com/150163
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2018-09-11 21:30:33 +00:00
Ben Wagner
10085b7411 Remove GTX1070 and GTX1050 jobs.
After discussing with bsalomon, we think QuadroP400 gives us good enough
coverage for NVIDIA Pascal.

No-Try: true
Change-Id: If50a80d872ae9dc2c5987b3e31804a8e16325888
Reviewed-on: https://skia-review.googlesource.com/150908
Commit-Queue: Brian Salomon <bsalomon@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2018-08-31 17:37:17 +00:00
Ben Wagner
d709a85751 [infra] Add rack dimension for QuadroP400 tasks.
See https://bugs.chromium.org/p/chromium/issues/detail?id=784662 for
more context. We need to distinguish between existing bots and the new
bots in order to have consistent performance measurements.

This is step 2 of 3:
1. Add rack:1 dimension to bots.cfg for current Skia QuadroP400 bots.
2. Add rack:1 dimension to our tasks to ensure they only run on the
   current bots.
3. Add build{330..335}-a9 to bots.cfg with rack:2 dimension.

Bug: chromium:784662
Change-Id: I1e5ff0aa0ebd69e00f4933ca50eef6cef520bc66
Reviewed-on: https://skia-review.googlesource.com/150911
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-08-31 17:32:16 +00:00
Ben Wagner
1f0fb09d5e [infra] Update Win Radeon drivers.
No-Try: true
Change-Id: I7b4418f8ee2bf94c5cdc1b22aed76e3448b17030
Reviewed-on: https://skia-review.googlesource.com/149822
Commit-Queue: Stephan Altmueller <stephana@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Stephan Altmueller <stephana@google.com>
2018-08-29 16:39:27 +00:00
Ben Wagner
7efa13d593 Update NVIDIA_Shield to Oreo.
No-Try: true
Change-Id: Ibb7a6b0987f3c38affd2266f21393c043d4dbb8d
Reviewed-on: https://skia-review.googlesource.com/150165
Commit-Queue: Stephan Altmueller <stephana@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Stephan Altmueller <stephana@google.com>
2018-08-29 16:38:27 +00:00
Greg Daniel
900e5c8f62 [infra] Update Win Intel drivers.
No-Try: true
Change-Id: If5314359997b5db7a9628972e464e8673b5e6f14
Reviewed-on: https://skia-review.googlesource.com/149740
Commit-Queue: Greg Daniel <egdaniel@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2018-08-28 18:14:08 +00:00
Kevin Lubick
82999c037e Add docker-based infrastructure for Gold/lottie-web integration
This adds 2 docker containers (based on the ones used for PathKit
added in https://skia-review.googlesource.com/c/skia/+/147042)
which bundle Chrome and puppeteer to allow the lottiecap.js
to be run anywhere.

This adds a recipe (test_lottie_web.py) to drive the docker
container and do a little bit of set-up (and a few docs/bug
fixes discovered in the test_pathkit.py that it was based on).

Additionally, this modifies lottiecap.js to support POSTing
output to a running go server (again, the same as PathKit)
which has the image data hashed and the metadata added to
a large JSON output.

This re-works driver.html to avoid re-loading the JSON object
25 times. The performance boost is important because, right now,
the lottie files are processed individually.

In a future CL, I want to address the two TODOs in
lottie-web-aggregator.go

Bug: skia:8108
Change-Id: I100c9ce23dcc5033a27287211cbf0db898960da9
Reviewed-on: https://skia-review.googlesource.com/149282
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Reviewed-by: Stephan Altmueller <stephana@google.com>
2018-08-28 15:16:22 +00:00
Kevin Lubick
1118cfdbdc Update Pixel 2 XL to Android P
Bug: skia:
Change-Id: Ib3616e1504175b7862ad0a78837cc8eca7a8deb9
Reviewed-on: https://skia-review.googlesource.com/149227
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-08-24 15:36:20 +00:00
Ben Wagner
7ea54289d2 Remove extra Mac CPU jobs.
This is a followup to
https://skia-review.googlesource.com/c/skia/+/145431

Also clean up old job names in recipe expectations.

No-Try: true
Change-Id: Ic63a64a98fb39076680941bb2415b7bb64415179
Reviewed-on: https://skia-review.googlesource.com/148671
Commit-Queue: Eric Boren <borenet@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-08-22 18:44:24 +00:00
Kevin Lubick
f14a3c059f [PathKit] Add asm.js build and test jobs
Consolidates the karma files into one for docker/asmjs/wasm and all
combinations.

The asm.js build seems to have some small imprecisions that we didn't
see as much as with WASM, probably due to JS limitations/differences
to c++'s floats.

To address these, I've marked some (5) tests in PathOps* as flaky
because they fail on Release, Debug or Test versions of the asm.js build.

Other then that, asm.js seems basically identical to the WASM.

WASM is much smaller, 416k vs 877k and seems to load faster (not
measured).

Note to reviewers:
example.html was copied from npm-wasm version, so doesn't need
further review.

Bug: skia:8216
Change-Id: Ib92b90fa6c598de85a0be319d46b25693ae5aaa4
Reviewed-on: https://skia-review.googlesource.com/148396
Reviewed-by: Stephan Altmueller <stephana@google.com>
2018-08-22 17:19:10 +00:00
Kevin Lubick
8fe1b044c3 Update Pixels to Android P
Bug: skia:
Change-Id: I0222016ff079da2199e3658f1657aecc3f80f401
Reviewed-on: https://skia-review.googlesource.com/148389
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-08-21 18:08:47 +00:00
Ben Wagner
6f099b72cf [infra] Upgrade iOS builders.
Change-Id: I13f402438825b2251a9149995d5c61b14f2e08a3
Reviewed-on: https://skia-review.googlesource.com/148122
Commit-Queue: Eric Boren <borenet@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-08-21 14:21:17 +00:00
Eric Boren
7c42e01ced [infra] Speculative fix for vpython cache
Bug: skia:8263
Change-Id: Ic5003128485116c66ae1ed61e8727b9b1c33aa1a
Reviewed-on: https://skia-review.googlesource.com/147968
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-08-20 14:39:24 +00:00
Ben Wagner
6676079d2b [infra] Add comment regarding skcms use of mac_toolchain.
No-Try: true
Change-Id: I9ca13921cdc5ed388b6b4ba46d99a2d4e4735158
Reviewed-on: https://skia-review.googlesource.com/146532
Commit-Queue: Eric Boren <borenet@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-08-20 12:26:57 +00:00
Mike Klein
c24e0c1e41 refactor cpu configs
Move all CPU configs except 8888 to new BonusConfigs bots
(and keep them running on the *SAN bots), and turn on the
new rec2020 configs there too.

Change-Id: I0bba4b88c580cb627e2842f136318d98373c0543
Reviewed-on: https://skia-review.googlesource.com/147813
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
2018-08-18 01:26:25 +00:00
Stephan Altmueller
0edb982602 Upgrade to iOS 11
Bug: skia:
Change-Id: Iad31c9857e005e5ac50b6f27127fc95df9fc5bce
Reviewed-on: https://skia-review.googlesource.com/147421
Commit-Queue: Stephan Altmueller <stephana@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2018-08-16 22:37:52 +00:00
Ben Wagner
d1910d5664 Add jobs for GTX1050 eGPU.
No-Try: true
Change-Id: I47ccf632537a71eb0e2957158ce38c4a4421952b
Reviewed-on: https://skia-review.googlesource.com/145334
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-08-09 15:22:21 +00:00
Kevin Lubick
92c9171125 [Pathkit] Add recipe for running JS tests using Docker
This adds a few JS tests (see *.spec.test) and runs them
using Karma and a Docker image containing Karma, node, and
Chrome (currently at 68).

We only add a Debug Test here because the Release version
has some test helpers (e.g. Region) compiled out.  If those
end up not mattering for tests, we can add in a Release version.


Bug: skia:8216
Change-Id: Ica6ab3a4f21688cfa175a90d42c2254d38e8fcf1
Reviewed-on: https://skia-review.googlesource.com/145723
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-08-09 14:17:28 +00:00
Ben Wagner
ce1db863ef [infra] Update Skolo Win NVIDIA drivers.
No-Try: true
Change-Id: If464ad647084aa141de9952ef8185df87a975d0f
Reviewed-on: https://skia-review.googlesource.com/145524
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-08-08 19:00:37 +00:00
Ben Wagner
30a4e3da4b Add Win OpenCL Build job.
Bug: skia:8081
Change-Id: Ibcb82389668bd9ea7395e498696417d5701761c0
Reviewed-on: https://skia-review.googlesource.com/140782
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-08-08 00:27:48 +00:00
Ben Wagner
35eb7fa813 [infra] Shuffle Mac CPU and xSAN jobs to MacBookPro11.5.
I'm keeping the Release jobs for a few commits for blame.

There are a few reasons for this change:
 - This will free up more Mac VMs for Build jobs.
 - The CPU jobs currently run on VMs, which don't provide reliable perf
   numbers.
 - The two bare-metal MacMini7.1 bots (currently running the GPU TSAN
   jobs) are over-capacity.
 - Lets us test AVX2 rather than AVX.

I used the MacBookPro11.5 for all of these, but we could spread them
out to other Mac bots if it's too much load for these bots.

No-Try: true
Change-Id: I8c97e194c4f3e0018e7e646b93c3d96db8d0ca82
Reviewed-on: https://skia-review.googlesource.com/145431
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-08-06 17:27:32 +00:00
Ben Wagner
e8d2a45e68 Update remaining Mac bots to 10.13.6, except iOS builds.
iOS builds still causing an error on installation:
ERROR: Install failed. Got error "APIInternalError".

stephana will help with debugging this when he's back in the office.

Bug: chromium:862292
Change-Id: I8fdff24938f000da550e1c5420c7ac312f09dce7
Reviewed-on: https://skia-review.googlesource.com/144440
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-08-06 15:02:44 +00:00
Ben Wagner
4c3b63e289 Update Skolo Win bots.
Change-Id: I45fb81be43de223f67a16471c772dd2fb9d18490
Reviewed-on: https://skia-review.googlesource.com/145265
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-08-03 19:52:54 +00:00
Eric Boren
9d834581da [infra] Add new go_deps asset
This contains the Go code dependencies of our infra repo and will be
used to insulate us from upstream changes which break us due to API
changes, etc.

Bug: skia:
Change-Id: I6ce36a4e41b6d7686fe2598ba980640854cd4f11
Reviewed-on: https://skia-review.googlesource.com/145158
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2018-08-03 18:33:24 +00:00
Ben Wagner
cdfa16d086 Use XCode from CIPD. Include xSAN dylibs in Build task isolated output.
Change-Id: I0eb3dcc4d38eb2aeab22d1df1515e499cf21dc62
Reviewed-on: https://skia-review.googlesource.com/144608
Commit-Queue: Eric Boren <borenet@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-08-03 17:14:14 +00:00
Eric Boren
b33f9ebe90 [infra] Update vpython CIPD package
Bug: skia:
Change-Id: Ibdfa20023019dc6372293600b0b1b4607916694f
Reviewed-on: https://skia-review.googlesource.com/145330
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-08-03 15:36:22 +00:00
Kevin Lubick
30cc00c642 Add job for building PathKit to WASM using Docker
This creates a new named cache docker for this and future
docker-based jobs to use, to avoid permission snafus with
the normal "work" named cache.

Remove old WASM build, which was using the janky CIPD
emsdk asset and wasn't really exercising what we needed.

Bug: skia:8216
Change-Id: I993bba38b4978ca5eebb97e5b5b21729d55a072d
Reviewed-on: https://skia-review.googlesource.com/145140
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-08-03 15:08:42 +00:00
Stephan Altmüller
64cc576b1f [infra] Make GS buckets for images and hash file URL configurable
This is necessary for lottie-ci so we can upload to different
buckets and fetch different hash files.

Bug: skia:
Change-Id: I98b4d551df34473e2b5fc04284b0de04fbc097f3
Reviewed-on: https://skia-review.googlesource.com/144840
Commit-Queue: Stephan Altmueller <stephana@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-08-02 07:17:21 +00:00
Ben Wagner
78077d153f Upgrade Test/Perf Mac bots to 10.13.6.
Mac Build tasks are stuck on 10.13.3 due to unresolved issues with
building iOS and MoltenVK.

Bug: chromium:862292
Change-Id: I4195971a5a027fc502aaea01570e43ec19976055
Reviewed-on: https://skia-review.googlesource.com/142330
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-07-30 11:44:45 +00:00
Ben Wagner
c062b6be5a [infra] Adjust job priorities. (skia)
After https://skia-review.googlesource.com/c/buildbot/+/141564,
scheduling will work better if most jobs use the default priority.

Since task priority is now ignored, remove it everywhere.

Bug: skia:8145
Change-Id: Ie49cfbbbda80c6d6419a8f691af6a3c775ae5cda
Reviewed-on: https://skia-review.googlesource.com/143163
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-07-25 11:17:16 +00:00
Eric Boren
8c172ba397 [infra] Add infra support for Lottie
Bug: skia:8136
Change-Id: I18c4ad549c52346ebfe23d172597d5da205e5c4d
Reviewed-on: https://skia-review.googlesource.com/142105
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2018-07-19 17:53:25 +00:00
Ben Wagner
7a87962e38 Update Win2016 bots.
Change-Id: I71f36920a11cb36c58c0c9ff1b468b77ca356c1b
Reviewed-on: https://skia-review.googlesource.com/142160
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-07-18 17:08:42 +00:00
Ben Wagner
42974b73cd Upgrade Skolo Mac bots to 10.13.6.
No-Try: true
Change-Id: Ie48e4bd1bc52180ee58327ff1c7e6d7221ef7286
Reviewed-on: https://skia-review.googlesource.com/140347
Commit-Queue: Joe Gregorio <jcgregorio@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
2018-07-12 12:28:08 +00:00
Ben Wagner
0954a19703 Update Win10 in Skolo.
No-Try: true
Change-Id: Ic939bc0b2b18d00c29b753fe7626951c3930e211
Reviewed-on: https://skia-review.googlesource.com/140790
Commit-Queue: Robert Phillips <robertphillips@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2018-07-12 00:16:43 +00:00
Kevin Lubick
3913287d8c Roll vpython to (speculatively) fix tree
Bug: skia:
Change-Id: I7114bf400f868cb3b748506343b4c6b93ecd6fbb
Reviewed-on: https://skia-review.googlesource.com/138934
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
2018-07-02 17:48:15 +00:00
Ben Wagner
a5e703043f Add OpenCL test job that runs hello-opencl.
Add NEO driver to opencl_linux asset.

Bug: skia:8081
Change-Id: Ic36c670f3cabd73119845e94fcb2f54525e83443
Reviewed-on: https://skia-review.googlesource.com/138264
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-06-29 13:25:17 +00:00
Ben Wagner
55a7d22beb Add OpenCL build.
Bug: skia:8081
Change-Id: I8b2a88cc25970398511aa078d456ca8a1182792b
Reviewed-on: https://skia-review.googlesource.com/136594
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-06-29 13:06:57 +00:00
Ben Wagner
418ff4a4e8 Upgrade MacOS on Skolo bots.
These include MacBook10.1 and MacBookAir7.2.

Change-Id: I5d90f0c95a2d0199ec498dda7ad70064bb98aa22
Reviewed-on: https://skia-review.googlesource.com/135328
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-06-22 17:20:47 +00:00
Ben Wagner
5083f5f3d2 Revert "[infra] Enable retries for Windows compiles"
This reverts commit c2a8870316.

Reason for revert: Issue causing flakiness has been resolved.

Original change's description:
> [infra] Enable retries for Windows compiles
> 
> They're flaky due to https://github.com/golang/go/issues/21376
> 
> Bug: skia:
> Change-Id: Ic629c84b72c492b35d393328aa2178762ce3c7d8
> Reviewed-on: https://skia-review.googlesource.com/123932
> Reviewed-by: Ravi Mistry <rmistry@google.com>
> Reviewed-by: Mike Klein <mtklein@google.com>
> Commit-Queue: Eric Boren <borenet@google.com>

TBR=borenet@google.com,mtklein@google.com,rmistry@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: skia:
Change-Id: Ieaae0be9796e61ca8f4265198687e847afa853aa
Reviewed-on: https://skia-review.googlesource.com/136633
Reviewed-by: Eric Boren <borenet@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-06-21 18:33:58 +00:00
Eric Boren
639244261a [recipes] Housekeeper-PerCommit-BundleRecipes needs vpython
Bug: skia:
Change-Id: I6808e6337477fa3b5ea2833e1ebc739bf65fc062
Reviewed-on: https://skia-review.googlesource.com/136523
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-06-21 16:57:52 +00:00
Stephan Altmueller
978b0bb173 [infra] Remove PixelC bot
No-Tree-Checks: true
Bug: skia:
Change-Id: Ib0a5ad3df31f4fca9ab0085a5ba1d174419eee57
Reviewed-on: https://skia-review.googlesource.com/136220
Commit-Queue: Stephan Altmueller <stephana@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2018-06-21 15:02:18 +00:00
Eric Boren
e42cef5100 Update skia swarming task template to git 2.17.1
R=borenet

Bug: chromium:847597
Change-Id: I2f9b6fb0bb42cd5ed6e497fd1fd7b8f605e26515
Reviewed-on: https://skia-review.googlesource.com/135923
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-06-20 11:32:18 +00:00
Ben Wagner
96aa535b78 Remove .bat and .exe from commands where possible.
We expect .BAT and .EXE to be on PATHEXT. Also, although Python
CreateProcess doesn't honor PATHEXT, it will try .EXE. This allows most
commands to be platform-independent, and also resolves the issue with
the cpython package not including python.bat.

No-Tree-Checks: true
Docs-Preview: https://skia.org/?cl=135626
Bug: chromium:852581
Change-Id: Iab4189407df44ff4ad4d37da07ff52414229d397
Reviewed-on: https://skia-review.googlesource.com/135626
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-06-19 17:29:15 +00:00
Eric Boren
aa037523e5 [infra] Include cpython CIPD package on Windows
No-Tree-Checks: true
Bug: skia:
Change-Id: I08854d88e33d00e4bb56eb6eb346592618bd2693
Reviewed-on: https://skia-review.googlesource.com/135579
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Auto-Submit: Eric Boren <borenet@google.com>
2018-06-18 20:47:48 +00:00
Ben Wagner
702fe01aab Update kitchen to version built with Go 1.10.3.
Bug: chromium:836196
Change-Id: I865ce1601788ec0584453ac82dde95d9fd122393
Reviewed-on: https://skia-review.googlesource.com/135140
Commit-Queue: Eric Boren <borenet@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-06-15 15:06:15 +00:00
Eric Boren
3f13bcba3e Roll infra/tools/git to 0ae21738597e5601ba90372315145fec18582fc4
Changes:
019a998b9 Retry errors caused by gerrit replication lag.

Bug: 851716
Change-Id: I9dea83b14bbb80439b1a25639fd66bae08d125c9
Reviewed-on: https://skia-review.googlesource.com/135107
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
Auto-Submit: smut <smut@google.com>
2018-06-15 12:01:14 +00:00
Ben Wagner
f2d1500643 Update Win version in Skolo.
Seems to be a force-update bypassing Windows Update settings.

Change-Id: I717fbc9362efe209197b6a89b1172786ed836286
Reviewed-on: https://skia-review.googlesource.com/134606
Commit-Queue: Stephan Altmueller <stephana@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Stephan Altmueller <stephana@google.com>
2018-06-13 19:18:16 +00:00
Ben Wagner
cd7ace2c6b Update to current CIPD packages for kitchen tasks.
Bug: chromium:836196
Change-Id: I349a3159f858e53056a49d1a06bbd09e831e6e83
Reviewed-on: https://skia-review.googlesource.com/134080
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-06-11 20:12:04 +00:00
Ben Wagner
c72c948d98 Update GalaxyS7 to Oreo.
No-Try: true
Change-Id: Ibfe5fe71356626dc22ec638f567bec1bae5c7e19
Reviewed-on: https://skia-review.googlesource.com/133827
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-06-11 18:51:34 +00:00
Eric Boren
e8b38ab432 [recipes] Make ct_skps use binaries from a build task
Bug: skia:6473
Change-Id: I10a169dd47cb76839fd401254eaeb4c46b2ece8f
Reviewed-on: https://skia-review.googlesource.com/128549
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-06-08 21:14:02 +00:00
Eric Boren
cb0b98b263 Update gen_tasks.go to use unforked glog
Required after https://skia-review.googlesource.com/130562

Bug: skia:
Change-Id: I6409622b5124422906e7acfae96acab46305e1f7
Reviewed-on: https://skia-review.googlesource.com/133042
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-06-08 12:55:41 +00:00
Ben Wagner
ece4306025 Update Windows to v1803 in Skolo.
Change-Id: I6b19e7851cb9a99725fd80bdfaeec2efab81c524
Reviewed-on: https://skia-review.googlesource.com/132263
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-06-06 20:28:24 +00:00
Ben Wagner
8d8f45d29e Update MotoG4.
No-Try: true
Change-Id: I0e8715e7e7a0f884c653e4888459a185b0870065
Reviewed-on: https://skia-review.googlesource.com/131925
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-06-05 13:50:19 +00:00
Robert Phillips
65eb4fba7e Add DDL skpbench bot for just DDL recording time
Change-Id: If75799bfd719ccc47c2064571723e6852c07bfaa
Reviewed-on: https://skia-review.googlesource.com/131144
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-05-31 17:56:26 +00:00
Robert Phillips
dbe89bb031 Add a DDL Skpbench bot
This adds a 9 threads 3x3 grid of tiles DDL SKPBench bot that reports the total time. We will
eventually want a 4x4 bot, a 1x1 bot and a 0x1 bot. Additionally, we will want another whole set
that only emits the DDL record time.

So the ultimate naming scheme would be:
DDLTotal_9x9   DDLRecord_9x9
DDLTotal_4x4   DDLRecord_4x4
DDLTotal_1x1   DDLRecord_1x1
DDLTotal_0x1

Change-Id: Ia96c79ec05602077f4112c69cb344bd8c9b2b4b1
Reviewed-on: https://skia-review.googlesource.com/130923
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-05-31 16:34:43 +00:00
Ben Wagner
3de510a20a Upgrade Pixel devices.
No-Try: true
Change-Id: Icb326a4b49ad945046d5e471d1f6e8a2a22d4d86
Reviewed-on: https://skia-review.googlesource.com/129641
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-05-23 15:07:51 +00:00
Ben Wagner
d26e446927 Rename SwiftShader bots from CPU to GPU.
Bug: skia:7671
Change-Id: I1d6b2a07ca93acbe53c1e93d70335f5284cd494e
NoTry: true
Reviewed-on: https://skia-review.googlesource.com/129500
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-05-22 16:33:05 +00:00
Chris Dalton
2b937f54c2 Add MoltenVK_Vulkan bots
Adds a prebuilt MoltenVK framework asset from:

KhronosGroup/MoltenVK.git:0279543e0bb561f8d0166d4030481136bc914fec

And creates bots that use it.

Bug: skia:
Change-Id: I081b2745c41a25de9ecd94a5363f4fb13b120215
Reviewed-on: https://skia-review.googlesource.com/128646
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2018-05-17 17:35:23 +00:00
Ben Wagner
eeeb32847e Add MacBookPro11,5 jobs.
Bug: chromium:807743
Change-Id: Iafd826c97ceaee745a70bdb1cb52f3cf9f6c1ebf
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/116461
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-05-16 15:29:14 +00:00
Ravi Mistry
5a12d0578a Run RecreateSKPs bot on SkiaCT pool which has more disk space
Should not take up much capacity since it only runs once a day.

Bug: skia:7917
Change-Id: I6e489341032ef40df8cedae4e92c5f00d9a2df91
Reviewed-on: https://skia-review.googlesource.com/128405
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-05-16 14:42:57 +00:00
Ben Wagner
297e86b43e [infra] Switch back to 16-core GCE VMs for Perf and Test.
This partially reverts
https://skia-review.googlesource.com/c/skia/+/124340

Bug: skia:7415, skia:7416
Change-Id: I2a838ff3c543ded54e962e905294811fbc97ef88
Reviewed-on: https://skia-review.googlesource.com/127965
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-05-14 17:14:19 +00:00
Ben Wagner
27d5a3661b Switch machine-type for Coverage tasks.
Coverage doesn't seem to deal well with multiple threads. Using 2-core
VMs is faster than using 64-core VMs.

On the other hand, the Coverage Upload task performs much better on a
64-core VM.

Bug: skia:7415
No-Try: true
Change-Id: Ieb58fc47970dd66fa64cf6a8c9de1f9236e2f3a0
Reviewed-on: https://skia-review.googlesource.com/127053
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2018-05-10 15:45:45 +00:00
Kevin Lubick
a585f73bbe Remove T8888 from Windows CQ bot
This is a stop-gap measure.

Bug: skia:7838#c20
Change-Id: Ib9af9aefa4327d24f66f95d9a82ee53c19733524
Reviewed-on: https://skia-review.googlesource.com/126461
Reviewed-by: Mike Klein <mtklein@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2018-05-07 16:43:28 +00:00
Ben Wagner
e99a4b1099 [infra] Move GCE tasks to smaller/larger VMs.
Bug: skia:7415, skia:7416
Change-Id: Ibdd391dce62ff16bfc7fa8d860c3cbcaddab7c4d
Reviewed-on: https://skia-review.googlesource.com/124340
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-05-04 19:13:43 +00:00
Eric Boren
44a68b3b3b [infra] Remove PDFium bot and associated recipe code
Bug: skia:7890
Change-Id: I8322b145800dc41ac59322e89804ff9356d8e767
Reviewed-on: https://skia-review.googlesource.com/125864
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-05-04 14:59:32 +00:00
Eric Boren
2f62de01d3 [recipes] Mostly remove bot_update patch_ref hack
We need to do some refactoring to remove the repository hack for
cross-repo tryjobs.

Bug: skia:6473
Change-Id: Ie96fba75f6f1752575a4c7cc5b0208a37f0bd73d
Reviewed-on: https://skia-review.googlesource.com/125724
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-05-03 14:37:31 +00:00
Kevin Lubick
e467d4e656 Update all remaining Chromebooks to m67
Bug: skia:
Change-Id: Ice96cc476b8f022fea250c88c1ec16de6482c704
Reviewed-on: https://skia-review.googlesource.com/124984
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-05-01 17:37:34 +00:00
Kevin Lubick
ff8387fae4 Update SamsungChromebook2012 to m67
Bug: skia:
Change-Id: Icf90148fadb2293c300962bdf3551c0a9cf1aee0
Reviewed-on: https://skia-review.googlesource.com/124811
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-05-01 15:12:34 +00:00
Kevin Lubick
e114e59f37 Update MaliT764 Chromebooks
Bug: skia:
NOTRY=true
Change-Id: I739e3596e1266df6c533f552b5583de2a5f5f9f5
Reviewed-on: https://skia-review.googlesource.com/124808
Reviewed-by: Eric Boren <borenet@google.com>
2018-05-01 13:17:48 +00:00
Eric Boren
5cb5c74efd Reland "[recipes] Use named caches for git and workdirs"
This reverts commit 01d3eb64e7.

Bug: skia:
Change-Id: Ic05b89009eb59a231488bef382dd232a50d2b00f
Reviewed-on: https://skia-review.googlesource.com/124260
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-04-27 18:18:48 +00:00
Ben Wagner
82a3342516 [infra] Specify machine_type dimension for Linux GCE bots.
This is in preparation of assigning bots either "small" or "large" GCE
machines.

Bug: skia:7415, skia:7416
Change-Id: I82b6fe454ba3622ef8a9d515dc3e72362dd30ee5
Reviewed-on: https://skia-review.googlesource.com/124183
Commit-Queue: Eric Boren <borenet@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-04-27 12:51:47 +00:00
Ben Wagner
01d3eb64e7 Revert "[recipes] Use named caches for git and workdirs"
This reverts commit e8615f969e.

Reason for revert: Causing CommandBuffer builds to time out

Original change's description:
> [recipes] Use named caches for git and workdirs
>
> Bug: skia:
> Change-Id: Iaf3d190252c9483c8b9e58a3ab0305db4173cc1c
> Reviewed-on: https://skia-review.googlesource.com/123929
> Commit-Queue: Eric Boren <borenet@google.com>
> Reviewed-by: Ben Wagner <benjaminwagner@google.com>

----------------

Revert "[infra] Fix missing cache for Bookmaker"

This reverts commit d19f039a16.

Reason for revert: Need to revert https://skia-review.googlesource.com/123929

Original change's description:
> [infra] Fix missing cache for Bookmaker
>
> Bug: skia:
> Change-Id: I12d42fa1bb364ea6c75865f72143daf92b8c12c3
> Reviewed-on: https://skia-review.googlesource.com/124052
> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
> Commit-Queue: Eric Boren <borenet@google.com>

----------------

Revert "Fix missing/duplicate named caches"

This reverts commit 0820a6fb69.

Reason for revert: Need to revert https://skia-review.googlesource.com/123929

Original change's description:
> Fix missing/duplicate named caches
>
> Fixes issue with https://skia-review.googlesource.com/c/skia/+/123929
>
> No-Try: true
> Change-Id: I582b2bba67b8b257f35c5b85ccfe6e6304ff7a7c
> Reviewed-on: https://skia-review.googlesource.com/124180
> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
> Auto-Submit: Ben Wagner <benjaminwagner@google.com>
> Reviewed-by: Ravi Mistry <rmistry@google.com>

----------------

TBR=borenet@google.com,benjaminwagner@google.com,rmistry@google.com

Change-Id: Id8443ad9dc50f018251a6b6892b06fe256e6c578
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/124203
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2018-04-26 22:21:04 +00:00
Ben Wagner
0820a6fb69 Fix missing/duplicate named caches
Fixes issue with https://skia-review.googlesource.com/c/skia/+/123929

No-Try: true
Change-Id: I582b2bba67b8b257f35c5b85ccfe6e6304ff7a7c
Reviewed-on: https://skia-review.googlesource.com/124180
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2018-04-26 21:14:43 +00:00
Ben Wagner
be9aa8d006 Update Win2016 bots.
Change-Id: I6b8a16dd6aa1d188a46ca1bdf82c4023d6bab21a
Reviewed-on: https://skia-review.googlesource.com/124043
Commit-Queue: Eric Boren <borenet@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-04-26 19:55:29 +00:00
Eric Boren
d19f039a16 [infra] Fix missing cache for Bookmaker
Bug: skia:
Change-Id: I12d42fa1bb364ea6c75865f72143daf92b8c12c3
Reviewed-on: https://skia-review.googlesource.com/124052
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-04-26 19:53:53 +00:00
Eric Boren
e8615f969e [recipes] Use named caches for git and workdirs
Bug: skia:
Change-Id: Iaf3d190252c9483c8b9e58a3ab0305db4173cc1c
Reviewed-on: https://skia-review.googlesource.com/123929
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2018-04-26 18:51:13 +00:00
Kevin Lubick
88611a1a71 Update test expectations for Debian9
The removal of the blacklists is really a no-op because of
https://skia-review.googlesource.com/c/skia/+/9339

Bug: skia:7840
Change-Id: I72e2e03bbbc813737655a3d5f3a1e874d3a41909
Reviewed-on: https://skia-review.googlesource.com/123925
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-04-26 17:16:53 +00:00
Eric Boren
e7950e3923 [infra] RecreateSKPs and Bookmaker need the Git packages
Bug: skia:7833, skia:7050
Change-Id: I8272e4b0beaed2a56260546f4a599a4586c71792
Reviewed-on: https://skia-review.googlesource.com/123921
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-04-26 16:28:53 +00:00
Eric Boren
c2a8870316 [infra] Enable retries for Windows compiles
They're flaky due to https://github.com/golang/go/issues/21376

Bug: skia:
Change-Id: Ic629c84b72c492b35d393328aa2178762ce3c7d8
Reviewed-on: https://skia-review.googlesource.com/123932
Reviewed-by: Ravi Mistry <rmistry@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-04-26 16:18:23 +00:00
Eric Boren
1178ea0f7b [infra] Make the Android_Framework bot run on demand
This causes it to never get triggered automatically, so it will only run
as a try job or when force-triggered.

Caveat: if the job is defined on non-master branches, it will still
trigger for those branches.

Bug: skia:
Change-Id: Idff63bd22536b21ec21eb4b569cc392642297d7b
Reviewed-on: https://skia-review.googlesource.com/123923
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-04-26 13:22:43 +00:00
Eric Boren
b66099b9fb [infra] Run presubmit like a normal bot
Bug: skia:
Change-Id: If01c10c21477bd61c4ec1d4f59921745eb3bf494
Reviewed-on: https://skia-review.googlesource.com/123622
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-04-25 19:36:47 +00:00
Ben Wagner
f8f1839cc8 Upgrade Win Radeon driver.
Bug: skia:7809
Change-Id: I9266a16acee92f5a5fcb8e723890c1793c957bf3
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/123589
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-04-25 16:45:57 +00:00