bsalomon
2259c5f650
Disable CopySurface test on Nexus 10 for flakiness
...
BUG=skia:5509
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2169073003
Review-Url: https://codereview.chromium.org/2169073003
2016-07-22 04:09:47 -07:00
msarett
530c844d25
Remove unnecessary getColorSpace() API from SkCodec
...
Not needed since now we can get it from the SkImageInfo.
TBR=reed@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2170793004
Review-Url: https://codereview.chromium.org/2170793004
2016-07-21 11:57:49 -07:00
caryclark
81681949d3
allow curves on side of lines to be very small
...
Increase the precision of the 'all on one side' pathops
angle test to reduce the number of unorderable segments
found by the cubics_d3 test.
This allows pathsops_unittest release build with -v -V -x
to run without error.
TBR=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2168163002
Review-Url: https://codereview.chromium.org/2168163002
2016-07-21 10:44:07 -07:00
borenet
85f0e63ca4
Add "skp" asset
...
Don't get rid of SKP_VERSION and associated stuff just yet.
BUG=skia:5427
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2167763002
DOCS_PREVIEW= https://skia.org/?cl=2167763002
Review-Url: https://codereview.chromium.org/2167763002
2016-07-21 10:27:00 -07:00
vjiaoblack
95302da19d
Creating framework for drawShadowedPicture
...
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146073003
Committed: https://skia.googlesource.com/skia/+/0ae097d116f4332be02a135ffc99c162473dee6a
Review-Url: https://codereview.chromium.org/2146073003
2016-07-21 10:25:54 -07:00
vjiaoblack
33d325890e
Revert of Creating framework for drawShadowedPicture (patchset #14 id:260001 of https://codereview.chromium.org/2146073003/ )
...
Reason for revert:
Decided to re-wait for a final LGTM.
Already found a bug in variable naming to fix.
Original issue's description:
> Creating framework for drawShadowedPicture
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146073003
>
> Committed: https://skia.googlesource.com/skia/+/0ae097d116f4332be02a135ffc99c162473dee6a
TBR=reed@google.com ,robertphillips@google.com,bsalomon@google.com,jvanverth@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/2167223002
2016-07-21 09:24:16 -07:00
robertphillips
5fa7f30331
Remove DrawFace enum from GrPipelineBuilder
...
This gets GrPipelineBuilder.h out of the headers
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2165283002
Committed: https://skia.googlesource.com/skia/+/da152ebb032c61bb2561bbb3e9a78037ad174d34
Review-Url: https://codereview.chromium.org/2165283002
2016-07-21 09:21:04 -07:00
vjiaoblack
0ae097d116
Creating framework for drawShadowedPicture
...
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146073003
Review-Url: https://codereview.chromium.org/2146073003
2016-07-21 09:10:23 -07:00
robertphillips
5d1676c751
Revert of Remove DrawFace enum from GrPipelineBuilder (patchset #2 id:20001 of https://codereview.chromium.org/2165283002/ )
...
Reason for revert:
No Vulkan bot in CQ :(
Original issue's description:
> Remove DrawFace enum from GrPipelineBuilder
>
> This gets GrPipelineBuilder.h out of the headers
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2165283002
>
> Committed: https://skia.googlesource.com/skia/+/da152ebb032c61bb2561bbb3e9a78037ad174d34
TBR=bsalomon@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/2167193002
2016-07-21 08:18:05 -07:00
bsalomon
9f071d1fa5
Update build_command_buffer.py to copy libcommand_buffer_gles2.so from the correct dir on linux
...
Apparently the linux build now puts the library in chromium's output dir rather than a lib/ subdir.
TBR=borenet@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2165013003
Review-Url: https://codereview.chromium.org/2165013003
2016-07-21 08:05:01 -07:00
robertphillips
da152ebb03
Remove DrawFace enum from GrPipelineBuilder
...
This gets GrPipelineBuilder.h out of the headers
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2165283002
Review-Url: https://codereview.chromium.org/2165283002
2016-07-21 07:58:41 -07:00
robertphillips
ea70c4bb22
Remove SkDevice::accessRenderTarget virtual
...
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2167723002
Review-Url: https://codereview.chromium.org/2167723002
2016-07-20 08:54:31 -07:00
bungeman
fbbf01af04
Add iOS to platform_os_emoji.
...
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2164783004
Review-Url: https://codereview.chromium.org/2164783004
2016-07-20 07:15:16 -07:00
martina.kollarova
7b70156334
Fix context creation problems in dm
...
Fixes these issues:
1. The glXCreateContextAttribsARB call seems to modify the
context_attrib parameter upon failure. Since context_attrib was static,
if it first tried to create an OpenGL 4.4 context and it failed, further
attempts to create a context with lower versions would also fail.
2. Getting an OpenGL 3.0 context was never tried.
3. Context creation for ES 3.0 was failing on my machine. Since ES 2.0
looks like the intended version from the surrounding code, I set it to
that. It could be rewritten to use a similar loop as standard OpenGL and
try from the highest version to the lowest.
BUG=skia:5403
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2147513002
Review-Url: https://codereview.chromium.org/2147513002
2016-07-20 07:01:46 -07:00
borenet
c8fcb9ce82
Add "Infra" to the builder_name_schema
...
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2154433002
Review-Url: https://codereview.chromium.org/2154433002
2016-07-20 05:54:50 -07:00
jvanverth
a3f3caccdf
Stub in Mac viewer code.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2164683002
patch from issue 2164683002 at patchset 1 (http://crrev.com/2164683002#ps1 )
Review-Url: https://codereview.chromium.org/2167503002
2016-07-19 14:17:20 -07:00
bsalomon
c7b4b28496
Make sk_app::WindowContext directly create a SkSurface without an intermediate GrRenderTarget
...
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2165703002
Review-Url: https://codereview.chromium.org/2165703002
2016-07-19 09:46:29 -07:00
fmenozzi
d876a4b549
Add bounds info
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2159853003
Review-Url: https://codereview.chromium.org/2159853003
2016-07-18 13:33:37 -07:00
brianosman
54f30c13fc
Introduce GrColorSpaceXform, for gamut conversion on textures
...
GrTextureAccess optionally includes an instance, computed from the src
and dst color spaces. In all common cases (no color space for either src
or dst, or same color space for both), no object is allocated.
This change is orthogonal to my attempts to get color space attached to
render targets - regardless of how we choose to do that, this will give
us the source color space at all points where we are connecting src to
dst.
There are many dangling injection points where I've been inserting
nullptr, but I have a record of all of them. Additionally, there are now
three places (the most common simple paths for bitmap/image rendering)
where things are plumbed enough that I expect to have access to the dst
color space (all marked with XFORMTODO).
In addition to getting the dst color space, I need to inject shader code
and uniform uploading for appendTextureLookup and friends.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2154753003
Review-Url: https://codereview.chromium.org/2154753003
2016-07-18 10:53:52 -07:00
caryclark
55888e4417
pathops coincidence and security rewrite
...
Most changes stem from working on an examples bracketed
by #if DEBUG_UNDER_DEVELOPMENT // tiger
These exposed many problems with coincident curves,
as well as errors throughout the code.
Fixing these errors also fixed a number of fuzzer-inspired
bug reports.
* Line/Curve Intersections
Check to see if the end of the line nearly intersects
the curve. This was a FIXME in the old code.
* Performance
Use a central chunk allocator.
Plumb the allocator into the global variable state
so that it can be shared. (Note that 'SkGlobalState'
is allocated on the stack and is visible to children
functions but not other threads.)
* Refactor
Let SkOpAngle grow up from a structure to a class.
Let SkCoincidentSpans grow up from a structure to a class.
Rename enum Alias to AliasMatch.
* Coincidence Rewrite
Add more debugging to coincidence detection.
Parallel debugging routines have read-only logic to report
the current coincidence state so that steps through the
logic can expose whether things got better or worse.
More functions can error-out and cause the pathops
engine to non-destructively exit.
* Accuracy
Remove code that adjusted point locations. Instead,
offset the curve part so that sorted curves all use
the same origin.
Reduce the size (and influence) of magic numbers.
* Testing
The debug suite with verify and the full release suite
./out/Debug/pathops_unittest -v -V
./out/Release/pathops_unittest -v -V -x
expose one error. That error is captured as cubics_d3.
This error exists in the checked in code as well.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2128633003
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2128633003
Review-Url: https://codereview.chromium.org/2128633003
2016-07-18 10:01:36 -07:00
fmenozzi
f023e6879c
Add filename to gradient scrape
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2160583002
Review-Url: https://codereview.chromium.org/2160583002
2016-07-18 08:20:06 -07:00
msarett
9ce3a543c9
Add capability for SkColorXform to output half floats
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2147763002
CQ_INCLUDE_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot;master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review-Url: https://codereview.chromium.org/2147763002
2016-07-15 13:54:38 -07:00
fmenozzi
016e51fb06
Add verb field in scraping scripts
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2150663002
Review-Url: https://codereview.chromium.org/2150663002
2016-07-14 07:44:50 -07:00
vjiaoblack
e5de130788
Added the framework for having canvas/recorder/picture record depth_set's.
...
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2127233002
Committed: https://skia.googlesource.com/skia/+/6d3fb898d5f73a82e36f11c712a633c3921ed518
Committed: https://skia.googlesource.com/skia/+/1185d90c785f743364cc9113d7007a59af07470c
Review-Url: https://codereview.chromium.org/2127233002
2016-07-13 14:05:28 -07:00
mtklein
6c3ada96ab
Turn back on nanobench on Debug trybots.
...
Swarming makes the extra wall-clock cost negligible.
TBR=
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2142223004
Review-Url: https://codereview.chromium.org/2142223004
2016-07-13 09:44:18 -07:00
mtklein
6e998e6137
Revert "Added the framework for having canvas/recorder/picture record depth_set's."
...
1-click revert failed again.
This reverts commit 1185d90c78
.
BUG=skia:
TBR=
NOTRY=true
Review-Url: https://codereview.chromium.org/2147963002
2016-07-13 09:03:48 -07:00
vjiaoblack
1185d90c78
Added the framework for having canvas/recorder/picture record depth_set's.
...
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2127233002
Committed: https://skia.googlesource.com/skia/+/6d3fb898d5f73a82e36f11c712a633c3921ed518
Review-Url: https://codereview.chromium.org/2127233002
2016-07-13 08:35:41 -07:00
msarett
f461e7c227
Try blacklisting RAW images on Nexus 9
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2141923006
Review-Url: https://codereview.chromium.org/2141923006
2016-07-13 08:03:35 -07:00
mtklein
e504dbc092
Revert "Added the framework for having canvas/recorder/picture record depth_set's."
...
1-click revert failed.
This reverts commit 6d3fb898d5
.
TBR=
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2148543002
Review-Url: https://codereview.chromium.org/2148543002
2016-07-12 15:41:08 -07:00
borenet
c4600204f2
Run the Vulkan config on nanobench for Vulkan bots
...
BUG=skia:5513
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2145633002
Review-Url: https://codereview.chromium.org/2145633002
2016-07-12 15:11:35 -07:00
brianosman
6373c95554
Monitor profile tool, now with Windows support, too!
...
Original Mac support by Matt.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2095093002
Review-Url: https://codereview.chromium.org/2141573004
2016-07-12 15:06:25 -07:00
fmenozzi
90ccfbaf2e
Fix Lua bugs, nit name change
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2140293002
Review-Url: https://codereview.chromium.org/2140293002
2016-07-12 14:55:39 -07:00
vjiaoblack
6d3fb898d5
Added the framework for having canvas/recorder/picture record depth_set's.
...
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2127233002
Review-Url: https://codereview.chromium.org/2127233002
2016-07-12 14:50:41 -07:00
mtklein
2052f313f0
Enable SkTaskGroup threading in monobench.
...
Without this Enabler, SkTaskGroups all run serially.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2139423002
Review-Url: https://codereview.chromium.org/2139423002
2016-07-12 14:50:28 -07:00
halcanary
f119796f95
tools/SkShaper: SkStream->blob
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2142023002
Review-Url: https://codereview.chromium.org/2142023002
2016-07-12 09:17:43 -07:00
fmenozzi
7f2c85e66b
Add hard stop count
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2141733002
Review-Url: https://codereview.chromium.org/2141733002
2016-07-12 09:17:39 -07:00
brianosman
e1d2007924
Respect --match for samples and jpgs in viewer
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2144643002
Review-Url: https://codereview.chromium.org/2144643002
2016-07-12 09:07:33 -07:00
halcanary
8792e523dc
tools/fiddle: remove unused fiddler.go
...
Review-Url: https://codereview.chromium.org/2138153002
2016-07-11 16:26:26 -07:00
halcanary
8a74f13239
tools/SkShaper: factor shaping out of using_skia_and_harfbuzz
...
Make a clearer demarcation between shaping and layout.
also: refactor using_skia_and_harfbuzz; stop leaking
like a sieve.
Review-Url: https://codereview.chromium.org/2138133002
2016-07-11 14:30:39 -07:00
mtklein
7e602c2c6c
hacking on a single-benchmark tool
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2012413004
Review-Url: https://codereview.chromium.org/2012413004
2016-07-11 11:27:30 -07:00
reed
babc3de2ce
deferred canvas
...
tries to eliminate unneeded clipRects and concats (and their associated save/restores).
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2120333002
Review-Url: https://codereview.chromium.org/2120333002
2016-07-08 08:43:28 -07:00
reed
63f30d9049
fix typos and capitalization on drawTextRSXform CL
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2123923006
Review-Url: https://codereview.chromium.org/2123923006
2016-07-07 16:32:51 -07:00
reed
6d2c3e7da6
add bounds to textblob
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2124113003
TBR=
Review-Url: https://codereview.chromium.org/2124113003
2016-07-07 14:10:14 -07:00
reed
45561a0b15
drawTextRSXform
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2130643004
Review-Url: https://codereview.chromium.org/2130643004
2016-07-07 12:47:17 -07:00
liyuqian
2edb0f4a02
More accurate render time and continuous fresh
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2129613002
Review-Url: https://codereview.chromium.org/2129613002
2016-07-06 14:11:32 -07:00
csmartdalton
0d28e574ac
Fix caching of sample locations
...
The original caching logic for sample locations wishfully assumed that
the GPU would always use the same sample pattern for render targets
that had the same number of samples. It turns out we can't rely on
that. This change improves the caching logic to handle mismatched
simple patterns with the same count, and adds a unit test that
emulates different sample patterns observed on real hardware.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2111423002
Committed: https://skia.googlesource.com/skia/+/09d49a3bfe2d1e652a648ce1ea0962b38d10d166
Review-Url: https://codereview.chromium.org/2111423002
2016-07-06 09:59:43 -07:00
jvanverth
7ec9241330
Add resource tracking output and command buffer recycling
...
BUG=skia:5042
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2115993002
Review-Url: https://codereview.chromium.org/2115993002
2016-07-06 09:24:57 -07:00
benjaminwagner
c3ea34b1ae
Blacklist fontscalerdistortable on Win8.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=2109583003
Review-Url: https://codereview.chromium.org/2109583003
2016-07-06 06:55:04 -07:00
rmistry
42e6798696
Revert of Fix caching of sample locations (patchset #3 id:40001 of https://codereview.chromium.org/2111423002/ )
...
Reason for revert:
Seems to be causing Chromium roll failures:
* https://codereview.chromium.org/2120373003
* https://codereview.chromium.org/2117193002
* https://codereview.chromium.org/2124653002
Original issue's description:
> Fix caching of sample locations
>
> The original caching logic for sample locations wishfully assumed that
> the GPU would always use the same sample pattern for render targets
> that had the same number of samples. It turns out we can't rely on
> that. This change improves the caching logic to handle mismatched
> simple patterns with the same count, and adds a unit test that
> emulates different sample patterns observed on real hardware.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2111423002
>
> Committed: https://skia.googlesource.com/skia/+/09d49a3bfe2d1e652a648ce1ea0962b38d10d166
TBR=bsalomon@google.com ,csmartdalton@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/2120403002
2016-07-04 17:45:06 -07:00
csmartdalton
09d49a3bfe
Fix caching of sample locations
...
The original caching logic for sample locations wishfully assumed that
the GPU would always use the same sample pattern for render targets
that had the same number of samples. It turns out we can't rely on
that. This change improves the caching logic to handle mismatched
simple patterns with the same count, and adds a unit test that
emulates different sample patterns observed on real hardware.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2111423002
Review-Url: https://codereview.chromium.org/2111423002
2016-07-04 15:55:17 -07:00