skia2

AuroraMiddleware/skia2

Fork 0

Commit Graph

Author	SHA1	Message	Date
John Stiles	dfe33f49f5	Add a setting to disable SkVM variable traces. This will allow the visualizer to see line-number information without incurring the code bloat caused by trace_var. For reference, Commutative.skvm with no debug traces: https://osscs.corp.google.com/skia/skia/+/main:tests/sksl/runtime/Commutative.skvm;drc=c809e5ba9fc9bc67291d088c448ed0057371b760 Change-Id: If98b5e102571d7fe06a1653d199e3ae035b3cb78 Bug: skia:12692 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/478417 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Julia Lavrova <jlavrova@google.com> Commit-Queue: John Stiles <johnstiles@google.com>	2021-12-01 17:25:59 +00:00
John Stiles	030f8260a7	Add debug traces to an existing test. This demonstrates how much additional non-trace code can be generated when debug traces are turned on. A followup CL adds a setting to disable `trace_var`, which eliminates a significant percentage of the additional ops (at the cost of removing valuable debug info). Change-Id: I238e28e6f6531f1dbccfef8f1dcd24a1e8481669 Bug: skia:12692 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/478416 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Julia Lavrova <jlavrova@google.com>	2021-12-01 17:25:59 +00:00
John Stiles	626dbe195a	Add test for commutative operations in SkVM. SkVM should be able to optimize away these equivalent expressions: (intA & intB) <-> (intB & intA) (intA ^ intB) <-> (intB ^ intA) (intA \| intB) <-> (intB \| intA) (intA + intB) <-> (intB + intA) (intA * intB) <-> (intB * intA) (intA == intB) <-> (intB == intA) (intA != intB) <-> (intB != intA) These should be guaranteed by IEEE754 as well: (floatA + floatB) <-> (floatB + floatA) (floatA * floatB) <-> (floatB * floatA) I've added a test to demonstrate existing behavior, which leaves these optimizations on the table. Change-Id: I01ce1d6f1cfadb3d77db405a83752c9dd52c99bd Reviewed-on: https://skia-review.googlesource.com/c/skia/+/473238 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Osman <brianosman@google.com>	2021-11-18 21:16:48 +00:00

Author

SHA1

Message

Date

John Stiles

dfe33f49f5

Add a setting to disable SkVM variable traces.

This will allow the visualizer to see line-number information without
incurring the code bloat caused by trace_var.

For reference, Commutative.skvm with no debug traces:
https://osscs.corp.google.com/skia/skia/+/main:tests/sksl/runtime/Commutative.skvm;drc=c809e5ba9fc9bc67291d088c448ed0057371b760

Change-Id: If98b5e102571d7fe06a1653d199e3ae035b3cb78
Bug: skia:12692
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/478417
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Julia Lavrova <jlavrova@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>

2021-12-01 17:25:59 +00:00

John Stiles

030f8260a7

Add debug traces to an existing test.

This demonstrates how much additional non-trace code can be generated
when debug traces are turned on. A followup CL adds a setting to disable
`trace_var`, which eliminates a significant percentage of the additional
ops (at the cost of removing valuable debug info).

Change-Id: I238e28e6f6531f1dbccfef8f1dcd24a1e8481669
Bug: skia:12692
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/478416
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Julia Lavrova <jlavrova@google.com>

2021-12-01 17:25:59 +00:00

John Stiles

626dbe195a

Add test for commutative operations in SkVM.

SkVM should be able to optimize away these equivalent expressions:

	(intA & intB)   <->  (intB & intA)
	(intA ^ intB)   <->  (intB ^ intA)
	(intA | intB)   <->  (intB | intA)
	(intA + intB)   <->  (intB + intA)
	(intA * intB)   <->  (intB * intA)
	(intA == intB)  <->  (intB == intA)
	(intA != intB)  <->  (intB != intA)

These should be guaranteed by IEEE754 as well:

	(floatA + floatB)   <->  (floatB + floatA)
	(floatA * floatB)   <->  (floatB * floatA)

I've added a test to demonstrate existing behavior, which leaves these
optimizations on the table.

Change-Id: I01ce1d6f1cfadb3d77db405a83752c9dd52c99bd
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/473238
Auto-Submit: John Stiles <johnstiles@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>

2021-11-18 21:16:48 +00:00

3 Commits