Commit Graph

4 Commits

Author SHA1 Message Date
Michael Ludwig
1374c85fbf Prevent op batching in clear benchmark
This is a different way of fixing the clear benchmark measurements,
since https://skia-review.googlesource.com/c/skia/+/184064 seemed to
cause device issues on several bots.

Instead of forcing a flush, this takes extra steps to prevent the clear
ops from batching in Ganesh, and from resetting the op list, which has
the same effect of ensuring "loop" count clears are actually sent to
the GPU.

Bug: skia:
Change-Id: Id7f58894f42ca55a6cb663b65c27901d65432f82
Reviewed-on: https://skia-review.googlesource.com/c/184384
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Auto-Submit: Michael Ludwig <michaelludwig@google.com>
2019-01-16 16:11:34 +00:00
Michael Ludwig
b961d642fd Revert "Force flush in clear benchmarks"
This reverts commit 75294fe3e8.

Reason for revert: nanobench hangs on Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Release-All

Original change's description:
> Force flush in clear benchmarks
> 
> Bug: skia:
> Change-Id: I9d373dbcf78c6fe52f74deb37d8e08595d3a7c28
> Reviewed-on: https://skia-review.googlesource.com/c/184064
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Commit-Queue: Michael Ludwig <michaelludwig@google.com>

TBR=bsalomon@google.com,michaelludwig@google.com

Change-Id: I6eba0057bff7399023f6324a79b80b93ff087eb0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/c/184193
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2019-01-15 21:21:04 +00:00
Michael Ludwig
75294fe3e8 Force flush in clear benchmarks
Bug: skia:
Change-Id: I9d373dbcf78c6fe52f74deb37d8e08595d3a7c28
Reviewed-on: https://skia-review.googlesource.com/c/184064
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2019-01-15 17:46:59 +00:00
Michael Ludwig
076238f306 Add clear benchmark
Bug: skia:
Change-Id: I2cfc365e41942ad7cc3fbdf9b815df6e25b1f36f
Reviewed-on: https://skia-review.googlesource.com/c/160601
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2018-10-08 21:13:26 +00:00